github/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent synced 2025-07-16 02:03:07 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Remove closed connections immediately

Browse source 
Previously it relied on a timer to drop dead connections but that proved to
be too slow when there is an incoming burst of connections.

Fixes #10487.
This commit is contained in:
Chocobo1 2019-04-15 19:52:49 +08:00
parent 19dfec1e0a
commit a35b6cc8dd
No known key found for this signature in database
GPG key ID: 210D9C873253A68C
2 changed files with 11 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/base/http/server.cpp
View file

@ -108,15 +108,22 @@ void Server::incomingConnection(const qintptr socketDescriptor)
auto *c = new Connection(serverSocket, m_requestHandler, this); auto *c = new Connection(serverSocket, m_requestHandler, this);
m_connections.append(c); m_connections.append(c);
connect(serverSocket, &QAbstractSocket::disconnected, this, [c, this]() { removeConnection(c); });
}
void Server::removeConnection(Connection *connection)
{
m_connections.removeOne(connection);
connection->deleteLater();
} }
void Server::dropTimedOutConnection() void Server::dropTimedOutConnection()
{ {
QMutableListIterator<Connection *> i(m_connections); QMutableListIterator<Connection *> i(m_connections);
while (i.hasNext()) { while (i.hasNext()) {
const auto *connection = i.next(); Connection *connection = i.next();
if (connection->isClosed() || connection->hasExpired(KEEP_ALIVE_DURATION)) { if (connection->hasExpired(KEEP_ALIVE_DURATION)) {
delete connection; connection->deleteLater();
i.remove(); i.remove();
} }
} }

1
src/base/http/server.h
View file

@ -56,6 +56,7 @@ namespace Http
private: private:
void incomingConnection(qintptr socketDescriptor); void incomingConnection(qintptr socketDescriptor);
void removeConnection(Connection *connection);
IRequestHandler *m_requestHandler; IRequestHandler *m_requestHandler;
QList<Connection *> m_connections; // for tracking persistent connections QList<Connection *> m_connections; // for tracking persistent connections