Use QSet for tracking server connections

We don't need to maintain order between connections so QSet would be more suitable.
This commit is contained in:
Chocobo1 2019-04-15 21:22:11 +08:00
parent a35b6cc8dd
commit a2a669572c
No known key found for this signature in database
GPG key ID: 210D9C873253A68C
2 changed files with 5 additions and 4 deletions

View file

@ -107,19 +107,19 @@ void Server::incomingConnection(const qintptr socketDescriptor)
}
auto *c = new Connection(serverSocket, m_requestHandler, this);
m_connections.append(c);
m_connections.insert(c);
connect(serverSocket, &QAbstractSocket::disconnected, this, [c, this]() { removeConnection(c); });
}
void Server::removeConnection(Connection *connection)
{
m_connections.removeOne(connection);
m_connections.remove(connection);
connection->deleteLater();
}
void Server::dropTimedOutConnection()
{
QMutableListIterator<Connection *> i(m_connections);
QMutableSetIterator<Connection *> i(m_connections);
while (i.hasNext()) {
Connection *connection = i.next();
if (connection->hasExpired(KEEP_ALIVE_DURATION)) {