From 9c4f798d93d8151337e02dc0db629ddec9d953ae Mon Sep 17 00:00:00 2001 From: Eugene Shalygin Date: Sat, 17 Dec 2016 17:35:40 +0100 Subject: [PATCH] Print warning to the user if stacktrace contains no function names Count matched function names, and if there are no, point out to the user that the stacktrace is useless. If not all stactrace elements contain function names, suggest user that installing debug packages may improve the stacktrace usefulness. --- src/app/stacktrace.h | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/app/stacktrace.h b/src/app/stacktrace.h index f731240ca..03639ba8a 100644 --- a/src/app/stacktrace.h +++ b/src/app/stacktrace.h @@ -33,6 +33,7 @@ static inline void print_stacktrace(FILE *out = stderr, unsigned int max_frames size_t funcnamesize = 256; char *funcname = (char *)malloc(funcnamesize); + int functionNamesFound = 0; // iterate over the returned symbol lines. skip the first, it is the // address of this function. for (int i = 2; i < addrlen; i++) { @@ -78,6 +79,7 @@ static inline void print_stacktrace(FILE *out = stderr, unsigned int max_frames fprintf(out, " %s : %s()+%s %s\n", symbollist[i], begin_name, begin_offset, ++end_offset); } + ++functionNamesFound; } else { // couldn't parse the line? print the whole line. @@ -85,6 +87,14 @@ static inline void print_stacktrace(FILE *out = stderr, unsigned int max_frames } } + if (!functionNamesFound) { + fprintf(out, "There were no function names found in the stack trace\n." + "Seems like debug symbols are not installed, and the stack trace is useless.\n"); + } + if (functionNamesFound < addrlen - 2) { + fprintf(out, "Consider installing debug symbols for packages containing files with empty" + " function names (i.e. empty braces \"()\") to make your stack trace more useful\n"); + } free(funcname); free(symbollist); }