github/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent synced 2025-07-29 19:18:42 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Give better name to parameter checking function

Browse source 
This function will throw exceptions if the required parameters do not
exsit hence a stronger word is more appropriate here.

Also change the function parameter type to QVector. We don't need the
duplicate entries checking as currently we only use 3 fields at max and
can be easily checked by hand. So drop back to QVector which can be
constructed more efficiently.
This commit is contained in:
Chocobo1 2019-11-06 13:31:06 +08:00
parent 9cb07db84b
commit 9b5df92078
No known key found for this signature in database
GPG key ID: 210D9C873253A68C
7 changed files with 63 additions and 63 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/webui/api/searchcontroller.cpp
View file

@ -63,7 +63,7 @@ namespace
void SearchController::startAction()
{
checkParams({"pattern", "category", "plugins"});
requireParams({"pattern", "category", "plugins"});
if (!Utils::ForeignApps::pythonInfo().isValid())
throw APIError(APIErrorType::Conflict, "Python must be installed to use the Search Engine.");
@ -109,7 +109,7 @@ void SearchController::startAction()
void SearchController::stopAction()
{
checkParams({"id"});
requireParams({"id"});
const int id = params()["id"].toInt();
ISession *const session = sessionManager()->session();
@ -151,7 +151,7 @@ void SearchController::statusAction()
void SearchController::resultsAction()
{
checkParams({"id"});
requireParams({"id"});
const int id = params()["id"].toInt();
int limit = params()["limit"].toInt();
@ -184,7 +184,7 @@ void SearchController::resultsAction()
void SearchController::deleteAction()
{
checkParams({"id"});
requireParams({"id"});
const int id = params()["id"].toInt();
ISession *const session = sessionManager()->session();
@ -222,7 +222,7 @@ void SearchController::pluginsAction()
void SearchController::installPluginAction()
{
checkParams({"sources"});
requireParams({"sources"});
const QStringList sources = params()["sources"].split('|');
for (const QString &source : sources)
@ -231,7 +231,7 @@ void SearchController::installPluginAction()
void SearchController::uninstallPluginAction()
{
checkParams({"names"});
requireParams({"names"});
const QStringList names = params()["names"].split('|');
for (const QString &name : names)
@ -240,7 +240,7 @@ void SearchController::uninstallPluginAction()
void SearchController::enablePluginAction()
{
checkParams({"names", "enable"});
requireParams({"names", "enable"});
const QStringList names = params()["names"].split('|');
const bool enable = Utils::String::parseBool(params()["enable"].trimmed(), false);