github/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent synced 2025-07-13 16:53:08 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Rely on Qt ownership to free resources

Browse source 
The m_reply has already changed parent in
DownloadHandlerImpl::assignNetworkReply() and thus we can rely on Qt
ownership to delete the object.
This commit is contained in:
Chocobo1 2020-03-25 11:56:07 +08:00
parent fbf325c6d6
commit 9630e7b689
No known key found for this signature in database
GPG key ID: 210D9C873253A68C
2 changed files with 1 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/base/net/private/downloadhandlerimpl.cpp
View file

@ -64,11 +64,6 @@ DownloadHandlerImpl::DownloadHandlerImpl(Net::DownloadManager *manager, const Ne
m_result.status = Net::DownloadStatus::Success; m_result.status = Net::DownloadStatus::Success;
} }
DownloadHandlerImpl::~DownloadHandlerImpl()
{
delete m_reply;
}
void DownloadHandlerImpl::cancel() void DownloadHandlerImpl::cancel()
{ {
if (m_reply) { if (m_reply) {
@ -83,6 +78,7 @@ void DownloadHandlerImpl::cancel()
void DownloadHandlerImpl::assignNetworkReply(QNetworkReply *reply) void DownloadHandlerImpl::assignNetworkReply(QNetworkReply *reply)
{ {
Q_ASSERT(reply); Q_ASSERT(reply);
Q_ASSERT(!m_reply);
m_reply = reply; m_reply = reply;
m_reply->setParent(this); m_reply->setParent(this);

1
src/base/net/private/downloadhandlerimpl.h
View file

@ -43,7 +43,6 @@ class DownloadHandlerImpl : public Net::DownloadHandler
public: public:
DownloadHandlerImpl(Net::DownloadManager *manager, const Net::DownloadRequest &downloadRequest); DownloadHandlerImpl(Net::DownloadManager *manager, const Net::DownloadRequest &downloadRequest);
~DownloadHandlerImpl() override;
void cancel() override; void cancel() override;