github/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent synced 2025-08-20 13:23:34 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

WebUI: use secure random number generator for generating random port

Browse source 
Cryptographically strong random number generators are generally preferred over others.

PR #23049.
This commit is contained in:
Chocobo1 2025-08-03 15:09:39 +08:00 • committed by GitHub
commit 94552b2384
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/webui/www/private/views/preferences.html
View file

@ -2127,9 +2127,11 @@ Use ';' to split multiple entries. Can use wildcard '*'.)QBT_TR[CONTEXT=OptionsD
};
const generateRandomPort = () => {
const min = 1024;
const max = 65535;
const port = Math.floor(Math.random() * (max - min + 1) + min);
// don't use modulo operations to avoid 'modulo bias'
const buffer = new Uint16Array(1);
let port = crypto.getRandomValues(buffer)[0];
while (port < 1024)
port = crypto.getRandomValues(buffer)[0];
document.getElementById("portValue").value = port;
};