github/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent synced 2025-07-31 12:00:16 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Switch to string view where applicable

Browse source 
PR #22438.
This commit is contained in:
Chocobo1 2025-03-17 19:28:38 +08:00 • committed by GitHub
parent 5a4b3b25d3
commit 8d0870c953
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 24 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/webui/webapplication.cpp
View file

@ -237,15 +237,15 @@ void WebApplication::translateDocument(QString &data) const
i = data.indexOf(regex, i, &regexMatch);
if (i >= 0)
{
const QString sourceText = regexMatch.captured(1);
const QString context = regexMatch.captured(3);
const QStringView sourceText = regexMatch.capturedView(1);
const QStringView context = regexMatch.capturedView(3);
const QString loadedText = m_translationFileLoaded
? m_translator.translate(context.toUtf8().constData(), sourceText.toUtf8().constData())
: QString();
// `loadedText` is empty when translation is not provided
// it should fallback to `sourceText`
QString translation = loadedText.isEmpty() ? sourceText : loadedText;
QString translation = loadedText.isEmpty() ? sourceText.toString() : loadedText;
// Escape quotes to workaround issues with HTML attributes
// FIXME: this is a dirty workaround to deal with broken translation strings: