github/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent synced 2025-08-19 12:59:56 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Merge pull request #6076 from evsh/warn-if-no-function-names

Browse source 
Warn if no function names are present in the stacktrace
This commit is contained in:
sledgehammer999 2017-01-19 00:33:12 +02:00 • committed by GitHub
commit 7c75ee20e3
1 changed files with 60 additions and 52 deletions
Download patch file Download diff file Expand all files Collapse all files

30
src/app/stacktrace.h
View file

@ -33,30 +33,30 @@ static inline void print_stacktrace(FILE *out = stderr, unsigned int max_frames
size_t funcnamesize = 256; size_t funcnamesize = 256;
char *funcname = (char *)malloc(funcnamesize); char *funcname = (char *)malloc(funcnamesize);
int functionNamesFound = 0;
// iterate over the returned symbol lines. skip the first, it is the // iterate over the returned symbol lines. skip the first, it is the
// address of this function. // address of this function.
for (int i = 2; i < addrlen; i++) for (int i = 2; i < addrlen; i++) {
{
char *begin_name = 0, *begin_offset = 0, *end_offset = 0; char *begin_name = 0, *begin_offset = 0, *end_offset = 0;
// find parentheses and +address offset surrounding the mangled name: // find parentheses and +address offset surrounding the mangled name:
// ./module(function+0x15c) [0x8048a6d] // ./module(function+0x15c) [0x8048a6d]
// fprintf(out, "%s TT\n", symbollist[i]); // fprintf(out, "%s TT\n", symbollist[i]);
for (char *p = symbollist[i]; *p; ++p) for (char *p = symbollist[i]; *p; ++p) {
{ if (*p == '(') {
if (*p == '(')
begin_name = p; begin_name = p;
else if (*p == '+') }
else if (*p == '+') {
begin_offset = p; begin_offset = p;
else if (*p == ')' && begin_offset) { }
else if ((*p == ')') && begin_offset) {
end_offset = p; end_offset = p;
break; break;
} }
} }
if (begin_name && begin_offset && end_offset if (begin_name && begin_offset && end_offset
&& begin_name < begin_offset) && (begin_name < begin_offset)) {
{
*begin_name++ = '\0'; *begin_name++ = '\0';
*begin_offset++ = '\0'; *begin_offset++ = '\0';
*end_offset = '\0'; *end_offset = '\0';
@ -79,14 +79,22 @@ static inline void print_stacktrace(FILE *out = stderr, unsigned int max_frames
fprintf(out, " %s : %s()+%s %s\n", fprintf(out, " %s : %s()+%s %s\n",
symbollist[i], begin_name, begin_offset, ++end_offset); symbollist[i], begin_name, begin_offset, ++end_offset);
} }
++functionNamesFound;
} }
else else {
{
// couldn't parse the line? print the whole line. // couldn't parse the line? print the whole line.
fprintf(out, " %s\n", symbollist[i]); fprintf(out, " %s\n", symbollist[i]);
} }
} }
if (!functionNamesFound) {
fprintf(out, "There were no function names found in the stack trace\n."
"Seems like debug symbols are not installed, and the stack trace is useless.\n");
}
if (functionNamesFound < addrlen - 2) {
fprintf(out, "Consider installing debug symbols for packages containing files with empty"
" function names (i.e. empty braces \"()\") to make your stack trace more useful\n");
}
free(funcname); free(funcname);
free(symbollist); free(symbollist);
} }