github/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent synced 2025-08-20 13:23:34 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Avoid repetitive function calls

Browse source 
PR #20764.
This commit is contained in:
Chocobo1 2024-04-29 13:05:05 +08:00 • committed by GitHub
commit 775b38079f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 12 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

20
src/base/torrentfilter.cpp
View file

@ -156,10 +156,11 @@ bool TorrentFilter::match(const Torrent *const torrent) const
bool TorrentFilter::matchState(const BitTorrent::Torrent *const torrent) const bool TorrentFilter::matchState(const BitTorrent::Torrent *const torrent) const
{ {
const BitTorrent::TorrentState state = torrent->state();
switch (m_type) switch (m_type)
{ {
case All: case All:
default:
return true; return true;
case Downloading: case Downloading:
return torrent->isDownloading(); return torrent->isDownloading();
@ -176,20 +177,23 @@ bool TorrentFilter::matchState(const BitTorrent::Torrent *const torrent) const
case Inactive: case Inactive:
return torrent->isInactive(); return torrent->isInactive();
case Stalled: case Stalled:
return (torrent->state() == BitTorrent::TorrentState::StalledUploading) return (state == BitTorrent::TorrentState::StalledUploading)
|| (torrent->state() == BitTorrent::TorrentState::StalledDownloading); || (state == BitTorrent::TorrentState::StalledDownloading);
case StalledUploading: case StalledUploading:
return torrent->state() == BitTorrent::TorrentState::StalledUploading; return state == BitTorrent::TorrentState::StalledUploading;
case StalledDownloading: case StalledDownloading:
return torrent->state() == BitTorrent::TorrentState::StalledDownloading; return state == BitTorrent::TorrentState::StalledDownloading;
case Checking: case Checking:
return (torrent->state() == BitTorrent::TorrentState::CheckingUploading) return (state == BitTorrent::TorrentState::CheckingUploading)
|| (torrent->state() == BitTorrent::TorrentState::CheckingDownloading) || (state == BitTorrent::TorrentState::CheckingDownloading)
|| (torrent->state() == BitTorrent::TorrentState::CheckingResumeData); || (state == BitTorrent::TorrentState::CheckingResumeData);
case Moving: case Moving:
return torrent->isMoving(); return torrent->isMoving();
case Errored: case Errored:
return torrent->isErrored(); return torrent->isErrored();
default:
Q_ASSERT(false);
return false;
} }
} }