github/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent synced 2025-08-20 13:23:34 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Merge pull request #15444 from Chocobo1/guard

Browse source 
Prevent self-assignment in assignment operator
This commit is contained in:
Chocobo1 2021-09-12 12:56:17 +08:00 • committed by GitHub
commit 6de0622c1a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/base/bittorrent/torrentinfo.cpp
View file

@ -87,8 +87,11 @@ TorrentInfo::TorrentInfo(const TorrentInfo &other)
}
TorrentInfo &TorrentInfo::operator=(const TorrentInfo &other)
{
if (this != &other)
{
m_nativeInfo = other.m_nativeInfo;
}
return *this;
}

3
src/base/rss/rss_autodownloadrule.cpp
View file

@ -439,8 +439,11 @@ bool AutoDownloadRule::accepts(const QVariantHash &articleData)
}
AutoDownloadRule &AutoDownloadRule::operator=(const AutoDownloadRule &other)
{
if (this != &other)
{
m_dataPtr = other.m_dataPtr;
}
return *this;
}

4
src/gui/raisedmessagebox.h
View file

@ -33,6 +33,7 @@
class RaisedMessageBox final : public QMessageBox
{
Q_OBJECT
Q_DISABLE_COPY_MOVE(RaisedMessageBox)
public:
static QMessageBox::StandardButton critical(QWidget *parent, const QString &title, const QString &text, QMessageBox::StandardButtons buttons = QMessageBox::Ok, QMessageBox::StandardButton defaultButton = QMessageBox::NoButton);
@ -45,9 +46,6 @@ protected:
private:
RaisedMessageBox(QMessageBox::Icon icon, const QString &title, const QString &text, QMessageBox::StandardButtons buttons = NoButton, QWidget *parent = nullptr, Qt::WindowFlags f = Qt::Dialog|Qt::MSWindowsFixedSizeDialogHint);
RaisedMessageBox();
RaisedMessageBox(RaisedMessageBox const&);
void operator=(RaisedMessageBox const&);
static QMessageBox::StandardButton impl(const QMessageBox::Icon &icon, QWidget *parent, const QString &title, const QString &text, QMessageBox::StandardButtons buttons = QMessageBox::Ok, QMessageBox::StandardButton defaultButton = QMessageBox::NoButton);
};