From 69af2050946835539c13521e87bea89aff290370 Mon Sep 17 00:00:00 2001 From: Thomas Piccirello Date: Sat, 6 Jan 2018 21:04:03 -0500 Subject: [PATCH] Use .each(). Refactor conditionals. --- src/webui/www/private/scripts/dynamicTable.js | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/webui/www/private/scripts/dynamicTable.js b/src/webui/www/private/scripts/dynamicTable.js index b9589971e..b7e1e79a4 100644 --- a/src/webui/www/private/scripts/dynamicTable.js +++ b/src/webui/www/private/scripts/dynamicTable.js @@ -489,19 +489,14 @@ var DynamicTable = new Class({ }, selectRow : function (rowId) { - this.selectedRows.empty(); + this.deselectAll(); this.selectedRows.push(rowId); - var trs = this.tableBody.getElements('tr'); - for (var i = 0; i < trs.length; i++) { - var tr = trs[i]; - if (tr.rowId == rowId) { - if (!tr.hasClass('selected')) - tr.addClass('selected'); - } + this.tableBody.getElements('tr').each(function(tr) { + if (tr.rowId == rowId) + tr.addClass('selected'); else - if (tr.hasClass('selected')) tr.removeClass('selected'); - } + }); this.onSelectedRowChanged(); },