github/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent synced 2025-08-19 21:03:30 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Remove redundant null checks

Browse source 
Attempting to delete a null pointer is a noop in C++.

Closes #2864.

[1] https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null
This commit is contained in:
NotTsunami 2020-02-03 16:38:46 -05:00
commit 6748e8d787
14 changed files with 37 additions and 72 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/base/bittorrent/session.cpp
View file

@ -977,8 +977,7 @@ Session::~Session()
// We must delete FilterParserThread
// before we delete lt::session
if (m_filterParser)
delete m_filterParser;
delete m_filterParser;
// We must delete PortForwarderImpl before
// we delete lt::session
@ -1002,10 +1001,8 @@ void Session::initInstance()
void Session::freeInstance()
{
if (m_instance) {
delete m_instance;
m_instance = nullptr;
}
delete m_instance;
m_instance = nullptr;
}
Session *Session::instance()
@ -1605,8 +1602,7 @@ void Session::enableTracker(const bool enable)
m_tracker->start();
}
else {
if (m_tracker)
delete m_tracker;
delete m_tracker;
}
}