diff --git a/cmake/Modules/winconf.cmake b/cmake/Modules/winconf.cmake index 7dc7907bd..6976657f8 100644 --- a/cmake/Modules/winconf.cmake +++ b/cmake/Modules/winconf.cmake @@ -24,6 +24,7 @@ add_definitions(-DUNICODE -D_WIN32_IE=0x0501 -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_DEPRECATE + -DNOMINMAX ) # and boost set(Boost_USE_STATIC_LIBS True) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 3137057ca..fc08356ce 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -40,11 +40,8 @@ include_directories(${CMAKE_CURRENT_SOURCE_DIR}) # defines add_definitions(-DQT_NO_CAST_TO_ASCII) -# Fast concatenation (Qt >= 4.6) -add_definitions(-DQT_USE_FAST_CONCATENATION -DQT_USE_FAST_OPERATOR_PLUS) -if (WIN32) - add_definitions(-DNOMINMAX) -endif (WIN32) +# Efficient construction for QString & QByteArray (Qt >= 4.8) +add_definitions(-DQT_USE_QSTRINGBUILDER) if (NOT GUI) add_definitions(-DDISABLE_GUI -DDISABLE_COUNTRIES_RESOLUTION) diff --git a/src/base/net/smtp.cpp b/src/base/net/smtp.cpp index fcc35b2e3..5a9f203cb 100644 --- a/src/base/net/smtp.cpp +++ b/src/base/net/smtp.cpp @@ -194,7 +194,7 @@ void Smtp::readyRead() ehlo(); } else { - logError("Connection failed, unrecognized reply: " + line); + logError(QLatin1String("Connection failed, unrecognized reply: ") + line); m_state = Close; } break; @@ -231,7 +231,7 @@ void Smtp::readyRead() } else { // Authentication failed! - logError("Authentication failed, msg: " + line); + logError(QLatin1String("Authentication failed, msg: ") + line); m_state = Close; } break; @@ -242,7 +242,7 @@ void Smtp::readyRead() m_state = Data; } else { - logError(" was rejected by server, msg: " + line); + logError(QLatin1String(" was rejected by server, msg: ") + line); m_state = Close; } break; @@ -253,7 +253,7 @@ void Smtp::readyRead() m_state = Body; } else { - logError(" was rejected by server, msg: " + line); + logError(QLatin1String(" was rejected by server, msg: ") + line); m_state = Close; } break; @@ -264,7 +264,7 @@ void Smtp::readyRead() m_state = Quit; } else { - logError(" was rejected by server, msg: " + line); + logError(QLatin1String(" was rejected by server, msg: ") + line); m_state = Close; } break; @@ -276,7 +276,7 @@ void Smtp::readyRead() m_state = Close; } else { - logError("Message was rejected by the server, error: " + line); + logError(QLatin1String("Message was rejected by the server, error: ") + line); m_state = Close; } break; diff --git a/src/gui/about.qrc b/src/gui/about.qrc index da886b454..e6133f7ca 100644 --- a/src/gui/about.qrc +++ b/src/gui/about.qrc @@ -1,7 +1,7 @@ - - - gpl.html - thanks.html - translators.html - + + + gpl.html + thanks.html + translators.html + diff --git a/src/gui/properties/trackersadditiondlg.cpp b/src/gui/properties/trackersadditiondlg.cpp index cf98eea63..5a63f9fd7 100644 --- a/src/gui/properties/trackersadditiondlg.cpp +++ b/src/gui/properties/trackersadditiondlg.cpp @@ -105,7 +105,7 @@ void TrackersAdditionDlg::parseUTorrentList(const QString &, const QString &path m_ui->trackers_list->insertPlainText("\n"); int nb = 0; while (!list_file.atEnd()) { - const QByteArray line = list_file.readLine().trimmed(); + const QString line = list_file.readLine().trimmed(); if (line.isEmpty()) continue; BitTorrent::TrackerEntry newTracker(line); if (!existingTrackers.contains(newTracker)) { diff --git a/src/icons.qrc b/src/icons.qrc index b3247798f..257b9813a 100644 --- a/src/icons.qrc +++ b/src/icons.qrc @@ -1,14 +1,6 @@ - icons/qbittorrent.png icons/3-state-checkbox.gif - icons/L.gif - icons/loading.png - icons/slow.png - icons/slow_off.png - icons/sphere.png - icons/sphere2.png - icons/url.png icons/flags/ad.png icons/flags/ae.png icons/flags/af.png @@ -250,9 +242,13 @@ icons/flags/za.png icons/flags/zm.png icons/flags/zw.png + icons/L.gif + icons/loading.png + icons/qbittorrent.png icons/qbt-theme/application-exit.png icons/qbt-theme/application-rss+xml.png icons/qbt-theme/application-x-mswinurl.png + icons/qbt-theme/checked.png icons/qbt-theme/configure.png icons/qbt-theme/dialog-cancel.png icons/qbt-theme/dialog-information.png @@ -280,7 +276,9 @@ icons/qbt-theme/folder-remote.png icons/qbt-theme/gear.png icons/qbt-theme/gear32.png + icons/qbt-theme/go-bottom.png icons/qbt-theme/go-down.png + icons/qbt-theme/go-top.png icons/qbt-theme/go-up.png icons/qbt-theme/help-about.png icons/qbt-theme/help-contents.png @@ -299,14 +297,17 @@ icons/qbt-theme/network-server.png icons/qbt-theme/network-wired.png icons/qbt-theme/object-locked.png + icons/qbt-theme/office-chart-line.png icons/qbt-theme/preferences-desktop.png icons/qbt-theme/preferences-other.png icons/qbt-theme/preferences-system-network.png icons/qbt-theme/preferences-web-browser-cookies.png + icons/qbt-theme/rss-config.png icons/qbt-theme/security-high.png icons/qbt-theme/security-low.png icons/qbt-theme/services.png icons/qbt-theme/speedometer.png + icons/qbt-theme/system-log-out.png icons/qbt-theme/tab-close.png icons/qbt-theme/task-attention.png icons/qbt-theme/task-complete.png @@ -332,6 +333,7 @@ icons/skin/bg-panel-header.gif icons/skin/checking.png icons/skin/collapse-expand.gif + icons/skin/completed.png icons/skin/connected.png icons/skin/disconnected.png icons/skin/dock-tabs.gif @@ -350,13 +352,14 @@ icons/skin/logo2.gif icons/skin/mascot.png icons/skin/paused.png + icons/skin/qbittorrent-tray-dark.svg + icons/skin/qbittorrent-tray-light.svg icons/skin/qbittorrent16.png icons/skin/qbittorrent22.png icons/skin/qbittorrent32.png - icons/skin/qbittorrent-tray-dark.svg - icons/skin/qbittorrent-tray-light.svg icons/skin/queued.png icons/skin/ratio.png + icons/skin/resumed.png icons/skin/seeding.png icons/skin/slider-area.gif icons/skin/spacer.gif @@ -368,14 +371,11 @@ icons/skin/tabs.gif icons/skin/toolbox-divider.gif icons/skin/toolbox-divider2.gif - icons/skin/resumed.png icons/skin/uploading.png - icons/skin/completed.png - icons/qbt-theme/system-log-out.png - icons/qbt-theme/go-bottom.png - icons/qbt-theme/go-top.png - icons/qbt-theme/checked.png - icons/qbt-theme/office-chart-line.png - icons/qbt-theme/rss-config.png + icons/slow.png + icons/slow_off.png + icons/sphere.png + icons/sphere2.png + icons/url.png diff --git a/src/lang.qrc b/src/lang.qrc index 60002a62a..611602950 100644 --- a/src/lang.qrc +++ b/src/lang.qrc @@ -1,54 +1,54 @@ - - - lang/qbittorrent_ar.qm - lang/qbittorrent_be.qm - lang/qbittorrent_bg.qm - lang/qbittorrent_ca.qm - lang/qbittorrent_cs.qm - lang/qbittorrent_da.qm - lang/qbittorrent_de.qm - lang/qbittorrent_el.qm - lang/qbittorrent_en.qm - lang/qbittorrent_en_AU.qm - lang/qbittorrent_en_GB.qm - lang/qbittorrent_es.qm - lang/qbittorrent_eo.qm - lang/qbittorrent_eu.qm - lang/qbittorrent_fi.qm - lang/qbittorrent_fr.qm - lang/qbittorrent_gl.qm - lang/qbittorrent_he.qm - lang/qbittorrent_hi_IN.qm - lang/qbittorrent_hr.qm - lang/qbittorrent_hu.qm - lang/qbittorrent_hy.qm - lang/qbittorrent_id.qm - lang/qbittorrent_is.qm - lang/qbittorrent_it.qm - lang/qbittorrent_ja.qm - lang/qbittorrent_ka.qm - lang/qbittorrent_ko.qm - lang/qbittorrent_lv_LV.qm - lang/qbittorrent_lt.qm - lang/qbittorrent_ms_MY.qm - lang/qbittorrent_nb.qm - lang/qbittorrent_nl.qm - lang/qbittorrent_oc.qm - lang/qbittorrent_pl.qm - lang/qbittorrent_pt_PT.qm - lang/qbittorrent_pt_BR.qm - lang/qbittorrent_ro.qm - lang/qbittorrent_ru.qm - lang/qbittorrent_sk.qm - lang/qbittorrent_sl.qm - lang/qbittorrent_sr.qm - lang/qbittorrent_sv.qm - lang/qbittorrent_tr.qm - lang/qbittorrent_uk.qm - lang/qbittorrent_uz@Latn.qm - lang/qbittorrent_vi.qm - lang/qbittorrent_zh.qm - lang/qbittorrent_zh_TW.qm - lang/qbittorrent_zh_HK.qm - + + + lang/qbittorrent_ar.qm + lang/qbittorrent_be.qm + lang/qbittorrent_bg.qm + lang/qbittorrent_ca.qm + lang/qbittorrent_cs.qm + lang/qbittorrent_da.qm + lang/qbittorrent_de.qm + lang/qbittorrent_el.qm + lang/qbittorrent_en.qm + lang/qbittorrent_en_AU.qm + lang/qbittorrent_en_GB.qm + lang/qbittorrent_eo.qm + lang/qbittorrent_es.qm + lang/qbittorrent_eu.qm + lang/qbittorrent_fi.qm + lang/qbittorrent_fr.qm + lang/qbittorrent_gl.qm + lang/qbittorrent_he.qm + lang/qbittorrent_hi_IN.qm + lang/qbittorrent_hr.qm + lang/qbittorrent_hu.qm + lang/qbittorrent_hy.qm + lang/qbittorrent_id.qm + lang/qbittorrent_is.qm + lang/qbittorrent_it.qm + lang/qbittorrent_ja.qm + lang/qbittorrent_ka.qm + lang/qbittorrent_ko.qm + lang/qbittorrent_lt.qm + lang/qbittorrent_lv_LV.qm + lang/qbittorrent_ms_MY.qm + lang/qbittorrent_nb.qm + lang/qbittorrent_nl.qm + lang/qbittorrent_oc.qm + lang/qbittorrent_pl.qm + lang/qbittorrent_pt_BR.qm + lang/qbittorrent_pt_PT.qm + lang/qbittorrent_ro.qm + lang/qbittorrent_ru.qm + lang/qbittorrent_sk.qm + lang/qbittorrent_sl.qm + lang/qbittorrent_sr.qm + lang/qbittorrent_sv.qm + lang/qbittorrent_tr.qm + lang/qbittorrent_uk.qm + lang/qbittorrent_uz@Latn.qm + lang/qbittorrent_vi.qm + lang/qbittorrent_zh.qm + lang/qbittorrent_zh_HK.qm + lang/qbittorrent_zh_TW.qm + diff --git a/src/searchengine.qrc b/src/searchengine.qrc index 35dea1b8a..0a91aac8c 100644 --- a/src/searchengine.qrc +++ b/src/searchengine.qrc @@ -1,16 +1,16 @@ - searchengine/nova/fix_encoding.py - searchengine/nova/helpers.py - searchengine/nova/nova2.py - searchengine/nova/novaprinter.py - searchengine/nova/socks.py searchengine/nova3/helpers.py searchengine/nova3/nova2.py + searchengine/nova3/nova2dl.py searchengine/nova3/novaprinter.py searchengine/nova3/sgmllib3.py searchengine/nova3/socks.py + searchengine/nova/fix_encoding.py + searchengine/nova/helpers.py + searchengine/nova/nova2.py searchengine/nova/nova2dl.py - searchengine/nova3/nova2dl.py + searchengine/nova/novaprinter.py + searchengine/nova/socks.py diff --git a/src/src.pro b/src/src.pro index c3b2c0ec9..081e6e825 100644 --- a/src/src.pro +++ b/src/src.pro @@ -6,26 +6,22 @@ CONFIG += qt thread silent CONFIG += c++11 DEFINES += BOOST_NO_CXX11_RVALUE_REFERENCES -# Windows specific configuration +# Platform specific configuration win32: include(../winconf.pri) - -# Mac specific configuration macx: include(../macxconf.pri) - -# Unix specific configuration unix:!macx: include(../unixconf.pri) - -# eCS(OS/2) specific configuration os2: include(../os2conf.pri) +QT += network xml + nogui { + TARGET = qbittorrent-nox QT -= gui DEFINES += DISABLE_GUI - TARGET = qbittorrent-nox } else { - macx: QT += macextras - macx: LIBS += -lobjc + TARGET = qbittorrent QT += xml concurrent svg widgets + CONFIG(static) { DEFINES += QBT_STATIC_QT QTPLUGIN += qico @@ -33,16 +29,19 @@ nogui { win32 { QT += winextras } - TARGET = qbittorrent + macx { + QT += macextras + LIBS += -lobjc + } +} +nowebui { + DEFINES += DISABLE_WEBUI } -nowebui: DEFINES += DISABLE_WEBUI strace_win { DEFINES += STACKTRACE_WIN DEFINES += STACKTRACE_WIN_PROJECT_PATH=$$PWD DEFINES += STACKTRACE_WIN_MAKEFILE_PATH=$$OUT_PWD } -QT += network xml - CONFIG(debug, debug|release): message(Project is built in DEBUG mode.) CONFIG(release, debug|release): message(Project is built in RELEASE mode.) @@ -57,10 +56,8 @@ CONFIG(release, debug|release) { include(../version.pri) DEFINES += QT_NO_CAST_TO_ASCII -# Fast concatenation (Qt >= 4.6) -DEFINES += QT_USE_FAST_CONCATENATION QT_USE_FAST_OPERATOR_PLUS - -win32: DEFINES += NOMINMAX +# Efficient construction for QString & QByteArray (Qt >= 4.8) +DEFINES += QT_USE_QSTRINGBUILDER INCLUDEPATH += $$PWD diff --git a/src/webui/webui.qrc b/src/webui/webui.qrc index 7af7dafef..c1e481195 100644 --- a/src/webui/webui.qrc +++ b/src/webui/webui.qrc @@ -2,12 +2,24 @@ www/private/index.html www/private/login.html + www/public/about.html + www/public/addtrackers.html + www/public/confirmdeletion.html www/public/css/Core.css www/public/css/dynamicTable.css www/public/css/Layout.css www/public/css/style.css www/public/css/Tabs.css www/public/css/Window.css + www/public/download.html + www/public/downloadlimit.html + www/public/filters.html + www/public/newcategory.html + www/public/preferences.html + www/public/preferences_content.html + www/public/properties.html + www/public/properties_content.html + www/public/rename.html www/public/scripts/client.js www/public/scripts/clipboard.min.js www/public/scripts/contextmenu.js @@ -15,33 +27,21 @@ www/public/scripts/dynamicTable.js www/public/scripts/excanvas-compressed.js www/public/scripts/misc.js - www/public/scripts/mocha.js www/public/scripts/mocha-init.js www/public/scripts/mocha-yc.js + www/public/scripts/mocha.js www/public/scripts/mootools-1.2-core-yc.js www/public/scripts/mootools-1.2-more.js www/public/scripts/parametrics.js www/public/scripts/progressbar.js - www/public/about.html - www/public/addtrackers.html - www/public/confirmdeletion.html - www/public/download.html - www/public/downloadlimit.html - www/public/filters.html - www/public/preferences.html - www/public/preferences_content.html - www/public/properties.html - www/public/properties_content.html + www/public/scripts/prop-files.js www/public/scripts/prop-general.js www/public/scripts/prop-trackers.js www/public/scripts/prop-webseeds.js - www/public/scripts/prop-files.js + www/public/setlocation.html www/public/statistics.html www/public/transferlist.html www/public/upload.html www/public/uploadlimit.html - www/public/newcategory.html - www/public/setlocation.html - www/public/rename.html diff --git a/winconf.pri b/winconf.pri index ca36e0a92..dcec302ca 100644 --- a/winconf.pri +++ b/winconf.pri @@ -49,6 +49,7 @@ DEFINES += _CRT_SECURE_NO_DEPRECATE DEFINES += _SCL_SECURE_NO_DEPRECATE DEFINES += __USE_W32_SOCKETS DEFINES += _FILE_OFFSET_BITS=64 +DEFINES += NOMINMAX CONFIG(debug, debug|release) { DEFINES += TORRENT_DEBUG