github/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent synced 2025-07-30 03:28:41 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Unify singleton pattern in Profile class

Browse source 
1. Use unified function names `initInstance()` and `freeInstance()` and
make them public.
2. Add `freeInstance()` to avoid noise from memory leak detectors.
3. Let `instance()`return a pointer directly to avoid unnecessary
indirections when invoking functions.
This commit is contained in:
Chocobo1 2020-02-11 10:56:04 +08:00
parent 8b330e3ac0
commit 5de75eff05
No known key found for this signature in database
GPG key ID: 210D9C873253A68C
9 changed files with 39 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/base/rss/rss_autodownloader.cpp
View file

@ -435,7 +435,7 @@ void AutoDownloader::loadRules(const QByteArray &data)
void AutoDownloader::loadRulesLegacy()
{
const SettingsPtr settings = Profile::instance().applicationSettings(QStringLiteral("qBittorrent-rss"));
const SettingsPtr settings = Profile::instance()->applicationSettings(QStringLiteral("qBittorrent-rss"));
const QVariantHash rules = settings->value(QStringLiteral("download_rules")).toHash();
for (const QVariant &ruleVar : rules) {
const auto rule = AutoDownloadRule::fromLegacyDict(ruleVar.toHash());