github/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent synced 2025-07-16 02:03:07 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Avoid binding constant reference to returned object

Browse source 
In such cases, it makes no sense doing so.
This commit is contained in:
Chocobo1 2018-07-21 15:07:11 +08:00
parent 5d4da09093
commit 56766dc08b
No known key found for this signature in database
GPG key ID: 210D9C873253A68C
6 changed files with 13 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/gui/addnewtorrentdialog.cpp
View file

@ -551,7 +551,7 @@ void AddNewTorrentDialog::renameSelectedFile()
if (!newPath.endsWith('/')) newPath += '/';
// Check for overwriting
for (int i = 0; i < m_torrentInfo.filesCount(); ++i) {
const QString &currentName = m_torrentInfo.filePath(i);
const QString currentName = m_torrentInfo.filePath(i);
#if defined(Q_OS_UNIX) || defined(Q_WS_QWS)
if (currentName.startsWith(newPath, Qt::CaseSensitive)) {
#else
@ -565,7 +565,7 @@ void AddNewTorrentDialog::renameSelectedFile()
}
// Replace path in all files
for (int i = 0; i < m_torrentInfo.filesCount(); ++i) {
const QString &currentName = m_torrentInfo.filePath(i);
const QString currentName = m_torrentInfo.filePath(i);
if (currentName.startsWith(oldPath)) {
QString newName = currentName;
newName.replace(0, oldPath.length(), newPath);