From 559f47ab0c93a5a30739e2d35a8999cf3fd77728 Mon Sep 17 00:00:00 2001 From: Chocobo1 Date: Wed, 23 Apr 2025 07:11:37 +0800 Subject: [PATCH] WebUI: avoid double lookup --- src/webui/www/private/scripts/file-tree.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/webui/www/private/scripts/file-tree.js b/src/webui/www/private/scripts/file-tree.js index b7fdf93b2..c56ddeaef 100644 --- a/src/webui/www/private/scripts/file-tree.js +++ b/src/webui/www/private/scripts/file-tree.js @@ -58,7 +58,7 @@ window.qBittorrent.FileTree ??= (() => { class FileTree { #root = null; - #nodeMap = {}; + #nodeMap = {}; // Object with Number as keys is faster than anything setRoot(root) { this.#root = root; @@ -86,9 +86,9 @@ window.qBittorrent.FileTree ??= (() => { } getNode(rowId) { - return (this.#nodeMap[rowId] === undefined) - ? null - : this.#nodeMap[rowId]; + // TODO: enforce caller sites to pass `rowId` as number and not string + const value = this.#nodeMap[Number(rowId)]; + return (value !== undefined) ? value : null; } getRowId(node) {