github/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent synced 2025-07-30 11:38:50 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Provide scaled pixmaps by UIThemeManager

Browse source 
Avoid leaking the paths of the theme resource files outside of the theme support implementation.

PR #18269.
This commit is contained in:
Vladimir Golovnev 2023-01-17 09:29:00 +03:00 • committed by GitHub
parent 43e059801e
commit 53cec6db09
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 33 additions and 55 deletions
Download patch file Download diff file Expand all files Collapse all files

42
src/gui/uithememanager.cpp
View file

@ -35,6 +35,7 @@
#include <QJsonDocument>
#include <QJsonObject>
#include <QPalette>
#include <QPixmapCache>
#include <QResource>
#include "base/global.h"
@ -237,6 +238,25 @@ QIcon UIThemeManager::getFlagIcon(const QString &countryIsoCode) const
return icon;
}
QPixmap UIThemeManager::getScaledPixmap(const QString &iconId, const int height) const
{
// (workaround) svg images require the use of `QIcon()` to load and scale losslessly,
// otherwise other image classes will convert it to pixmap first and follow-up scaling will become lossy.
Q_ASSERT(height > 0);
const QString cacheKey = iconId + u'@' + QString::number(height);
QPixmap pixmap;
if (!QPixmapCache::find(cacheKey, &pixmap))
{
pixmap = getIcon(iconId).pixmap(height);
QPixmapCache::insert(cacheKey, pixmap);
}
return pixmap;
}
QColor UIThemeManager::getColor(const QString &id, const QColor &defaultColor) const
{
return m_colors.value(id, defaultColor);
@ -272,28 +292,6 @@ QIcon UIThemeManager::getSystrayIcon() const
}
#endif
Path UIThemeManager::getIconPath(const QString &iconId) const
{
#if (defined(Q_OS_UNIX) && !defined(Q_OS_MACOS))
if (m_useSystemIcons)
{
Path path = Utils::Fs::tempPath() / Path(iconId + u".png");
if (!path.exists())
{
const QIcon icon = QIcon::fromTheme(iconId);
if (!icon.isNull())
icon.pixmap(32).save(path.toString());
else
path = getIconPathFromResources(iconId);
}
return path;
}
#endif
return getIconPathFromResources(iconId);
}
Path UIThemeManager::getIconPathFromResources(const QString &iconId) const
{
if (m_themeSource)