github/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent synced 2025-08-20 13:23:34 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

- foreach loop optimization

Browse source
This commit is contained in:
Christophe Dumez 2009-01-24 19:33:28 +00:00
commit 4bc043146d
1 changed files with 6 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/downloadingTorrents.cpp
View file

@ -182,9 +182,8 @@ void DownloadingTorrents::deleteTorrent(QString hash) {
void DownloadingTorrents::on_actionSet_download_limit_triggered() { void DownloadingTorrents::on_actionSet_download_limit_triggered() {
QModelIndexList selectedIndexes = downloadList->selectionModel()->selectedIndexes(); QModelIndexList selectedIndexes = downloadList->selectionModel()->selectedIndexes();
QModelIndex index;
QStringList hashes; QStringList hashes;
foreach(index, selectedIndexes) { foreach(const QModelIndex &index, selectedIndexes) {
if(index.column() == NAME) { if(index.column() == NAME) {
// Get the file hash // Get the file hash
hashes << DLListModel->data(DLListModel->index(index.row(), HASH)).toString(); hashes << DLListModel->data(DLListModel->index(index.row(), HASH)).toString();
@ -196,9 +195,8 @@ void DownloadingTorrents::on_actionSet_download_limit_triggered() {
void DownloadingTorrents::on_actionSet_upload_limit_triggered() { void DownloadingTorrents::on_actionSet_upload_limit_triggered() {
QModelIndexList selectedIndexes = downloadList->selectionModel()->selectedIndexes(); QModelIndexList selectedIndexes = downloadList->selectionModel()->selectedIndexes();
QModelIndex index;
QStringList hashes; QStringList hashes;
foreach(index, selectedIndexes) { foreach(const QModelIndex &index, selectedIndexes) {
if(index.column() == NAME) { if(index.column() == NAME) {
// Get the file hash // Get the file hash
hashes << DLListModel->data(DLListModel->index(index.row(), HASH)).toString(); hashes << DLListModel->data(DLListModel->index(index.row(), HASH)).toString();
@ -211,8 +209,7 @@ void DownloadingTorrents::on_actionSet_upload_limit_triggered() {
// display properties of selected items // display properties of selected items
void DownloadingTorrents::propertiesSelection(){ void DownloadingTorrents::propertiesSelection(){
QModelIndexList selectedIndexes = downloadList->selectionModel()->selectedIndexes(); QModelIndexList selectedIndexes = downloadList->selectionModel()->selectedIndexes();
QModelIndex index; foreach(const QModelIndex &index, selectedIndexes){
foreach(index, selectedIndexes){
if(index.column() == NAME){ if(index.column() == NAME){
showProperties(index); showProperties(index);
} }
@ -221,8 +218,7 @@ void DownloadingTorrents::propertiesSelection(){
void DownloadingTorrents::forceRecheck() { void DownloadingTorrents::forceRecheck() {
QModelIndexList selectedIndexes = downloadList->selectionModel()->selectedIndexes(); QModelIndexList selectedIndexes = downloadList->selectionModel()->selectedIndexes();
QModelIndex index; foreach(const QModelIndex &index, selectedIndexes){
foreach(index, selectedIndexes){
if(index.column() == NAME){ if(index.column() == NAME){
QString hash = DLListModel->data(DLListModel->index(index.row(), HASH)).toString(); QString hash = DLListModel->data(DLListModel->index(index.row(), HASH)).toString();
QTorrentHandle h = BTSession->getTorrentHandle(hash); QTorrentHandle h = BTSession->getTorrentHandle(hash);
@ -233,11 +229,10 @@ void DownloadingTorrents::forceRecheck() {
void DownloadingTorrents::displayDLListMenu(const QPoint& pos) { void DownloadingTorrents::displayDLListMenu(const QPoint& pos) {
QMenu myDLLlistMenu(this); QMenu myDLLlistMenu(this);
QModelIndex index;
// Enable/disable pause/start action given the DL state // Enable/disable pause/start action given the DL state
QModelIndexList selectedIndexes = downloadList->selectionModel()->selectedIndexes(); QModelIndexList selectedIndexes = downloadList->selectionModel()->selectedIndexes();
bool has_pause = false, has_start = false, has_preview = false; bool has_pause = false, has_start = false, has_preview = false;
foreach(index, selectedIndexes) { foreach(const QModelIndex &index, selectedIndexes) {
if(index.column() == NAME) { if(index.column() == NAME) {
// Get the file name // Get the file name
QString hash = DLListModel->data(DLListModel->index(index.row(), HASH)).toString(); QString hash = DLListModel->data(DLListModel->index(index.row(), HASH)).toString();
@ -462,9 +457,8 @@ QAction* DownloadingTorrents::getActionHoSCol(int index) {
QStringList DownloadingTorrents::getSelectedTorrents(bool only_one) const{ QStringList DownloadingTorrents::getSelectedTorrents(bool only_one) const{
QStringList res; QStringList res;
QModelIndex index;
QModelIndexList selectedIndexes = downloadList->selectionModel()->selectedIndexes(); QModelIndexList selectedIndexes = downloadList->selectionModel()->selectedIndexes();
foreach(index, selectedIndexes) { foreach(const QModelIndex &index, selectedIndexes) {
if(index.column() == NAME) { if(index.column() == NAME) {
// Get the file hash // Get the file hash
QString hash = DLListModel->data(DLListModel->index(index.row(), HASH)).toString(); QString hash = DLListModel->data(DLListModel->index(index.row(), HASH)).toString();