From 22835c0350b40b903c5fc1807b7ebc15bd9782e8 Mon Sep 17 00:00:00 2001 From: paolo-sz Date: Mon, 4 Mar 2019 21:16:05 +0100 Subject: [PATCH 1/2] Avoid crashes on torrent search qbittorrent closes itself without any error message when a search tab should be notified of a status change: fixed bad pointer variable catch in lambda code. --- src/gui/search/searchwidget.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gui/search/searchwidget.cpp b/src/gui/search/searchwidget.cpp index fec6cd1c1..632802c00 100644 --- a/src/gui/search/searchwidget.cpp +++ b/src/gui/search/searchwidget.cpp @@ -337,7 +337,7 @@ void SearchWidget::on_searchButton_clicked() m_ui->tabWidget->setCurrentWidget(newTab); connect(newTab, &SearchJobWidget::resultsCountUpdated, this, &SearchWidget::resultsCountUpdated); - connect(newTab, &SearchJobWidget::statusChanged, this, [this, &newTab]() { tabStatusChanged(newTab); }); + connect(newTab, &SearchJobWidget::statusChanged, this, [this, newTab]() { tabStatusChanged(newTab); }); m_ui->searchButton->setText(tr("Stop")); m_activeSearchTab = newTab; From 1ea7907e099dc05fed54e6441639ddbd66dc2b12 Mon Sep 17 00:00:00 2001 From: paolo-sz Date: Tue, 5 Mar 2019 20:26:59 +0100 Subject: [PATCH 2/2] Add default tooltip "Searching..." on tab creation. --- src/gui/search/searchjobwidget.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gui/search/searchjobwidget.cpp b/src/gui/search/searchjobwidget.cpp index fe391d5fc..3304a3873 100644 --- a/src/gui/search/searchjobwidget.cpp +++ b/src/gui/search/searchjobwidget.cpp @@ -163,6 +163,8 @@ SearchJobWidget::SearchJobWidget(SearchHandler *searchHandler, QWidget *parent) QShortcut *enterHotkey = new QShortcut(Qt::Key_Return, m_ui->resultsBrowser, nullptr, nullptr, Qt::WidgetShortcut); connect(enterHotkey, &QShortcut::activated, this, &SearchJobWidget::downloadTorrents); + + setStatusTip(statusText(m_status)); } SearchJobWidget::~SearchJobWidget()