From 3fb4e4d29314609a3e3f2fd18d9141f3ae86e3dd Mon Sep 17 00:00:00 2001 From: Chocobo1 Date: Thu, 25 May 2023 13:08:53 +0800 Subject: [PATCH] GHA CI: build libtorrent as a static library Since appimage is bundling the libraries it make sense to embed libtorrent statically into qbt binary. Another side effect is now qbt binary includes debug symbols from libtorrent too (which I consider a good thing for debugging). Previously appimage seems to (unnecessarily) strip the libtorrent debug symbols. PR #19014. --- .github/workflows/ci_ubuntu.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci_ubuntu.yaml b/.github/workflows/ci_ubuntu.yaml index ae7676651..fcb7a58ce 100644 --- a/.github/workflows/ci_ubuntu.yaml +++ b/.github/workflows/ci_ubuntu.yaml @@ -60,6 +60,7 @@ jobs: cmake \ -B build \ -G "Ninja" \ + -DBUILD_SHARED_LIBS=OFF \ -DCMAKE_BUILD_TYPE=RelWithDebInfo \ -DCMAKE_EXPORT_COMPILE_COMMANDS=ON \ -Ddeprecated-functions=OFF