github/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent synced 2025-08-19 21:03:30 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

refact: Move unconditional logic outside of if.

Browse source
This commit is contained in:
Stiliyan Tonev (Bark) 2025-05-20 11:26:03 +03:00
commit 3d59cb9199
1 changed files with 28 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

50
src/webui/api/torrentscontroller.cpp
View file

@ -1120,6 +1120,19 @@ void TorrentsController::addTrackersAction()
QList<BitTorrent::Torrent *> torrents; QList<BitTorrent::Torrent *> torrents;
const QList<BitTorrent::TrackerEntry> entries = BitTorrent::parseTrackerEntries(params()[u"urls"_s]); const QList<BitTorrent::TrackerEntry> entries = BitTorrent::parseTrackerEntries(params()[u"urls"_s]);
const QStringList idStrings = hashParam.split(u'|', Qt::SkipEmptyParts);
for (const QString &hash : idStrings)
{
if (hash == u"*"_s)
continue;
const auto id = BitTorrent::TorrentID::fromString(hash);
BitTorrent::Torrent *const torrent = BitTorrent::Session::instance()->getTorrent(id);
if (!torrent)
throw APIError(APIErrorType::NotFound);
torrents.append(torrent);
}
if (hashParam == u"*"_s) if (hashParam == u"*"_s)
{ {
// add this tracker to all torrents // add this tracker to all torrents
@ -1127,17 +1140,7 @@ void TorrentsController::addTrackersAction()
} }
else if (hashParam.contains(u'|')) else if (hashParam.contains(u'|'))
{ {
// add this tracker to all torrents in the list // We have this, so that we wont enter the `else` and break it.
const QStringList idStrings = hashParam.split(u'|', Qt::SkipEmptyParts);
for (const QString &hash : idStrings)
{
const auto id = BitTorrent::TorrentID::fromString(hash);
BitTorrent::Torrent *const torrent = BitTorrent::Session::instance()->getTorrent(id);
if (!torrent)
throw APIError(APIErrorType::NotFound);
torrents.append(torrent);
}
} }
else else
{ {
@ -1223,6 +1226,19 @@ void TorrentsController::removeTrackersAction()
QList<BitTorrent::Torrent *> torrents; QList<BitTorrent::Torrent *> torrents;
const QStringList idStrings = hashParam.split(u'|', Qt::SkipEmptyParts);
for (const QString &hash : idStrings)
{
if (hash == u"*"_s)
continue;
const auto id = BitTorrent::TorrentID::fromString(hash);
BitTorrent::Torrent *const torrent = BitTorrent::Session::instance()->getTorrent(id);
if (!torrent)
throw APIError(APIErrorType::NotFound);
torrents.append(torrent);
}
if (hashParam == u"*"_s) if (hashParam == u"*"_s)
{ {
// remove trackers from all torrents // remove trackers from all torrents
@ -1230,17 +1246,7 @@ void TorrentsController::removeTrackersAction()
} }
else if (hashParam.contains(u'|')) else if (hashParam.contains(u'|'))
{ {
// remove trackers from all torrents in the list // Don't want to enter `else` with a `hashParam` not an id
const QStringList idStrings = hashParam.split(u'|', Qt::SkipEmptyParts);
for (const QString &hash : idStrings)
{
const auto id = BitTorrent::TorrentID::fromString(hash);
BitTorrent::Torrent *const torrent = BitTorrent::Session::instance()->getTorrent(id);
if (!torrent)
throw APIError(APIErrorType::NotFound);
torrents.append(torrent);
}
} }
else else
{ {