From 753c6629a3d5555283547b33346e50ee6a9f9095 Mon Sep 17 00:00:00 2001
From: Chocobo1 <Chocobo1@users.noreply.github.com>
Date: Wed, 28 May 2025 23:17:58 +0800
Subject: [PATCH 1/2] WebUI: use `defer` when loading scripts

So that the HTML layout can be rendered earlier.
---
 src/webui/www/private/addpeers.html           |   4 +-
 src/webui/www/private/addtrackers.html        |   4 +-
 src/webui/www/private/addwebseeds.html        |   4 +-
 .../www/private/confirmfeeddeletion.html      |   4 +-
 src/webui/www/private/confirmruleclear.html   |   4 +-
 .../www/private/confirmruledeletion.html      |   4 +-
 .../www/private/confirmtrackerdeletion.html   |   4 +-
 src/webui/www/private/download.html           |  50 ++--
 src/webui/www/private/editfeedurl.html        |   4 +-
 src/webui/www/private/edittracker.html        |   4 +-
 src/webui/www/private/editwebseed.html        |   4 +-
 src/webui/www/private/newcategory.html        |   8 +-
 src/webui/www/private/newfeed.html            |   4 +-
 src/webui/www/private/newfolder.html          |   4 +-
 src/webui/www/private/newrule.html            |   4 +-
 src/webui/www/private/newtag.html             |   6 +-
 src/webui/www/private/rename.html             |   4 +-
 src/webui/www/private/rename_feed.html        |   4 +-
 src/webui/www/private/rename_file.html        |   6 +-
 src/webui/www/private/rename_files.html       |  10 +-
 src/webui/www/private/rename_rule.html        |   4 +-
 src/webui/www/private/setlocation.html        |   6 +-
 src/webui/www/private/shareratio.html         |   4 +-
 src/webui/www/private/speedlimit.html         | 224 +++++++++---------
 src/webui/www/private/upload.html             |  46 ++--
 25 files changed, 216 insertions(+), 208 deletions(-)

diff --git a/src/webui/www/private/addpeers.html b/src/webui/www/private/addpeers.html
index d8d176161..39510862f 100644
--- a/src/webui/www/private/addpeers.html
+++ b/src/webui/www/private/addpeers.html
@@ -5,8 +5,8 @@
     <meta charset="UTF-8">
     <title>QBT_TR(Add Peers)QBT_TR[CONTEXT=PeersAdditionDialog]</title>
     <link rel="stylesheet" href="css/style.css?v=${CACHEID}" type="text/css">
-    <script src="scripts/localpreferences.js?v=${CACHEID}"></script>
-    <script src="scripts/color-scheme.js?v=${CACHEID}"></script>
+    <script defer src="scripts/localpreferences.js?v=${CACHEID}"></script>
+    <script defer src="scripts/color-scheme.js?v=${CACHEID}"></script>
     <script>
         "use strict";
 
diff --git a/src/webui/www/private/addtrackers.html b/src/webui/www/private/addtrackers.html
index 5e30e49eb..c736af237 100644
--- a/src/webui/www/private/addtrackers.html
+++ b/src/webui/www/private/addtrackers.html
@@ -5,8 +5,8 @@
     <meta charset="UTF-8">
     <title>QBT_TR(Add trackers)QBT_TR[CONTEXT=TrackersAdditionDialog]</title>
     <link rel="stylesheet" href="css/style.css?v=${CACHEID}" type="text/css">
-    <script src="scripts/localpreferences.js?v=${CACHEID}"></script>
-    <script src="scripts/color-scheme.js?v=${CACHEID}"></script>
+    <script defer src="scripts/localpreferences.js?v=${CACHEID}"></script>
+    <script defer src="scripts/color-scheme.js?v=${CACHEID}"></script>
     <script>
         "use strict";
 
diff --git a/src/webui/www/private/addwebseeds.html b/src/webui/www/private/addwebseeds.html
index b978c15d8..8b02b08d7 100644
--- a/src/webui/www/private/addwebseeds.html
+++ b/src/webui/www/private/addwebseeds.html
@@ -5,8 +5,8 @@
     <meta charset="UTF-8">
     <title>QBT_TR(Add web seeds)QBT_TR[CONTEXT=HttpServer]</title>
     <link rel="stylesheet" href="css/style.css?v=${CACHEID}" type="text/css">
-    <script src="scripts/localpreferences.js?v=${CACHEID}"></script>
-    <script src="scripts/color-scheme.js?v=${CACHEID}"></script>
+    <script defer src="scripts/localpreferences.js?v=${CACHEID}"></script>
+    <script defer src="scripts/color-scheme.js?v=${CACHEID}"></script>
     <script>
         "use strict";
 
diff --git a/src/webui/www/private/confirmfeeddeletion.html b/src/webui/www/private/confirmfeeddeletion.html
index d0bbf2aa4..27103f860 100644
--- a/src/webui/www/private/confirmfeeddeletion.html
+++ b/src/webui/www/private/confirmfeeddeletion.html
@@ -5,8 +5,8 @@
     <meta charset="UTF-8">
     <title>QBT_TR(Deletion confirmation)QBT_TR[CONTEXT=RSSWidget]</title>
     <link rel="stylesheet" href="css/style.css?v=${CACHEID}" type="text/css">
-    <script src="scripts/localpreferences.js?v=${CACHEID}"></script>
-    <script src="scripts/color-scheme.js?v=${CACHEID}"></script>
+    <script defer src="scripts/localpreferences.js?v=${CACHEID}"></script>
+    <script defer src="scripts/color-scheme.js?v=${CACHEID}"></script>
     <script>
         "use strict";
 
diff --git a/src/webui/www/private/confirmruleclear.html b/src/webui/www/private/confirmruleclear.html
index 9e1abf9d8..022e78eef 100644
--- a/src/webui/www/private/confirmruleclear.html
+++ b/src/webui/www/private/confirmruleclear.html
@@ -5,8 +5,8 @@
     <meta charset="UTF-8">
     <title>QBT_TR(Clear downloaded episodes)QBT_TR[CONTEXT=AutomatedRssDownloader]</title>
     <link rel="stylesheet" href="css/style.css?v=${CACHEID}" type="text/css">
-    <script src="scripts/localpreferences.js?v=${CACHEID}"></script>
-    <script src="scripts/color-scheme.js?v=${CACHEID}"></script>
+    <script defer src="scripts/localpreferences.js?v=${CACHEID}"></script>
+    <script defer src="scripts/color-scheme.js?v=${CACHEID}"></script>
     <script>
         "use strict";
 
diff --git a/src/webui/www/private/confirmruledeletion.html b/src/webui/www/private/confirmruledeletion.html
index 8440610c3..16c224829 100644
--- a/src/webui/www/private/confirmruledeletion.html
+++ b/src/webui/www/private/confirmruledeletion.html
@@ -5,8 +5,8 @@
     <meta charset="UTF-8">
     <title>QBT_TR(Rule deletion confirmation)QBT_TR[CONTEXT=AutomatedRssDownloader]</title>
     <link rel="stylesheet" href="css/style.css?v=${CACHEID}" type="text/css">
-    <script src="scripts/localpreferences.js?v=${CACHEID}"></script>
-    <script src="scripts/color-scheme.js?v=${CACHEID}"></script>
+    <script defer src="scripts/localpreferences.js?v=${CACHEID}"></script>
+    <script defer src="scripts/color-scheme.js?v=${CACHEID}"></script>
     <script>
         "use strict";
 
diff --git a/src/webui/www/private/confirmtrackerdeletion.html b/src/webui/www/private/confirmtrackerdeletion.html
index 8bda4c0bc..6a6950c5c 100644
--- a/src/webui/www/private/confirmtrackerdeletion.html
+++ b/src/webui/www/private/confirmtrackerdeletion.html
@@ -5,8 +5,8 @@
     <meta charset="UTF-8">
     <title>QBT_TR(Remove tracker)QBT_TR[CONTEXT=confirmDeletionDlg]</title>
     <link rel="stylesheet" href="css/style.css?v=${CACHEID}" type="text/css">
-    <script src="scripts/localpreferences.js?v=${CACHEID}"></script>
-    <script src="scripts/color-scheme.js?v=${CACHEID}"></script>
+    <script defer src="scripts/localpreferences.js?v=${CACHEID}"></script>
+    <script defer src="scripts/color-scheme.js?v=${CACHEID}"></script>
     <script>
         "use strict";
 
diff --git a/src/webui/www/private/download.html b/src/webui/www/private/download.html
index 6375f8d8e..dd037eff2 100644
--- a/src/webui/www/private/download.html
+++ b/src/webui/www/private/download.html
@@ -6,10 +6,10 @@
     <title>QBT_TR(Add Torrent Links)QBT_TR[CONTEXT=downloadFromURL]</title>
     <link rel="stylesheet" href="css/style.css?v=${CACHEID}" type="text/css">
     <link rel="stylesheet" href="css/Window.css?v=${CACHEID}" type="text/css">
-    <script src="scripts/localpreferences.js?v=${CACHEID}"></script>
-    <script src="scripts/color-scheme.js?v=${CACHEID}"></script>
-    <script src="scripts/download.js?v=${CACHEID}"></script>
-    <script src="scripts/pathAutofill.js?v=${CACHEID}"></script>
+    <script defer src="scripts/localpreferences.js?v=${CACHEID}"></script>
+    <script defer src="scripts/color-scheme.js?v=${CACHEID}"></script>
+    <script defer src="scripts/download.js?v=${CACHEID}"></script>
+    <script defer src="scripts/pathAutofill.js?v=${CACHEID}"></script>
 </head>
 
 <body>
@@ -160,31 +160,33 @@
     <script>
         "use strict";
 
-        const encodedUrls = new URLSearchParams(window.location.search).get("urls");
-        if (encodedUrls !== null) {
-            const urls = encodedUrls.split("|").map(decodeURIComponent);
-            if (urls.length > 0)
-                document.getElementById("urls").value = urls.join("\n");
-        }
+        window.addEventListener("DOMContentLoaded", (event) => {
+            const encodedUrls = new URLSearchParams(window.location.search).get("urls");
+            if (encodedUrls !== null) {
+                const urls = encodedUrls.split("|").map(decodeURIComponent);
+                if (urls.length > 0)
+                    document.getElementById("urls").value = urls.join("\n");
+            }
 
-        let submitted = false;
+            let submitted = false;
 
-        document.getElementById("downloadForm").addEventListener("submit", (event) => {
-            document.getElementById("startTorrentHidden").value = document.getElementById("startTorrent").checked ? "false" : "true";
+            document.getElementById("downloadForm").addEventListener("submit", (event) => {
+                document.getElementById("startTorrentHidden").value = document.getElementById("startTorrent").checked ? "false" : "true";
 
-            document.getElementById("dlLimitHidden").value = Number(document.getElementById("dlLimitText").value) * 1024;
-            document.getElementById("upLimitHidden").value = Number(document.getElementById("upLimitText").value) * 1024;
+                document.getElementById("dlLimitHidden").value = Number(document.getElementById("dlLimitText").value) * 1024;
+                document.getElementById("upLimitHidden").value = Number(document.getElementById("upLimitText").value) * 1024;
 
-            document.getElementById("download_spinner").style.display = "block";
-            submitted = true;
+                document.getElementById("download_spinner").style.display = "block";
+                submitted = true;
+            });
+
+            document.getElementById("download_frame").addEventListener("load", (event) => {
+                if (submitted)
+                    window.parent.qBittorrent.Client.closeFrameWindow(window);
+            });
+
+            window.qBittorrent.pathAutofill.attachPathAutofill();
         });
-
-        document.getElementById("download_frame").addEventListener("load", (event) => {
-            if (submitted)
-                window.parent.qBittorrent.Client.closeFrameWindow(window);
-        });
-
-        window.qBittorrent.pathAutofill.attachPathAutofill();
     </script>
 </body>
 
diff --git a/src/webui/www/private/editfeedurl.html b/src/webui/www/private/editfeedurl.html
index 9d87b5176..c1bd69c9a 100644
--- a/src/webui/www/private/editfeedurl.html
+++ b/src/webui/www/private/editfeedurl.html
@@ -5,8 +5,8 @@
     <meta charset="UTF-8">
     <title>QBT_TR(Please type a RSS feed URL)QBT_TR[CONTEXT=RSSWidget]</title>
     <link rel="stylesheet" href="css/style.css?v=${CACHEID}" type="text/css">
-    <script src="scripts/localpreferences.js?v=${CACHEID}"></script>
-    <script src="scripts/color-scheme.js?v=${CACHEID}"></script>
+    <script defer src="scripts/localpreferences.js?v=${CACHEID}"></script>
+    <script defer src="scripts/color-scheme.js?v=${CACHEID}"></script>
     <script>
         "use strict";
 
diff --git a/src/webui/www/private/edittracker.html b/src/webui/www/private/edittracker.html
index 4cb53c992..b5aff329d 100644
--- a/src/webui/www/private/edittracker.html
+++ b/src/webui/www/private/edittracker.html
@@ -5,8 +5,8 @@
     <meta charset="UTF-8">
     <title>QBT_TR(Tracker editing)QBT_TR[CONTEXT=TrackerListWidget]</title>
     <link rel="stylesheet" href="css/style.css?v=${CACHEID}" type="text/css">
-    <script src="scripts/localpreferences.js?v=${CACHEID}"></script>
-    <script src="scripts/color-scheme.js?v=${CACHEID}"></script>
+    <script defer src="scripts/localpreferences.js?v=${CACHEID}"></script>
+    <script defer src="scripts/color-scheme.js?v=${CACHEID}"></script>
     <script>
         "use strict";
 
diff --git a/src/webui/www/private/editwebseed.html b/src/webui/www/private/editwebseed.html
index 245c42a78..b15e09bb6 100644
--- a/src/webui/www/private/editwebseed.html
+++ b/src/webui/www/private/editwebseed.html
@@ -5,8 +5,8 @@
     <meta charset="UTF-8">
     <title>QBT_TR(Edit web seed)QBT_TR[CONTEXT=HttpServer]</title>
     <link rel="stylesheet" href="css/style.css?v=${CACHEID}" type="text/css">
-    <script src="scripts/localpreferences.js?v=${CACHEID}"></script>
-    <script src="scripts/color-scheme.js?v=${CACHEID}"></script>
+    <script defer src="scripts/localpreferences.js?v=${CACHEID}"></script>
+    <script defer src="scripts/color-scheme.js?v=${CACHEID}"></script>
     <script>
         "use strict";
 
diff --git a/src/webui/www/private/newcategory.html b/src/webui/www/private/newcategory.html
index 86fe8fdf5..3abdc6f2a 100644
--- a/src/webui/www/private/newcategory.html
+++ b/src/webui/www/private/newcategory.html
@@ -5,10 +5,10 @@
     <meta charset="UTF-8">
     <title>QBT_TR(New Category)QBT_TR[CONTEXT=TransferListWidget]</title>
     <link rel="stylesheet" href="css/style.css?v=${CACHEID}" type="text/css">
-    <script src="scripts/localpreferences.js?v=${CACHEID}"></script>
-    <script src="scripts/color-scheme.js?v=${CACHEID}"></script>
-    <script src="scripts/misc.js?locale=${LANG}&v=${CACHEID}"></script>
-    <script src="scripts/pathAutofill.js?v=${CACHEID}"></script>
+    <script defer src="scripts/localpreferences.js?v=${CACHEID}"></script>
+    <script defer src="scripts/color-scheme.js?v=${CACHEID}"></script>
+    <script defer src="scripts/misc.js?locale=${LANG}&v=${CACHEID}"></script>
+    <script defer src="scripts/pathAutofill.js?v=${CACHEID}"></script>
     <script>
         "use strict";
 
diff --git a/src/webui/www/private/newfeed.html b/src/webui/www/private/newfeed.html
index 44bbdb359..743cb2f9d 100644
--- a/src/webui/www/private/newfeed.html
+++ b/src/webui/www/private/newfeed.html
@@ -5,8 +5,8 @@
     <meta charset="UTF-8">
     <title>QBT_TR(Please type a RSS feed URL)QBT_TR[CONTEXT=RSSWidget]</title>
     <link rel="stylesheet" href="css/style.css?v=${CACHEID}" type="text/css">
-    <script src="scripts/localpreferences.js?v=${CACHEID}"></script>
-    <script src="scripts/color-scheme.js?v=${CACHEID}"></script>
+    <script defer src="scripts/localpreferences.js?v=${CACHEID}"></script>
+    <script defer src="scripts/color-scheme.js?v=${CACHEID}"></script>
     <script>
         "use strict";
 
diff --git a/src/webui/www/private/newfolder.html b/src/webui/www/private/newfolder.html
index 7f1ea3caa..ce774b9d2 100644
--- a/src/webui/www/private/newfolder.html
+++ b/src/webui/www/private/newfolder.html
@@ -5,8 +5,8 @@
     <meta charset="UTF-8">
     <title>QBT_TR(Please choose a folder name)QBT_TR[CONTEXT=RSSWidget]</title>
     <link rel="stylesheet" href="css/style.css?v=${CACHEID}" type="text/css">
-    <script src="scripts/localpreferences.js?v=${CACHEID}"></script>
-    <script src="scripts/color-scheme.js?v=${CACHEID}"></script>
+    <script defer src="scripts/localpreferences.js?v=${CACHEID}"></script>
+    <script defer src="scripts/color-scheme.js?v=${CACHEID}"></script>
     <script>
         "use strict";
 
diff --git a/src/webui/www/private/newrule.html b/src/webui/www/private/newrule.html
index cfda12745..c52fd4e3b 100644
--- a/src/webui/www/private/newrule.html
+++ b/src/webui/www/private/newrule.html
@@ -5,8 +5,8 @@
     <meta charset="UTF-8">
     <title>QBT_TR(New rule name)QBT_TR[CONTEXT=AutomatedRssDownloader]</title>
     <link rel="stylesheet" href="css/style.css?v=${CACHEID}" type="text/css">
-    <script src="scripts/localpreferences.js?v=${CACHEID}"></script>
-    <script src="scripts/color-scheme.js?v=${CACHEID}"></script>
+    <script defer src="scripts/localpreferences.js?v=${CACHEID}"></script>
+    <script defer src="scripts/color-scheme.js?v=${CACHEID}"></script>
     <script>
         "use strict";
 
diff --git a/src/webui/www/private/newtag.html b/src/webui/www/private/newtag.html
index debfaf999..3d50b2d65 100644
--- a/src/webui/www/private/newtag.html
+++ b/src/webui/www/private/newtag.html
@@ -5,9 +5,9 @@
     <meta charset="UTF-8">
     <title>QBT_TR(Add tags)QBT_TR[CONTEXT=TransferListWidget]</title>
     <link rel="stylesheet" href="css/style.css?v=${CACHEID}" type="text/css">
-    <script src="scripts/localpreferences.js?v=${CACHEID}"></script>
-    <script src="scripts/color-scheme.js?v=${CACHEID}"></script>
-    <script src="scripts/misc.js?locale=${LANG}&v=${CACHEID}"></script>
+    <script defer src="scripts/localpreferences.js?v=${CACHEID}"></script>
+    <script defer src="scripts/color-scheme.js?v=${CACHEID}"></script>
+    <script defer src="scripts/misc.js?locale=${LANG}&v=${CACHEID}"></script>
     <script>
         "use strict";
 
diff --git a/src/webui/www/private/rename.html b/src/webui/www/private/rename.html
index 8ee4ffdb9..ff920ba3e 100644
--- a/src/webui/www/private/rename.html
+++ b/src/webui/www/private/rename.html
@@ -5,8 +5,8 @@
     <meta charset="UTF-8">
     <title>QBT_TR(Rename)QBT_TR[CONTEXT=TransferListWidget]</title>
     <link rel="stylesheet" href="css/style.css?v=${CACHEID}" type="text/css">
-    <script src="scripts/localpreferences.js?v=${CACHEID}"></script>
-    <script src="scripts/color-scheme.js?v=${CACHEID}"></script>
+    <script defer src="scripts/localpreferences.js?v=${CACHEID}"></script>
+    <script defer src="scripts/color-scheme.js?v=${CACHEID}"></script>
     <script>
         "use strict";
 
diff --git a/src/webui/www/private/rename_feed.html b/src/webui/www/private/rename_feed.html
index 7a26c07fc..dc2ce7b63 100644
--- a/src/webui/www/private/rename_feed.html
+++ b/src/webui/www/private/rename_feed.html
@@ -5,8 +5,8 @@
     <meta charset="UTF-8">
     <title>QBT_TR(Please choose a new name for this RSS feed)QBT_TR[CONTEXT=RSSWidget]</title>
     <link rel="stylesheet" href="css/style.css?v=${CACHEID}" type="text/css">
-    <script src="scripts/localpreferences.js?v=${CACHEID}"></script>
-    <script src="scripts/color-scheme.js?v=${CACHEID}"></script>
+    <script defer src="scripts/localpreferences.js?v=${CACHEID}"></script>
+    <script defer src="scripts/color-scheme.js?v=${CACHEID}"></script>
     <script>
         "use strict";
 
diff --git a/src/webui/www/private/rename_file.html b/src/webui/www/private/rename_file.html
index 5e4fade6d..6ce3d80d6 100644
--- a/src/webui/www/private/rename_file.html
+++ b/src/webui/www/private/rename_file.html
@@ -5,9 +5,9 @@
     <meta charset="UTF-8">
     <title>QBT_TR(Renaming)QBT_TR[CONTEXT=TorrentContentTreeView]</title>
     <link rel="stylesheet" href="css/style.css?v=${CACHEID}" type="text/css">
-    <script src="scripts/localpreferences.js?v=${CACHEID}"></script>
-    <script src="scripts/color-scheme.js?v=${CACHEID}"></script>
-    <script src="scripts/filesystem.js?v=${CACHEID}"></script>
+    <script defer src="scripts/localpreferences.js?v=${CACHEID}"></script>
+    <script defer src="scripts/color-scheme.js?v=${CACHEID}"></script>
+    <script defer src="scripts/filesystem.js?v=${CACHEID}"></script>
     <script>
         "use strict";
 
diff --git a/src/webui/www/private/rename_files.html b/src/webui/www/private/rename_files.html
index bdfc46e75..9406c3f5a 100644
--- a/src/webui/www/private/rename_files.html
+++ b/src/webui/www/private/rename_files.html
@@ -4,11 +4,11 @@
 <head>
     <meta charset="UTF-8">
     <title>QBT_TR(Renaming)QBT_TR[CONTEXT=TorrentContentTreeView]</title>
-    <script src="scripts/filesystem.js?v=${CACHEID}"></script>
-    <script src="scripts/misc.js?locale=${LANG}&v=${CACHEID}"></script>
-    <script src="scripts/file-tree.js?v=${CACHEID}"></script>
-    <script src="scripts/dynamicTable.js?locale=${LANG}&v=${CACHEID}"></script>
-    <script src="scripts/rename-files.js?v=${CACHEID}"></script>
+    <script defer src="scripts/filesystem.js?v=${CACHEID}"></script>
+    <script defer src="scripts/misc.js?locale=${LANG}&v=${CACHEID}"></script>
+    <script defer src="scripts/file-tree.js?v=${CACHEID}"></script>
+    <script defer src="scripts/dynamicTable.js?locale=${LANG}&v=${CACHEID}"></script>
+    <script defer src="scripts/rename-files.js?v=${CACHEID}"></script>
     <script>
         "use strict";
 
diff --git a/src/webui/www/private/rename_rule.html b/src/webui/www/private/rename_rule.html
index ac05aa923..2dfb66087 100644
--- a/src/webui/www/private/rename_rule.html
+++ b/src/webui/www/private/rename_rule.html
@@ -5,8 +5,8 @@
     <meta charset="UTF-8">
     <title>QBT_TR(Rule renaming)QBT_TR[CONTEXT=AutomatedRssDownloader]</title>
     <link rel="stylesheet" href="css/style.css?v=${CACHEID}" type="text/css">
-    <script src="scripts/localpreferences.js?v=${CACHEID}"></script>
-    <script src="scripts/color-scheme.js?v=${CACHEID}"></script>
+    <script defer src="scripts/localpreferences.js?v=${CACHEID}"></script>
+    <script defer src="scripts/color-scheme.js?v=${CACHEID}"></script>
     <script>
         "use strict";
 
diff --git a/src/webui/www/private/setlocation.html b/src/webui/www/private/setlocation.html
index f888cdc6d..e03ca04cb 100644
--- a/src/webui/www/private/setlocation.html
+++ b/src/webui/www/private/setlocation.html
@@ -5,9 +5,9 @@
     <meta charset="UTF-8">
     <title>QBT_TR(Set location)QBT_TR[CONTEXT=HttpServer]</title>
     <link rel="stylesheet" href="css/style.css?v=${CACHEID}" type="text/css">
-    <script src="scripts/localpreferences.js?v=${CACHEID}"></script>
-    <script src="scripts/color-scheme.js?v=${CACHEID}"></script>
-    <script src="scripts/pathAutofill.js?v=${CACHEID}"></script>
+    <script defer src="scripts/localpreferences.js?v=${CACHEID}"></script>
+    <script defer src="scripts/color-scheme.js?v=${CACHEID}"></script>
+    <script defer src="scripts/pathAutofill.js?v=${CACHEID}"></script>
     <script>
         "use strict";
 
diff --git a/src/webui/www/private/shareratio.html b/src/webui/www/private/shareratio.html
index f1482ef6f..1a4db9554 100644
--- a/src/webui/www/private/shareratio.html
+++ b/src/webui/www/private/shareratio.html
@@ -5,8 +5,8 @@
     <meta charset="UTF-8">
     <title>QBT_TR(Torrent Upload/Download Ratio Limiting)QBT_TR[CONTEXT=UpDownRatioDialog]</title>
     <link rel="stylesheet" href="css/style.css?v=${CACHEID}" type="text/css">
-    <script src="scripts/localpreferences.js?v=${CACHEID}"></script>
-    <script src="scripts/color-scheme.js?v=${CACHEID}"></script>
+    <script defer src="scripts/localpreferences.js?v=${CACHEID}"></script>
+    <script defer src="scripts/color-scheme.js?v=${CACHEID}"></script>
     <script>
         "use strict";
 
diff --git a/src/webui/www/private/speedlimit.html b/src/webui/www/private/speedlimit.html
index 5bfd5840f..d4e3f9a6d 100644
--- a/src/webui/www/private/speedlimit.html
+++ b/src/webui/www/private/speedlimit.html
@@ -5,8 +5,8 @@
     <meta charset="UTF-8">
     <title>QBT_TR(Speed limit)QBT_TR[CONTEXT=SpeedLimit]</title>
     <link rel="stylesheet" href="css/style.css?v=${CACHEID}" type="text/css">
-    <script src="scripts/localpreferences.js?v=${CACHEID}"></script>
-    <script src="scripts/color-scheme.js?v=${CACHEID}"></script>
+    <script defer src="scripts/localpreferences.js?v=${CACHEID}"></script>
+    <script defer src="scripts/color-scheme.js?v=${CACHEID}"></script>
 </head>
 
 <body>
@@ -19,140 +19,144 @@
             </div>
             <input type="range" id="limitSliderInput" min="0" value="0" style="width: 100%;" aria-label="QBT_TR(Speed limit)QBT_TR[CONTEXT=SpeedLimit]">
         </div>
-        <input type="button" id="applyButton" value="QBT_TR(Apply)QBT_TR[CONTEXT=HttpServer]" onclick="saveLimit()">
+        <input type="button" id="applyButton" value="QBT_TR(Apply)QBT_TR[CONTEXT=HttpServer]">
     </div>
 
     <script>
         "use strict";
 
-        window.addEventListener("keydown", (event) => {
-            switch (event.key) {
-                case "Enter":
-                    event.preventDefault();
-                    document.getElementById("applyButton").click();
-                    break;
-                case "Escape":
-                    event.preventDefault();
-                    window.parent.qBittorrent.Client.closeFrameWindow(window);
-                    break;
-            }
-        });
+        window.addEventListener("DOMContentLoaded", (event) => {
+            const applyButton = document.getElementById("applyButton");
 
-        const params = new URLSearchParams(window.location.search);
-        const type = params.get("type");
-        const hashes = params.get("hashes").split("|");
-
-        const isGlobal = (hashes[0] === "global");
-        // Otherwise it's download limit
-        const isUpload = (type === "upload");
-
-        const getLimitMethod = isUpload ? "uploadLimit" : "downloadLimit";
-        const setLimitMethod = isUpload ? "setUploadLimit" : "setDownloadLimit";
-
-        const limitUpdateValue = document.getElementById("limitUpdateValue");
-        const limitUnit = document.getElementById("limitUnit");
-
-        const setLimitUpdateValue = (value) => {
-            if (value === 0) {
-                limitUpdateValue.value = "∞";
-                limitUnit.style.visibility = "hidden";
-            }
-            else {
-                limitUpdateValue.value = value;
-                limitUnit.style.visibility = "visible";
-            }
-        };
-
-        const setupSlider = (limit, maximum) => {
-            const input = document.getElementById("limitSliderInput");
-            input.max = maximum;
-            input.value = limit;
-            input.addEventListener("input", (event) => {
-                setLimitUpdateValue(Number(event.target.value));
+            window.addEventListener("keydown", (event) => {
+                switch (event.key) {
+                    case "Enter":
+                        event.preventDefault();
+                        applyButton.click();
+                        break;
+                    case "Escape":
+                        event.preventDefault();
+                        window.parent.qBittorrent.Client.closeFrameWindow(window);
+                        break;
+                }
             });
-            // Set default value
-            setLimitUpdateValue(limit);
-        };
 
-        const saveLimit = () => {
-            const limit = Number(limitUpdateValue.value) * 1024;
-            if (isGlobal) {
-                fetch(`api/v2/transfer/${setLimitMethod}`, {
-                        method: "POST",
-                        body: new URLSearchParams({
-                            limit: limit
-                        })
-                    })
-                    .then((response) => {
-                        if (!response.ok)
-                            return;
+            const params = new URLSearchParams(window.location.search);
+            const type = params.get("type");
+            const hashes = params.get("hashes").split("|");
 
-                        window.parent.updateMainData();
-                        window.parent.qBittorrent.Client.closeFrameWindow(window);
-                    });
-            }
-            else {
-                fetch(`api/v2/torrents/${setLimitMethod}`, {
-                        method: "POST",
-                        body: new URLSearchParams({
-                            hashes: hashes.join("|"),
-                            limit: limit
-                        })
-                    })
-                    .then((response) => {
-                        if (!response.ok)
-                            return;
+            const isGlobal = (hashes[0] === "global");
+            // Otherwise it's download limit
+            const isUpload = (type === "upload");
 
-                        window.parent.qBittorrent.Client.closeFrameWindow(window);
-                    });
-            }
-        };
+            const getLimitMethod = isUpload ? "uploadLimit" : "downloadLimit";
+            const setLimitMethod = isUpload ? "setUploadLimit" : "setDownloadLimit";
 
-        document.getElementById("limitUpdateLabel").textContent =
-            isUpload
-            ? `QBT_TR(Upload limit:)QBT_TR[CONTEXT=SpeedLimit]`
-            : `QBT_TR(Download limit:)QBT_TR[CONTEXT=SpeedLimit]`;
+            const limitUpdateValue = document.getElementById("limitUpdateValue");
+            const limitUnit = document.getElementById("limitUnit");
 
-        fetch(`api/v2/transfer/${getLimitMethod}`, {
-                method: "GET",
-                cache: "no-store"
-            })
-            .then(async (response) => {
-                if (!response.ok)
-                    return;
-
-                const data = await response.text();
-
-                const globalLimit = Math.max((Number(data) / 1024), 0);
-
-                // Get torrents download limit
-                // And create slider
-                if (isGlobal) {
-                    setupSlider(globalLimit, 10000);
+            const setLimitUpdateValue = (value) => {
+                if (value === 0) {
+                    limitUpdateValue.value = "∞";
+                    limitUnit.style.visibility = "hidden";
                 }
                 else {
-                    fetch(`api/v2/torrents/${getLimitMethod}`, {
+                    limitUpdateValue.value = value;
+                    limitUnit.style.visibility = "visible";
+                }
+            };
+
+            const setupSlider = (limit, maximum) => {
+                const input = document.getElementById("limitSliderInput");
+                input.max = maximum;
+                input.value = limit;
+                input.addEventListener("input", (event) => {
+                    setLimitUpdateValue(Number(event.target.value));
+                });
+                // Set default value
+                setLimitUpdateValue(limit);
+            };
+
+            applyButton.addEventListener("click", (event) => {
+                const limit = Number(limitUpdateValue.value) * 1024;
+                if (isGlobal) {
+                    fetch(`api/v2/transfer/${setLimitMethod}`, {
                             method: "POST",
                             body: new URLSearchParams({
-                                hashes: hashes.join("|")
+                                limit: limit
                             })
                         })
-                        .then(async (response) => {
+                        .then((response) => {
                             if (!response.ok)
                                 return;
 
-                            const data = await response.json();
+                            window.parent.updateMainData();
+                            window.parent.qBittorrent.Client.closeFrameWindow(window);
+                        });
+                }
+                else {
+                    fetch(`api/v2/torrents/${setLimitMethod}`, {
+                            method: "POST",
+                            body: new URLSearchParams({
+                                hashes: hashes.join("|"),
+                                limit: limit
+                            })
+                        })
+                        .then((response) => {
+                            if (!response.ok)
+                                return;
 
-                            const firstLimit = Math.max(data[hashes[0]], 0);
-                            const isAllFirstLimit = Object.values(data).every(value => value === firstLimit);
-                            const limit = isAllFirstLimit ? Math.round(firstLimit / 1024) : 0;
-
-                            setupSlider(limit, ((globalLimit > 0) ? globalLimit : 1000));
+                            window.parent.qBittorrent.Client.closeFrameWindow(window);
                         });
                 }
             });
 
-        limitUpdateValue.focus();
+            document.getElementById("limitUpdateLabel").textContent =
+                isUpload
+                ? `QBT_TR(Upload limit:)QBT_TR[CONTEXT=SpeedLimit]`
+                : `QBT_TR(Download limit:)QBT_TR[CONTEXT=SpeedLimit]`;
+
+            fetch(`api/v2/transfer/${getLimitMethod}`, {
+                    method: "GET",
+                    cache: "no-store"
+                })
+                .then(async (response) => {
+                    if (!response.ok)
+                        return;
+
+                    const data = await response.text();
+
+                    const globalLimit = Math.max((Number(data) / 1024), 0);
+
+                    // Get torrents download limit
+                    // And create slider
+                    if (isGlobal) {
+                        setupSlider(globalLimit, 10000);
+                    }
+                    else {
+                        fetch(`api/v2/torrents/${getLimitMethod}`, {
+                                method: "POST",
+                                body: new URLSearchParams({
+                                    hashes: hashes.join("|")
+                                })
+                            })
+                            .then(async (response) => {
+                                if (!response.ok)
+                                    return;
+
+                                const data = await response.json();
+
+                                const firstLimit = Math.max(data[hashes[0]], 0);
+                                const isAllFirstLimit = Object.values(data).every(value => value === firstLimit);
+                                const limit = isAllFirstLimit ? Math.round(firstLimit / 1024) : 0;
+
+                                setupSlider(limit, ((globalLimit > 0) ? globalLimit : 1000));
+                            });
+                    }
+                });
+
+            limitUpdateValue.focus();
+        });
     </script>
 </body>
 
diff --git a/src/webui/www/private/upload.html b/src/webui/www/private/upload.html
index ab2410627..ff5340536 100644
--- a/src/webui/www/private/upload.html
+++ b/src/webui/www/private/upload.html
@@ -6,10 +6,10 @@
     <title>QBT_TR(Upload local torrent)QBT_TR[CONTEXT=HttpServer]</title>
     <link rel="stylesheet" href="css/style.css?v=${CACHEID}" type="text/css">
     <link rel="stylesheet" href="css/Window.css?v=${CACHEID}" type="text/css">
-    <script src="scripts/localpreferences.js?v=${CACHEID}"></script>
-    <script src="scripts/color-scheme.js?v=${CACHEID}"></script>
-    <script src="scripts/download.js?v=${CACHEID}"></script>
-    <script src="scripts/pathAutofill.js?v=${CACHEID}"></script>
+    <script defer src="scripts/localpreferences.js?v=${CACHEID}"></script>
+    <script defer src="scripts/color-scheme.js?v=${CACHEID}"></script>
+    <script defer src="scripts/download.js?v=${CACHEID}"></script>
+    <script defer src="scripts/pathAutofill.js?v=${CACHEID}"></script>
 </head>
 
 <body>
@@ -157,28 +157,30 @@
     <script>
         "use strict";
 
-        let submitted = false;
+        window.addEventListener("DOMContentLoaded", (event) => {
+            let submitted = false;
 
-        document.getElementById("uploadForm").addEventListener("submit", (event) => {
-            document.getElementById("startTorrentHidden").value = document.getElementById("startTorrent").checked ? "false" : "true";
+            document.getElementById("uploadForm").addEventListener("submit", (event) => {
+                document.getElementById("startTorrentHidden").value = document.getElementById("startTorrent").checked ? "false" : "true";
 
-            document.getElementById("dlLimitHidden").value = Number(document.getElementById("dlLimitText").value) * 1024;
-            document.getElementById("upLimitHidden").value = Number(document.getElementById("upLimitText").value) * 1024;
+                document.getElementById("dlLimitHidden").value = Number(document.getElementById("dlLimitText").value) * 1024;
+                document.getElementById("upLimitHidden").value = Number(document.getElementById("upLimitText").value) * 1024;
 
-            document.getElementById("upload_spinner").style.display = "block";
-            submitted = true;
+                document.getElementById("upload_spinner").style.display = "block";
+                submitted = true;
+            });
+
+            document.getElementById("upload_frame").addEventListener("load", (event) => {
+                if (submitted)
+                    window.parent.qBittorrent.Client.closeFrameWindow(window);
+            });
+
+            const userAgent = (navigator.userAgentData?.platform ?? navigator.platform).toLowerCase();
+            if (userAgent.includes("ipad") || userAgent.includes("iphone") || (userAgent.includes("mac") && (navigator.maxTouchPoints > 1)))
+                document.getElementById("fileselect").accept = ".torrent";
+
+            window.qBittorrent.pathAutofill.attachPathAutofill();
         });
-
-        document.getElementById("upload_frame").addEventListener("load", (event) => {
-            if (submitted)
-                window.parent.qBittorrent.Client.closeFrameWindow(window);
-        });
-
-        const userAgent = (navigator.userAgentData?.platform ?? navigator.platform).toLowerCase();
-        if (userAgent.includes("ipad") || userAgent.includes("iphone") || (userAgent.includes("mac") && (navigator.maxTouchPoints > 1)))
-            document.getElementById("fileselect").accept = ".torrent";
-
-        window.qBittorrent.pathAutofill.attachPathAutofill();
     </script>
 </body>
 

From 5605e083475facebff958c193a265c101f23d2ff Mon Sep 17 00:00:00 2001
From: Chocobo1 <Chocobo1@users.noreply.github.com>
Date: Mon, 16 Jun 2025 03:10:37 +0800
Subject: [PATCH 2/2] WebUI: move scripts into `<head>` section

For consistency reasons.
---
 src/webui/www/private/download.html   | 63 +++++++++++++--------------
 src/webui/www/private/speedlimit.html | 29 ++++++------
 src/webui/www/private/upload.html     | 57 ++++++++++++------------
 3 files changed, 73 insertions(+), 76 deletions(-)

diff --git a/src/webui/www/private/download.html b/src/webui/www/private/download.html
index dd037eff2..53921e64d 100644
--- a/src/webui/www/private/download.html
+++ b/src/webui/www/private/download.html
@@ -10,6 +10,37 @@
     <script defer src="scripts/color-scheme.js?v=${CACHEID}"></script>
     <script defer src="scripts/download.js?v=${CACHEID}"></script>
     <script defer src="scripts/pathAutofill.js?v=${CACHEID}"></script>
+    <script>
+        "use strict";
+
+        window.addEventListener("DOMContentLoaded", (event) => {
+            const encodedUrls = new URLSearchParams(window.location.search).get("urls");
+            if (encodedUrls !== null) {
+                const urls = encodedUrls.split("|").map(decodeURIComponent);
+                if (urls.length > 0)
+                    document.getElementById("urls").value = urls.join("\n");
+            }
+
+            let submitted = false;
+
+            document.getElementById("downloadForm").addEventListener("submit", (event) => {
+                document.getElementById("startTorrentHidden").value = document.getElementById("startTorrent").checked ? "false" : "true";
+
+                document.getElementById("dlLimitHidden").value = Number(document.getElementById("dlLimitText").value) * 1024;
+                document.getElementById("upLimitHidden").value = Number(document.getElementById("upLimitText").value) * 1024;
+
+                document.getElementById("download_spinner").style.display = "block";
+                submitted = true;
+            });
+
+            document.getElementById("download_frame").addEventListener("load", (event) => {
+                if (submitted)
+                    window.parent.qBittorrent.Client.closeFrameWindow(window);
+            });
+
+            window.qBittorrent.pathAutofill.attachPathAutofill();
+        });
+    </script>
 </head>
 
 <body>
@@ -156,38 +187,6 @@
         </div>
     </form>
     <div id="download_spinner" class="mochaSpinner"></div>
-
-    <script>
-        "use strict";
-
-        window.addEventListener("DOMContentLoaded", (event) => {
-            const encodedUrls = new URLSearchParams(window.location.search).get("urls");
-            if (encodedUrls !== null) {
-                const urls = encodedUrls.split("|").map(decodeURIComponent);
-                if (urls.length > 0)
-                    document.getElementById("urls").value = urls.join("\n");
-            }
-
-            let submitted = false;
-
-            document.getElementById("downloadForm").addEventListener("submit", (event) => {
-                document.getElementById("startTorrentHidden").value = document.getElementById("startTorrent").checked ? "false" : "true";
-
-                document.getElementById("dlLimitHidden").value = Number(document.getElementById("dlLimitText").value) * 1024;
-                document.getElementById("upLimitHidden").value = Number(document.getElementById("upLimitText").value) * 1024;
-
-                document.getElementById("download_spinner").style.display = "block";
-                submitted = true;
-            });
-
-            document.getElementById("download_frame").addEventListener("load", (event) => {
-                if (submitted)
-                    window.parent.qBittorrent.Client.closeFrameWindow(window);
-            });
-
-            window.qBittorrent.pathAutofill.attachPathAutofill();
-        });
-    </script>
 </body>
 
 </html>
diff --git a/src/webui/www/private/speedlimit.html b/src/webui/www/private/speedlimit.html
index d4e3f9a6d..95434e188 100644
--- a/src/webui/www/private/speedlimit.html
+++ b/src/webui/www/private/speedlimit.html
@@ -7,21 +7,6 @@
     <link rel="stylesheet" href="css/style.css?v=${CACHEID}" type="text/css">
     <script defer src="scripts/localpreferences.js?v=${CACHEID}"></script>
     <script defer src="scripts/color-scheme.js?v=${CACHEID}"></script>
-</head>
-
-<body>
-    <div style="padding-top: 10px; width: 100%; text-align: center; margin: 0 auto; overflow: hidden">
-        <div class="slider">
-            <div class="update">
-                <label id="limitUpdateLabel" for="limitUpdateValue">QBT_TR(Limit:)QBT_TR[CONTEXT=SpeedLimit]</label>
-                <input type="text" id="limitUpdateValue" size="6" placeholder="∞" style="text-align: center;">
-                <span id="limitUnit">QBT_TR(KiB/s)QBT_TR[CONTEXT=SpeedLimit]</span>
-            </div>
-            <input type="range" id="limitSliderInput" min="0" value="0" style="width: 100%;" aria-label="QBT_TR(Speed limit)QBT_TR[CONTEXT=SpeedLimit]">
-        </div>
-        <input type="button" id="applyButton" value="QBT_TR(Apply)QBT_TR[CONTEXT=HttpServer]">
-    </div>
-
     <script>
         "use strict";
 
@@ -158,6 +143,20 @@
             limitUpdateValue.focus();
         });
     </script>
+</head>
+
+<body>
+    <div style="padding-top: 10px; width: 100%; text-align: center; margin: 0 auto; overflow: hidden">
+        <div class="slider">
+            <div class="update">
+                <label id="limitUpdateLabel" for="limitUpdateValue">QBT_TR(Limit:)QBT_TR[CONTEXT=SpeedLimit]</label>
+                <input type="text" id="limitUpdateValue" size="6" placeholder="∞" style="text-align: center;">
+                <span id="limitUnit">QBT_TR(KiB/s)QBT_TR[CONTEXT=SpeedLimit]</span>
+            </div>
+            <input type="range" id="limitSliderInput" min="0" value="0" style="width: 100%;" aria-label="QBT_TR(Speed limit)QBT_TR[CONTEXT=SpeedLimit]">
+        </div>
+        <input type="button" id="applyButton" value="QBT_TR(Apply)QBT_TR[CONTEXT=HttpServer]">
+    </div>
 </body>
 
 </html>
diff --git a/src/webui/www/private/upload.html b/src/webui/www/private/upload.html
index ff5340536..1a89cffe1 100644
--- a/src/webui/www/private/upload.html
+++ b/src/webui/www/private/upload.html
@@ -10,6 +10,34 @@
     <script defer src="scripts/color-scheme.js?v=${CACHEID}"></script>
     <script defer src="scripts/download.js?v=${CACHEID}"></script>
     <script defer src="scripts/pathAutofill.js?v=${CACHEID}"></script>
+    <script>
+        "use strict";
+
+        window.addEventListener("DOMContentLoaded", (event) => {
+            let submitted = false;
+
+            document.getElementById("uploadForm").addEventListener("submit", (event) => {
+                document.getElementById("startTorrentHidden").value = document.getElementById("startTorrent").checked ? "false" : "true";
+
+                document.getElementById("dlLimitHidden").value = Number(document.getElementById("dlLimitText").value) * 1024;
+                document.getElementById("upLimitHidden").value = Number(document.getElementById("upLimitText").value) * 1024;
+
+                document.getElementById("upload_spinner").style.display = "block";
+                submitted = true;
+            });
+
+            document.getElementById("upload_frame").addEventListener("load", (event) => {
+                if (submitted)
+                    window.parent.qBittorrent.Client.closeFrameWindow(window);
+            });
+
+            const userAgent = (navigator.userAgentData?.platform ?? navigator.platform).toLowerCase();
+            if (userAgent.includes("ipad") || userAgent.includes("iphone") || (userAgent.includes("mac") && (navigator.maxTouchPoints > 1)))
+                document.getElementById("fileselect").accept = ".torrent";
+
+            window.qBittorrent.pathAutofill.attachPathAutofill();
+        });
+    </script>
 </head>
 
 <body>
@@ -153,35 +181,6 @@
         </fieldset>
     </form>
     <div id="upload_spinner" class="mochaSpinner"></div>
-
-    <script>
-        "use strict";
-
-        window.addEventListener("DOMContentLoaded", (event) => {
-            let submitted = false;
-
-            document.getElementById("uploadForm").addEventListener("submit", (event) => {
-                document.getElementById("startTorrentHidden").value = document.getElementById("startTorrent").checked ? "false" : "true";
-
-                document.getElementById("dlLimitHidden").value = Number(document.getElementById("dlLimitText").value) * 1024;
-                document.getElementById("upLimitHidden").value = Number(document.getElementById("upLimitText").value) * 1024;
-
-                document.getElementById("upload_spinner").style.display = "block";
-                submitted = true;
-            });
-
-            document.getElementById("upload_frame").addEventListener("load", (event) => {
-                if (submitted)
-                    window.parent.qBittorrent.Client.closeFrameWindow(window);
-            });
-
-            const userAgent = (navigator.userAgentData?.platform ?? navigator.platform).toLowerCase();
-            if (userAgent.includes("ipad") || userAgent.includes("iphone") || (userAgent.includes("mac") && (navigator.maxTouchPoints > 1)))
-                document.getElementById("fileselect").accept = ".torrent";
-
-            window.qBittorrent.pathAutofill.attachPathAutofill();
-        });
-    </script>
 </body>
 
 </html>