github/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent synced 2025-08-20 21:33:27 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Apply suggestions from code review

Browse source
This commit is contained in:
Vladimir Golovnev 2025-06-10 20:53:26 +03:00 • committed by GitHub
commit 3b4b11cb21
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 8 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/base/bittorrent/bencoderesumedatastorage.cpp
View file

@ -191,12 +191,12 @@ void BitTorrent::BencodeResumeDataStorage::loadQueue(const Path &queueFilename)
QHash<TorrentID, qsizetype> registeredTorrentsIndexes; QHash<TorrentID, qsizetype> registeredTorrentsIndexes;
registeredTorrentsIndexes.reserve(m_registeredTorrents.length()); registeredTorrentsIndexes.reserve(m_registeredTorrents.length());
qsizetype i = 0; qsizetype i = -1;
for (const TorrentID &torrentID : asConst(m_registeredTorrents)) for (const TorrentID &torrentID : asConst(m_registeredTorrents))
registeredTorrentsIndexes.insert(torrentID, i++); registeredTorrentsIndexes.insert(torrentID, ++i);
const QRegularExpression hashPattern {u"^([A-Fa-f0-9]{40})$"_s}; const QRegularExpression hashPattern {u"^([A-Fa-f0-9]{40})$"_s};
qsizetype start = 0; qsizetype queuePos = 0;
while (true) while (true)
{ {
const auto line = QString::fromLatin1(queueFile.readLine(lineMaxLength).trimmed()); const auto line = QString::fromLatin1(queueFile.readLine(lineMaxLength).trimmed());
@ -210,11 +210,12 @@ void BitTorrent::BencodeResumeDataStorage::loadQueue(const Path &queueFilename)
const qsizetype pos = registeredTorrentsIndexes.value(torrentID, -1); const qsizetype pos = registeredTorrentsIndexes.value(torrentID, -1);
if (pos != -1) if (pos != -1)
{ {
if (start != pos) { if (pos != queuePos)
std::swap(m_registeredTorrents[start], m_registeredTorrents[pos]); {
registeredTorrentsIndexes.insert(torrentID, start); m_registeredTorrents.swapItemsAt(pos, queuePos);
registeredTorrentsIndexes.insert(torrentID, queuePos);
} }
++start; ++queuePos;
} }
} }
} }