diff --git a/src/base/bittorrent/session.cpp b/src/base/bittorrent/session.cpp index 5a88763fc..257ed3232 100644 --- a/src/base/bittorrent/session.cpp +++ b/src/base/bittorrent/session.cpp @@ -34,13 +34,16 @@ #include #include -#include +#ifdef Q_OS_WIN +#include +#include +#endif + #include #include #include #include #include -#include #include #include #include @@ -50,12 +53,10 @@ #include #include #include -#include #include #include #include #include -#include #include #include #include @@ -78,7 +79,6 @@ #include "base/utils/misc.h" #include "base/utils/net.h" #include "base/utils/random.h" -#include "base/utils/string.h" #include "magneturi.h" #include "private/bandwidthscheduler.h" #include "private/filterparserthread.h" @@ -89,11 +89,6 @@ #include "tracker.h" #include "trackerentry.h" -#ifdef Q_OS_WIN -#include -#include -#endif - #if defined(Q_OS_WIN) && (_WIN32_WINNT < 0x0600) using NETIO_STATUS = LONG; #endif diff --git a/src/base/bittorrent/session.h b/src/base/bittorrent/session.h index 89d0179a9..87c8ec890 100644 --- a/src/base/bittorrent/session.h +++ b/src/base/bittorrent/session.h @@ -36,13 +36,9 @@ #include #include #include -#include #include #include #include -#include -#include -#include #include "base/settingvalue.h" #include "base/tristatebool.h" @@ -55,8 +51,8 @@ class QThread; class QTimer; -class QStringList; class QString; +class QStringList; class QUrl; class FilterParserThread; diff --git a/src/base/settingvalue.h b/src/base/settingvalue.h index 5ce8f3d8a..e3ff237c1 100644 --- a/src/base/settingvalue.h +++ b/src/base/settingvalue.h @@ -29,7 +29,6 @@ #ifndef SETTINGVALUE_H #define SETTINGVALUE_H -#include #include #include @@ -41,8 +40,6 @@ template class CachedSettingValue { - using ProxyFunc = std::function; - public: explicit CachedSettingValue(const char *keyName, const T &defaultValue = T()) : m_keyName(QLatin1String(keyName)) @@ -50,8 +47,11 @@ public: { } + // The signature of the ProxyFunc should be equivalent to the following: + // T proxyFunc(const T &a); + template explicit CachedSettingValue(const char *keyName, const T &defaultValue - , const ProxyFunc &proxyFunc) + , ProxyFunc proxyFunc) : m_keyName(QLatin1String(keyName)) , m_value(proxyFunc(loadValue(defaultValue))) { diff --git a/src/gui/torrentcategorydialog.cpp b/src/gui/torrentcategorydialog.cpp index 099696371..e7d269af9 100644 --- a/src/gui/torrentcategorydialog.cpp +++ b/src/gui/torrentcategorydialog.cpp @@ -28,7 +28,6 @@ #include "torrentcategorydialog.h" -#include #include #include "base/bittorrent/session.h" diff --git a/src/gui/torrentcontentmodel.cpp b/src/gui/torrentcontentmodel.cpp index 14c52ca54..1602834aa 100644 --- a/src/gui/torrentcontentmodel.cpp +++ b/src/gui/torrentcontentmodel.cpp @@ -34,7 +34,6 @@ #include #include #include -#include #if defined(Q_OS_WIN) #include diff --git a/src/webui/webapplication.cpp b/src/webui/webapplication.cpp index ef2202b1b..4e07bc499 100644 --- a/src/webui/webapplication.cpp +++ b/src/webui/webapplication.cpp @@ -537,7 +537,7 @@ void WebApplication::sessionStart() // remove outdated sessions const qint64 now = QDateTime::currentMSecsSinceEpoch() / 1000; - const QMap sessionsCopy {m_sessions}; + const QHash sessionsCopy {m_sessions}; for (const auto session : sessionsCopy) { if ((now - session->timestamp()) > INACTIVE_TIME) delete m_sessions.take(session->id()); diff --git a/src/webui/webapplication.h b/src/webui/webapplication.h index 1c38d65b8..e59e0d97f 100644 --- a/src/webui/webapplication.h +++ b/src/webui/webapplication.h @@ -30,7 +30,6 @@ #include #include -#include #include #include #include @@ -120,7 +119,7 @@ private: bool validateHostHeader(const QStringList &domains) const; // Persistent data - QMap m_sessions; + QHash m_sessions; // Current data WebSession *m_currentSession = nullptr; @@ -141,7 +140,7 @@ private: QByteArray data; QDateTime lastModified; }; - QMap m_translatedFiles; + QHash m_translatedFiles; QString m_currentLocale; QTranslator m_translator; bool m_translationFileLoaded = false;