github/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent synced 2025-08-20 21:33:27 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

SMTP: Fix edge case where nothing was sent when no authentication was needed. Relates to #1845.

Browse source
This commit is contained in:
sledgehammer999 2014-09-02 17:31:44 +03:00
commit 2a5393cf53
1 changed files with 8 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/smtp.cpp
View file

@ -397,6 +397,10 @@ void Smtp::authenticate()
// Skip authentication // Skip authentication
qDebug() << "Skipping authentication..."; qDebug() << "Skipping authentication...";
state = Authenticated; state = Authenticated;
// At this point the server will not send any response
// So fill the buffer with a fake one to pass the tests
// in readyRead()
buffer.push_front("250 QBT FAKE RESPONSE\r\n");
return; return;
} }
// AUTH extension is supported, check which // AUTH extension is supported, check which
@ -420,6 +424,10 @@ void Smtp::authenticate()
"we support [CRAM-MD5|PLAIN|LOGIN], skipping authentication, " "we support [CRAM-MD5|PLAIN|LOGIN], skipping authentication, "
"knowing it is likely to fail... Server Auth Modes: "+auth.join("|")); "knowing it is likely to fail... Server Auth Modes: "+auth.join("|"));
state = Authenticated; state = Authenticated;
// At this point the server will not send any response
// So fill the buffer with a fake one to pass the tests
// in readyRead()
buffer.push_front("250 QBT FAKE RESPONSE\r\n");
} }
} }