github/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent synced 2025-08-19 12:59:56 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Unify value loading paths

Browse source 
The idea is to try load every intermediate value from the base case and
then convert them to their respective type.
This commit is contained in:
Chocobo1 2021-12-07 14:11:53 +08:00
commit 1c52fff1cc
No known key found for this signature in database
GPG key ID: 210D9C873253A68C
1 changed files with 8 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/base/settingsstorage.h
View file

@ -60,17 +60,18 @@ public:
{ {
if constexpr (std::is_enum_v<T>) if constexpr (std::is_enum_v<T>)
{ {
const auto value = loadValueImpl(key).toString(); const auto value = loadValue<QString>(key);
return Utils::String::toEnum(value, defaultValue); return Utils::String::toEnum(value, defaultValue);
} }
else if constexpr (std::is_same_v<T, QVariant>)
{
return loadValueImpl(key, defaultValue);
}
else if constexpr (IsQFlags<T>::value) else if constexpr (IsQFlags<T>::value)
{ {
const QVariant value = loadValueImpl(key, static_cast<typename T::Int>(defaultValue)); const typename T::Int value = loadValue(key, static_cast<typename T::Int>(defaultValue));
return T {value.template value<typename T::Int>()}; return T {value};
}
else if constexpr (std::is_same_v<T, QVariant>)
{
// fast path for loading QVariant
return loadValueImpl(key, defaultValue);
} }
else else
{ {