From 4d5512dccad180471eab8b16f50cc79e1183da61 Mon Sep 17 00:00:00 2001
From: Chocobo1 <Chocobo1@users.noreply.github.com>
Date: Sun, 21 Jun 2015 13:20:19 +0800
Subject: [PATCH 1/6] Reorder layout in information box

---
 src/gui/properties/propertieswidget.ui | 74 +++++++++++++-------------
 1 file changed, 37 insertions(+), 37 deletions(-)

diff --git a/src/gui/properties/propertieswidget.ui b/src/gui/properties/propertieswidget.ui
index 59276403d..696e8662b 100644
--- a/src/gui/properties/propertieswidget.ui
+++ b/src/gui/properties/propertieswidget.ui
@@ -686,6 +686,35 @@
                 </property>
                </widget>
               </item>
+              <item row="0" column="4">
+               <widget class="QLabel" name="label_created_by">
+                <property name="sizePolicy">
+                 <sizepolicy hsizetype="Minimum" vsizetype="Preferred">
+                  <horstretch>0</horstretch>
+                  <verstretch>0</verstretch>
+                 </sizepolicy>
+                </property>
+                <property name="text">
+                 <string>Created By:</string>
+                </property>
+                <property name="alignment">
+                 <set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set>
+                </property>
+               </widget>
+              </item>
+              <item row="0" column="5">
+               <widget class="QLabel" name="label_created_by_val">
+                <property name="sizePolicy">
+                 <sizepolicy hsizetype="Expanding" vsizetype="Preferred">
+                  <horstretch>0</horstretch>
+                  <verstretch>0</verstretch>
+                 </sizepolicy>
+                </property>
+                <property name="text">
+                 <string notr="true"/>
+                </property>
+               </widget>
+              </item>
               <item row="1" column="0">
                <widget class="QLabel" name="label_added_on">
                 <property name="sizePolicy">
@@ -744,7 +773,7 @@
                 </property>
                </widget>
               </item>
-              <item row="2" column="0">
+              <item row="1" column="4">
                <widget class="QLabel" name="label_9">
                 <property name="sizePolicy">
                  <sizepolicy hsizetype="Minimum" vsizetype="Preferred">
@@ -760,7 +789,7 @@
                 </property>
                </widget>
               </item>
-              <item row="2" column="1">
+              <item row="1" column="5">
                <widget class="QLabel" name="lbl_creationDate">
                 <property name="sizePolicy">
                  <sizepolicy hsizetype="Expanding" vsizetype="Preferred">
@@ -773,36 +802,7 @@
                 </property>
                </widget>
               </item>
-              <item row="2" column="2">
-               <widget class="QLabel" name="label_created_by">
-                <property name="sizePolicy">
-                 <sizepolicy hsizetype="Minimum" vsizetype="Preferred">
-                  <horstretch>0</horstretch>
-                  <verstretch>0</verstretch>
-                 </sizepolicy>
-                </property>
-                <property name="text">
-                 <string>Created By:</string>
-                </property>
-                <property name="alignment">
-                 <set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set>
-                </property>
-               </widget>
-              </item>
-              <item row="2" column="3">
-               <widget class="QLabel" name="label_created_by_val">
-                <property name="sizePolicy">
-                 <sizepolicy hsizetype="Expanding" vsizetype="Preferred">
-                  <horstretch>0</horstretch>
-                  <verstretch>0</verstretch>
-                 </sizepolicy>
-                </property>
-                <property name="text">
-                 <string notr="true"/>
-                </property>
-               </widget>
-              </item>
-              <item row="3" column="0">
+              <item row="2" column="0">
                <widget class="QLabel" name="hash_lbl2">
                 <property name="sizePolicy">
                  <sizepolicy hsizetype="Minimum" vsizetype="Preferred">
@@ -818,7 +818,7 @@
                 </property>
                </widget>
               </item>
-              <item row="3" column="1" colspan="3">
+              <item row="2" column="1" colspan="5">
                <widget class="QLabel" name="hash_lbl">
                 <property name="sizePolicy">
                  <sizepolicy hsizetype="Expanding" vsizetype="Preferred">
@@ -834,7 +834,7 @@
                 </property>
                </widget>
               </item>
-              <item row="4" column="0">
+              <item row="3" column="0">
                <widget class="QLabel" name="savePath_lbl">
                 <property name="sizePolicy">
                  <sizepolicy hsizetype="Minimum" vsizetype="Preferred">
@@ -850,7 +850,7 @@
                 </property>
                </widget>
               </item>
-              <item row="4" column="1" colspan="3">
+              <item row="3" column="1" colspan="5">
                <widget class="QLabel" name="save_path">
                 <property name="sizePolicy">
                  <sizepolicy hsizetype="Expanding" vsizetype="Preferred">
@@ -866,7 +866,7 @@
                 </property>
                </widget>
               </item>
-              <item row="5" column="0">
+              <item row="4" column="0">
                <widget class="QLabel" name="comment_lbl2">
                 <property name="sizePolicy">
                  <sizepolicy hsizetype="Minimum" vsizetype="Preferred">
@@ -882,7 +882,7 @@
                 </property>
                </widget>
               </item>
-              <item row="5" column="1" colspan="3">
+              <item row="4" column="1" colspan="5">
                <widget class="QTextBrowser" name="comment_text">
                 <property name="sizePolicy">
                  <sizepolicy hsizetype="Expanding" vsizetype="Expanding">

From 50b3a243716087daea9f753f68687294812a614c Mon Sep 17 00:00:00 2001
From: Chocobo1 <Chocobo1@users.noreply.github.com>
Date: Sun, 21 Jun 2015 13:44:06 +0800
Subject: [PATCH 2/6] Change Comment field from QTextBrowser to QLabel

---
 src/gui/properties/propertieswidget.cpp |  2 +-
 src/gui/properties/propertieswidget.ui  | 13 +++++++++++--
 2 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/src/gui/properties/propertieswidget.cpp b/src/gui/properties/propertieswidget.cpp
index d4eab984c..3c19601e7 100644
--- a/src/gui/properties/propertieswidget.cpp
+++ b/src/gui/properties/propertieswidget.cpp
@@ -280,7 +280,7 @@ void PropertiesWidget::loadTorrentInfos(BitTorrent::TorrentHandle *const torrent
       label_total_size_val->setText(Utils::Misc::friendlyUnit(m_torrent->totalSize()));
 
       // Comment
-      comment_text->setHtml(Utils::Misc::parseHtmlLinks(m_torrent->comment()));
+      comment_text->setText(Utils::Misc::parseHtmlLinks(m_torrent->comment()));
 
       // URL seeds
       loadUrlSeeds();
diff --git a/src/gui/properties/propertieswidget.ui b/src/gui/properties/propertieswidget.ui
index 696e8662b..0a001e16c 100644
--- a/src/gui/properties/propertieswidget.ui
+++ b/src/gui/properties/propertieswidget.ui
@@ -883,17 +883,26 @@
                </widget>
               </item>
               <item row="4" column="1" colspan="5">
-               <widget class="QTextBrowser" name="comment_text">
+               <widget class="QLabel" name="comment_text">
                 <property name="sizePolicy">
                  <sizepolicy hsizetype="Expanding" vsizetype="Expanding">
                   <horstretch>0</horstretch>
                   <verstretch>0</verstretch>
                  </sizepolicy>
                 </property>
+                <property name="textFormat">
+                 <enum>Qt::RichText</enum>
+                </property>
+                <property name="alignment">
+                 <set>Qt::AlignLeading|Qt::AlignLeft|Qt::AlignTop</set>
+                </property>
                 <property name="openExternalLinks">
                  <bool>true</bool>
                 </property>
-                <property name="openLinks">
+                <property name="textInteractionFlags">
+                 <set>Qt::TextBrowserInteraction</set>
+                </property>
+                <property name="openLinks" stdset="0">
                  <bool>true</bool>
                 </property>
                </widget>

From 661ddd75b6074be8ac443e257ebd612c4f3fa220 Mon Sep 17 00:00:00 2001
From: Chocobo1 <Chocobo1@users.noreply.github.com>
Date: Mon, 22 Jun 2015 13:32:32 +0800
Subject: [PATCH 3/6] Allow wordWrap for "Save Path" & "Comment"

---
 src/gui/properties/propertieswidget.ui | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/gui/properties/propertieswidget.ui b/src/gui/properties/propertieswidget.ui
index 0a001e16c..2434fe685 100644
--- a/src/gui/properties/propertieswidget.ui
+++ b/src/gui/properties/propertieswidget.ui
@@ -846,7 +846,7 @@
                  <string>Save Path:</string>
                 </property>
                 <property name="alignment">
-                 <set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set>
+                 <set>Qt::AlignRight|Qt::AlignTop|Qt::AlignTrailing</set>
                 </property>
                </widget>
               </item>
@@ -861,6 +861,9 @@
                 <property name="text">
                  <string notr="true"/>
                 </property>
+                <property name="wordWrap">
+                 <bool>true</bool>
+                </property>
                 <property name="textInteractionFlags">
                  <set>Qt::TextSelectableByMouse</set>
                 </property>
@@ -896,6 +899,9 @@
                 <property name="alignment">
                  <set>Qt::AlignLeading|Qt::AlignLeft|Qt::AlignTop</set>
                 </property>
+                <property name="wordWrap">
+                 <bool>true</bool>
+                </property>
                 <property name="openExternalLinks">
                  <bool>true</bool>
                 </property>

From b318f54fdfdafb35fb1757aac02a0f7bd7cb5657 Mon Sep 17 00:00:00 2001
From: Chocobo1 <Chocobo1@users.noreply.github.com>
Date: Mon, 22 Jun 2015 13:42:24 +0800
Subject: [PATCH 4/6] Force set "plain text" format to reduce attack vector.

---
 src/gui/properties/propertieswidget.ui | 80 +++++++++++++++++++++++++-
 1 file changed, 79 insertions(+), 1 deletion(-)

diff --git a/src/gui/properties/propertieswidget.ui b/src/gui/properties/propertieswidget.ui
index 2434fe685..55e899498 100644
--- a/src/gui/properties/propertieswidget.ui
+++ b/src/gui/properties/propertieswidget.ui
@@ -98,6 +98,9 @@
                <property name="text">
                 <string notr="true"/>
                </property>
+               <property name="textFormat">
+                <enum>Qt::PlainText</enum>
+               </property>
                <property name="alignment">
                 <set>Qt::AlignLeading</set>
                </property>
@@ -138,7 +141,7 @@
              <item>
               <widget class="QLabel" name="avail_average_lbl">
                <property name="sizePolicy">
-                <sizepolicy hsizetype="Minimum" vsizetype="Preferred">
+                <sizepolicy hsizetype="Minimum" vsizetype="Fixed">
                  <horstretch>0</horstretch>
                  <verstretch>0</verstretch>
                 </sizepolicy>
@@ -152,6 +155,9 @@
                <property name="text">
                 <string notr="true"/>
                </property>
+               <property name="textFormat">
+                <enum>Qt::PlainText</enum>
+               </property>
                <property name="alignment">
                 <set>Qt::AlignLeading</set>
                </property>
@@ -205,6 +211,9 @@
                 <property name="text">
                  <string notr="true"/>
                 </property>
+                <property name="textFormat">
+                 <enum>Qt::PlainText</enum>
+                </property>
                </widget>
               </item>
               <item row="0" column="2">
@@ -234,6 +243,9 @@
                 <property name="text">
                  <string notr="true"/>
                 </property>
+                <property name="textFormat">
+                 <enum>Qt::PlainText</enum>
+                </property>
                </widget>
               </item>
               <item row="0" column="4">
@@ -263,6 +275,9 @@
                 <property name="text">
                  <string notr="true"/>
                 </property>
+                <property name="textFormat">
+                 <enum>Qt::PlainText</enum>
+                </property>
                </widget>
               </item>
               <item row="1" column="0">
@@ -292,6 +307,9 @@
                 <property name="text">
                  <string notr="true"/>
                 </property>
+                <property name="textFormat">
+                 <enum>Qt::PlainText</enum>
+                </property>
                </widget>
               </item>
               <item row="1" column="2">
@@ -321,6 +339,9 @@
                 <property name="text">
                  <string notr="true"/>
                 </property>
+                <property name="textFormat">
+                 <enum>Qt::PlainText</enum>
+                </property>
                </widget>
               </item>
               <item row="1" column="4">
@@ -350,6 +371,9 @@
                 <property name="text">
                  <string notr="true"/>
                 </property>
+                <property name="textFormat">
+                 <enum>Qt::PlainText</enum>
+                </property>
                </widget>
               </item>
               <item row="2" column="0">
@@ -379,6 +403,9 @@
                 <property name="text">
                  <string notr="true"/>
                 </property>
+                <property name="textFormat">
+                 <enum>Qt::PlainText</enum>
+                </property>
                </widget>
               </item>
               <item row="2" column="2">
@@ -408,6 +435,9 @@
                 <property name="text">
                  <string notr="true"/>
                 </property>
+                <property name="textFormat">
+                 <enum>Qt::PlainText</enum>
+                </property>
                </widget>
               </item>
               <item row="2" column="4">
@@ -437,6 +467,9 @@
                 <property name="text">
                  <string notr="true"/>
                 </property>
+                <property name="textFormat">
+                 <enum>Qt::PlainText</enum>
+                </property>
                </widget>
               </item>
               <item row="3" column="0">
@@ -466,6 +499,9 @@
                 <property name="text">
                  <string notr="true"/>
                 </property>
+                <property name="textFormat">
+                 <enum>Qt::PlainText</enum>
+                </property>
                </widget>
               </item>
               <item row="3" column="2">
@@ -495,6 +531,9 @@
                 <property name="text">
                  <string notr="true"/>
                 </property>
+                <property name="textFormat">
+                 <enum>Qt::PlainText</enum>
+                </property>
                </widget>
               </item>
               <item row="3" column="4">
@@ -524,6 +563,9 @@
                 <property name="text">
                  <string notr="true"/>
                 </property>
+                <property name="textFormat">
+                 <enum>Qt::PlainText</enum>
+                </property>
                </widget>
               </item>
               <item row="4" column="0">
@@ -553,6 +595,9 @@
                 <property name="text">
                  <string notr="true"/>
                 </property>
+                <property name="textFormat">
+                 <enum>Qt::PlainText</enum>
+                </property>
                </widget>
               </item>
               <item row="4" column="2">
@@ -582,6 +627,9 @@
                 <property name="text">
                  <string notr="true"/>
                 </property>
+                <property name="textFormat">
+                 <enum>Qt::PlainText</enum>
+                </property>
                </widget>
               </item>
               <item row="4" column="4">
@@ -611,6 +659,9 @@
                 <property name="text">
                  <string notr="true"/>
                 </property>
+                <property name="textFormat">
+                 <enum>Qt::PlainText</enum>
+                </property>
                </widget>
               </item>
              </layout>
@@ -655,6 +706,9 @@
                 <property name="text">
                  <string notr="true"/>
                 </property>
+                <property name="textFormat">
+                 <enum>Qt::PlainText</enum>
+                </property>
                </widget>
               </item>
               <item row="0" column="2">
@@ -684,6 +738,9 @@
                 <property name="text">
                  <string notr="true"/>
                 </property>
+                <property name="textFormat">
+                 <enum>Qt::PlainText</enum>
+                </property>
                </widget>
               </item>
               <item row="0" column="4">
@@ -713,6 +770,9 @@
                 <property name="text">
                  <string notr="true"/>
                 </property>
+                <property name="textFormat">
+                 <enum>Qt::PlainText</enum>
+                </property>
                </widget>
               </item>
               <item row="1" column="0">
@@ -742,6 +802,9 @@
                 <property name="text">
                  <string notr="true"/>
                 </property>
+                <property name="textFormat">
+                 <enum>Qt::PlainText</enum>
+                </property>
                </widget>
               </item>
               <item row="1" column="2">
@@ -771,6 +834,9 @@
                 <property name="text">
                  <string notr="true"/>
                 </property>
+                <property name="textFormat">
+                 <enum>Qt::PlainText</enum>
+                </property>
                </widget>
               </item>
               <item row="1" column="4">
@@ -800,6 +866,9 @@
                 <property name="text">
                  <string notr="true"/>
                 </property>
+                <property name="textFormat">
+                 <enum>Qt::PlainText</enum>
+                </property>
                </widget>
               </item>
               <item row="2" column="0">
@@ -829,6 +898,9 @@
                 <property name="text">
                  <string notr="true"/>
                 </property>
+                <property name="textFormat">
+                 <enum>Qt::PlainText</enum>
+                </property>
                 <property name="textInteractionFlags">
                  <set>Qt::TextSelectableByMouse</set>
                 </property>
@@ -861,6 +933,12 @@
                 <property name="text">
                  <string notr="true"/>
                 </property>
+                <property name="textFormat">
+                 <enum>Qt::PlainText</enum>
+                </property>
+                <property name="alignment">
+                 <set>Qt::AlignLeading|Qt::AlignLeft|Qt::AlignTop</set>
+                </property>
                 <property name="wordWrap">
                  <bool>true</bool>
                 </property>

From 9d5cfbcda9ed284af932d5e12df8391a5bd340fb Mon Sep 17 00:00:00 2001
From: Chocobo1 <Chocobo1@users.noreply.github.com>
Date: Wed, 24 Jun 2015 18:49:31 +0800
Subject: [PATCH 5/6] Preserve plain text formatting

---
 src/core/utils/misc.cpp | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/core/utils/misc.cpp b/src/core/utils/misc.cpp
index ae4840ae2..fa0df81e4 100644
--- a/src/core/utils/misc.cpp
+++ b/src/core/utils/misc.cpp
@@ -467,6 +467,8 @@ QString Utils::Misc::parseHtmlLinks(const QString &raw_text)
     static QRegExp reNoScheme("<a\\s+href=\"(?!http(s?))([a-zA-Z0-9\\?%=&/_\\.-:#]+)\\s*\">");
     result.replace(reNoScheme, "<a href=\"http://\\1\">");
 
+    // to preserve plain text formatting
+    result = "<p style=\"white-space: pre-wrap;\">" + result + "</p>";
     return result;
 }
 

From 776d91f663094512a73a0c775e47e8c76b36716f Mon Sep 17 00:00:00 2001
From: Chocobo1 <Chocobo1@users.noreply.github.com>
Date: Sun, 28 Jun 2015 18:15:17 +0800
Subject: [PATCH 6/6] Add connectionsLimit() back

---
 src/gui/properties/propertieswidget.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gui/properties/propertieswidget.cpp b/src/gui/properties/propertieswidget.cpp
index 3c19601e7..1ef29e7f7 100644
--- a/src/gui/properties/propertieswidget.cpp
+++ b/src/gui/properties/propertieswidget.cpp
@@ -363,7 +363,7 @@ void PropertiesWidget::loadDynamicData() {
 
         lbl_elapsed->setText(elapsed_txt);
 
-        lbl_connections->setText(QString::number(m_torrent->connectionsCount()));
+        lbl_connections->setText(QString::number(m_torrent->connectionsCount()) + " (" + tr("%1 max", "e.g. 10 max").arg(QString::number(m_torrent->connectionsLimit())) + ")");
         label_eta_val->setText(Utils::Misc::userFriendlyDuration(m_torrent->eta()));
 
         // Update next announce time