github/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent synced 2025-08-20 13:23:34 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Use efficient algorithm for removing entries

Browse source 
PR #19345.
This commit is contained in:
Chocobo1 2023-07-21 12:18:26 +08:00 • committed by GitHub
commit 0f862fcf9f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

29
src/base/net/downloadmanager.cpp
View file

@ -42,6 +42,7 @@
#include <QSslError> #include <QSslError>
#include <QUrl> #include <QUrl>
#include "base/algorithm.h"
#include "base/global.h" #include "base/global.h"
#include "base/logger.h" #include "base/logger.h"
#include "base/preferences.h" #include "base/preferences.h"
@ -62,11 +63,10 @@ public:
{ {
const QDateTime now = QDateTime::currentDateTime(); const QDateTime now = QDateTime::currentDateTime();
QList<QNetworkCookie> cookies = Preferences::instance()->getNetworkCookies(); QList<QNetworkCookie> cookies = Preferences::instance()->getNetworkCookies();
for (const QNetworkCookie &cookie : asConst(Preferences::instance()->getNetworkCookies())) Algorithm::removeIf(cookies, [&now](const QNetworkCookie &cookie)
{ {
if (cookie.isSessionCookie() || (cookie.expirationDate() <= now)) return cookie.isSessionCookie() || (cookie.expirationDate() <= now);
cookies.removeAll(cookie); });
}
setAllCookies(cookies); setAllCookies(cookies);
} }
@ -75,11 +75,10 @@ public:
{ {
const QDateTime now = QDateTime::currentDateTime(); const QDateTime now = QDateTime::currentDateTime();
QList<QNetworkCookie> cookies = allCookies(); QList<QNetworkCookie> cookies = allCookies();
for (const QNetworkCookie &cookie : asConst(allCookies())) Algorithm::removeIf(cookies, [&now](const QNetworkCookie &cookie)
{ {
if (cookie.isSessionCookie() || (cookie.expirationDate() <= now)) return cookie.isSessionCookie() || (cookie.expirationDate() <= now);
cookies.removeAll(cookie); });
}
Preferences::instance()->setNetworkCookies(cookies); Preferences::instance()->setNetworkCookies(cookies);
} }
@ -91,11 +90,10 @@ public:
{ {
const QDateTime now = QDateTime::currentDateTime(); const QDateTime now = QDateTime::currentDateTime();
QList<QNetworkCookie> cookies = QNetworkCookieJar::cookiesForUrl(url); QList<QNetworkCookie> cookies = QNetworkCookieJar::cookiesForUrl(url);
for (const QNetworkCookie &cookie : asConst(QNetworkCookieJar::cookiesForUrl(url))) Algorithm::removeIf(cookies, [&now](const QNetworkCookie &cookie)
{ {
if (!cookie.isSessionCookie() && (cookie.expirationDate() <= now)) return !cookie.isSessionCookie() && (cookie.expirationDate() <= now);
cookies.removeAll(cookie); });
}
return cookies; return cookies;
} }
@ -104,11 +102,10 @@ public:
{ {
const QDateTime now = QDateTime::currentDateTime(); const QDateTime now = QDateTime::currentDateTime();
QList<QNetworkCookie> cookies = cookieList; QList<QNetworkCookie> cookies = cookieList;
for (const QNetworkCookie &cookie : cookieList) Algorithm::removeIf(cookies, [&now](const QNetworkCookie &cookie)
{ {
if (!cookie.isSessionCookie() && (cookie.expirationDate() <= now)) return !cookie.isSessionCookie() && (cookie.expirationDate() <= now);
cookies.removeAll(cookie); });
}
return QNetworkCookieJar::setCookiesFromUrl(cookies, url); return QNetworkCookieJar::setCookiesFromUrl(cookies, url);
} }