github/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent synced 2025-07-13 00:33:09 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Don't create temporary substrings

Browse source 
Avoid temporary string allocations. They are only used to convert to
something else.
QString::xxxRef() returns a QStringRef. QStringRef avoids the memory
allocation and reference counting overhead of a standard QString by simply
referencing a part of the original string.
This commit is contained in:
Luís Pereira 2018-02-21 18:29:22 +00:00
parent edef85fa3e
commit 0e421ae415
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/app/application.cpp
View file

@ -401,7 +401,7 @@ void Application::processParams(const QStringList &params)
} }
if (param.startsWith(QLatin1String("@addPaused="))) { if (param.startsWith(QLatin1String("@addPaused="))) {
torrentParams.addPaused = param.mid(11).toInt() ? TriStateBool::True : TriStateBool::False; torrentParams.addPaused = param.midRef(11).toInt() ? TriStateBool::True : TriStateBool::False;
continue; continue;
} }
@ -426,7 +426,7 @@ void Application::processParams(const QStringList &params)
} }
if (param.startsWith(QLatin1String("@skipDialog="))) { if (param.startsWith(QLatin1String("@skipDialog="))) {
skipTorrentDialog = param.mid(12).toInt() ? TriStateBool::True : TriStateBool::False; skipTorrentDialog = param.midRef(12).toInt() ? TriStateBool::True : TriStateBool::False;
continue; continue;
} }

2
src/base/rss/rss_autodownloadrule.cpp
View file

@ -302,7 +302,7 @@ bool AutoDownloadRule::matches(const QString &articleTitle) const
QRegularExpression reg(cachedRegex(partialPattern1)); QRegularExpression reg(cachedRegex(partialPattern1));
if (ep.endsWith('-')) { // Infinite range if (ep.endsWith('-')) { // Infinite range
int epOurs = ep.left(ep.size() - 1).toInt(); int epOurs = ep.leftRef(ep.size() - 1).toInt();
// Extract partial match from article and compare as digits // Extract partial match from article and compare as digits
matcher = reg.match(articleTitle); matcher = reg.match(articleTitle);