From a77a6b5a8ba0835b40ce5af019144a81d489d9ac Mon Sep 17 00:00:00 2001 From: Konstantin Goncharik Date: Sun, 5 Jan 2014 19:41:58 +0800 Subject: [PATCH 1/2] In statsdialog.cpp fix initialization iEnd --- src/statsdialog.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/statsdialog.cpp b/src/statsdialog.cpp index 14459f6c4..e514e9fa7 100644 --- a/src/statsdialog.cpp +++ b/src/statsdialog.cpp @@ -85,7 +85,7 @@ void StatsDialog::updateUI() { // num_peers is not reliable (adds up peers, which didn't even overcome tcp handshake) const std::vector torrents = session->getTorrents(); std::vector::const_iterator iBegin = torrents.begin(); - std::vector::const_iterator iEnd = torrents.begin(); + std::vector::const_iterator iEnd = torrents.end(); quint32 peers = 0; for ( ; iBegin < iEnd ; ++iBegin) peers += (*iBegin).status().num_peers; From f29c04d935fac2748005e20567504b27fe9ba556 Mon Sep 17 00:00:00 2001 From: Konstantin Goncharik Date: Sun, 5 Jan 2014 20:06:29 +0800 Subject: [PATCH 2/2] In preferences.h now argument is const references --- src/preferences/preferences.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/preferences/preferences.h b/src/preferences/preferences.h index d8b0c9d20..62a46cb2a 100755 --- a/src/preferences/preferences.h +++ b/src/preferences/preferences.h @@ -894,7 +894,7 @@ public: return value("Preferences/DynDNS/DomainName", "changeme.dyndns.org").toString(); } - void setDynDomainName(const QString name) { + void setDynDomainName(const QString &name) { setValue("Preferences/DynDNS/DomainName", name); } @@ -902,7 +902,7 @@ public: return value("Preferences/DynDNS/Username").toString(); } - void setDynDNSUsername(const QString username) { + void setDynDNSUsername(const QString &username) { setValue("Preferences/DynDNS/Username", username); } @@ -910,7 +910,7 @@ public: return value("Preferences/DynDNS/Password").toString(); } - void setDynDNSPassword(const QString password) { + void setDynDNSPassword(const QString &password) { setValue("Preferences/DynDNS/Password", password); }