Use proper macro for unreachable switch cases

Those are the `default` cases which are not expected to hit (nor reachable) normally.

When the code is compiled with release mode and it reaches `Q_UNREACHABLE()`, it becomes
undefined behavior. So it rely on the developers to catch the errors in debug mode.
The upside of this is that the `switch` statement will be more optimized than not using it.
This also means the statements after `Q_UNREACHABLE()` isn't important. It allow anything to
preserve the intention of the code.

This macro is preferred over C++23 `std::unreachable` because it will automatically insert a
`Q_ASSERT(false)` with it.

PR #21752.

src/base/bittorrent/bandwidthscheduler.cpp

@@ -102,7 +102,7 @@ bool BandwidthScheduler::isTimeForAlternative() const
                 alternative = !alternative;
             break;
         default:
-            Q_ASSERT(false);
+            Q_UNREACHABLE();
             break;
         }
     }

src/base/bittorrent/sessionimpl.cpp

@@ -296,14 +296,15 @@ namespace
     {
         switch (mode)
         {
-        default:
-            Q_ASSERT(false);
         case MoveStorageMode::FailIfExist:
             return lt::move_flags_t::fail_if_exist;
         case MoveStorageMode::KeepExistingFiles:
             return lt::move_flags_t::dont_replace;
         case MoveStorageMode::Overwrite:
             return lt::move_flags_t::always_replace_files;
+        default:
+            Q_UNREACHABLE();
+            break;
         }
     }
 }

src/base/http/connection.cpp

@@ -160,7 +160,7 @@ void Connection::read()
             break;
 
         default:
-            Q_ASSERT(false);
+            Q_UNREACHABLE();
             return;
         }
     }

src/base/net/dnsupdater.cpp

@@ -153,7 +153,7 @@ QString DNSUpdater::getUpdateUrl() const
         break;
     default:
         qWarning() << "Unrecognized Dynamic DNS service!";
-        Q_ASSERT(false);
+        Q_UNREACHABLE();
         break;
     }
     url.setPath(u"/nic/update"_s);
@@ -305,7 +305,7 @@ QUrl DNSUpdater::getRegistrationUrl(const DNS::Service service)
     case DNS::Service::NoIP:
         return {u"https://www.noip.com/remote-access"_s};
     default:
-        Q_ASSERT(false);
+        Q_UNREACHABLE();
         break;
     }
     return {};

src/base/torrentfilter.cpp

@@ -205,9 +205,11 @@ bool TorrentFilter::matchState(const BitTorrent::Torrent *const torrent) const
     case Errored:
         return torrent->isErrored();
     default:
-        Q_ASSERT(false);
+        Q_UNREACHABLE();
-        return false;
+        break;
     }
+
+    return false;
 }
 
 bool TorrentFilter::matchHash(const BitTorrent::Torrent *const torrent) const

src/gui/advancedsettings.cpp

@@ -410,7 +410,7 @@ void AdvancedSettings::updateInterfaceAddressCombo()
         case QAbstractSocket::IPv6Protocol:
             return Utils::Net::canonicalIPv6Addr(address).toString();
         default:
-            Q_ASSERT(false);
+            Q_UNREACHABLE();
             break;
         }
         return {};

src/gui/torrentcontentmodelitem.cpp

@@ -140,9 +140,11 @@ QString TorrentContentModelItem::displayData(const int column) const
             return (value + u'%');
         }
     default:
-        Q_ASSERT(false);
+        Q_UNREACHABLE();
-        return {};
+        break;
     }
+
+    return {};
 }
 
 QVariant TorrentContentModelItem::underlyingData(const int column) const
@@ -165,9 +167,11 @@ QVariant TorrentContentModelItem::underlyingData(const int column) const
     case COL_AVAILABILITY:
         return availability();
     default:
-        Q_ASSERT(false);
+        Q_UNREACHABLE();
-        return {};
+        break;
     }
+
+    return {};
 }
 
 int TorrentContentModelItem::row() const

src/gui/transferlistmodel.cpp

@@ -775,7 +775,9 @@ QIcon TransferListModel::getIconByState(const BitTorrent::TorrentState state) co
     case BitTorrent::TorrentState::Error:
         return m_errorIcon;
     default:
-        Q_ASSERT(false);
+        Q_UNREACHABLE();
-        return m_errorIcon;
+        break;
     }
+
+    return {};
 }

src/webui/api/synccontroller.cpp

@@ -288,7 +288,7 @@ namespace
                     }
                     break;
                 default:
-                    Q_ASSERT(false);
+                    Q_UNREACHABLE();
                     break;
                 }
             }

src/webui/webapplication.cpp

@@ -396,7 +396,8 @@ void WebApplication::doProcessRequest()
         case APIErrorType::NotFound:
             throw NotFoundHTTPError(error.message());
         default:
-            Q_ASSERT(false);
+            Q_UNREACHABLE();
+            break;
         }
     }
 }