github/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent synced 2025-07-30 11:38:50 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Do not remove added files unconditionally. Closes #6248

Browse source 
If removing of added torrents is enabled and dialog for adding torrents
is disabled, file guard was assuming that torrent is added successfully.
And that can be not the case if a user trying to add a broken torrent
file (or not a torrent file at all). Then this file gets deleted always.

Fix this by checking result of addTorrent_impl().
This commit is contained in:
Eugene Shalygin 2017-01-17 22:55:01 +01:00 • committed by sledgehammer999
parent 7971a25c2a
commit 00d4f6141f
No known key found for this signature in database
GPG key ID: 6E4A2D025B7CC9A2
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/base/bittorrent/session.cpp
View file

@ -1576,8 +1576,10 @@ bool Session::addTorrent(QString source, const AddTorrentParams &params)
}
else {
TorrentFileGuard guard(source);
guard.markAsAddedToSession();
return addTorrent_impl(params, MagnetUri(), TorrentInfo::loadFromFile(source));
if (addTorrent_impl(params, MagnetUri(), TorrentInfo::loadFromFile(source))) {
guard.markAsAddedToSession();
return true;
}
}
return false;