github/proxmark3
1
0
Fork 0
mirror of https://github.com/Proxmark/proxmark3.git synced 2025-08-14 02:26:59 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

coverity scan bug fixes

Browse source 
mfu keyNo buffer overflow
mf reader attack key count reduced to not overrun c.d.asBytes buffer.
This commit is contained in:
marshmellow42 2017-06-06 12:12:18 -04:00
commit 3d542a3dfa
3 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
client/cmdhfmf.c
View file

@ -1120,7 +1120,8 @@ int CmdHF14AMfChk(const char *Cmd)
}
void readerAttack(nonces_t ar_resp[], bool setEmulatorMem, bool doStandardAttack) {
#define ATTACK_KEY_COUNT 8 // keep same as define in iso14443a.c -> Mifare1ksim()
#define ATTACK_KEY_COUNT 7 // keep same as define in iso14443a.c -> Mifare1ksim()
// cannot be more than 7 or it will overrun c.d.asBytes(512)
uint64_t key = 0;
typedef struct {
uint64_t keyA;

2
client/cmdhfmfu.c
View file

@ -1474,7 +1474,7 @@ int CmdHF14AMfucAuth(const char *Cmd){
//Change key to user defined one
if (cmdp == 'k' || cmdp == 'K'){
keyNo = param_get8(Cmd, 1);
if(keyNo > KEYS_3DES_COUNT)
if(keyNo > KEYS_3DES_COUNT-1)
errors = true;
}