github/proxmark3
1
0
Fork 0
mirror of https://github.com/Proxmark/proxmark3.git synced 2025-07-07 21:51:17 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix issue 14: mandemod and lf em4x em410xread crashes the proxmark3 client app

Browse source 
This fix is quick-and-dirty since it only reduces the amount of stackspace allocated by changing the data type of the array to uint8_t instead of the 32 bit integers. The reduced number of bits is OK since only (at most) 2 of the available bits are used in each element.

At least array bit utilization is improved from 6.66% to 25% :)

Large structures such as these should probably be malloc()ed.
This commit is contained in:
ksjoberg 2010-04-06 13:41:37 +00:00
parent 33bf54cf3d
commit 15cdabd474
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
client/cmddata.c
View file

@ -561,7 +561,7 @@ int CmdManchesterDemod(const char *Cmd)
/* But it does not work if compiling on WIndows: therefore we just allocate a */ /* But it does not work if compiling on WIndows: therefore we just allocate a */
/* large array */ /* large array */
int BitStream[MAX_GRAPH_TRACE_LEN]; uint8_t BitStream[MAX_GRAPH_TRACE_LEN];
/* Detect high and lows */ /* Detect high and lows */
for (i = 0; i < GraphTraceLen; i++) for (i = 0; i < GraphTraceLen; i++)

2
client/cmdlfem4x.c
View file

@ -34,7 +34,7 @@ int CmdEM410xRead(const char *Cmd)
int parity[4]; int parity[4];
char id[11]; char id[11];
int retested = 0; int retested = 0;
int BitStream[MAX_GRAPH_TRACE_LEN]; uint8_t BitStream[MAX_GRAPH_TRACE_LEN];
high = low = 0; high = low = 0;
/* Detect high and lows and clock */ /* Detect high and lows and clock */