github/proxmark3
1
0
Fork 0
mirror of https://github.com/Proxmark/proxmark3.git synced 2025-08-22 06:13:27 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

crypto1_create: initialize malloc()ed memory to 0

Browse source 
On systems that support malloc(), crypto1_create() allocates a new
struct Crypto1State and starts calculations without initializing the
allocated memory area.

At least on Linux, malloc(3) says that the allocated memory is not
initialized. Looking at the version for bare metal ARM, it seems that
the components of struct Crypto1State should be 0 initially. Add a
memset() call to initialize them.
This commit is contained in:
Martin Kaiser 2019-01-19 19:30:12 +01:00 • committed by Martin Kaiser
commit 02d5b18ef7
1 changed files with 1 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
common/crapto1/crypto1.c
View file

@ -47,6 +47,7 @@ struct Crypto1State * crypto1_create(uint64_t key)
struct Crypto1State *s = malloc(sizeof(*s)); struct Crypto1State *s = malloc(sizeof(*s));
int i; int i;
memset(s, 0x0, sizeof(*s));
for(i = 47;s && i > 0; i -= 2) { for(i = 47;s && i > 0; i -= 2) {
s->odd = s->odd << 1 | BIT(key, (i - 1) ^ 7); s->odd = s->odd << 1 | BIT(key, (i - 1) ^ 7);
s->even = s->even << 1 | BIT(key, i ^ 7); s->even = s->even << 1 | BIT(key, i ^ 7);