From 66d45293e6f629809b3ed3bba3e16112d0f4cf34 Mon Sep 17 00:00:00 2001
From: JonnyWong16 <JonnyWong16@users.noreply.github.com>
Date: Fri, 29 Dec 2017 10:47:31 -0800
Subject: [PATCH] Add test Plex Web URL button

---
 data/interfaces/default/info.html     |  4 +-
 data/interfaces/default/settings.html | 76 ++++++++++++++++++---------
 plexpy/notification_handler.py        |  2 +-
 3 files changed, 53 insertions(+), 29 deletions(-)

diff --git a/data/interfaces/default/info.html b/data/interfaces/default/info.html
index 3ae7ee2b..67c4ab67 100644
--- a/data/interfaces/default/info.html
+++ b/data/interfaces/default/info.html
@@ -116,9 +116,9 @@ DOCUMENTATION :: END
                 <div class="col-md-9">
                     <div class="summary-content-poster hidden-xs hidden-sm">
                         % if data['media_type'] == 'track':
-                        <a href="${config['pms_web_url'] or 'https://app.plex.tv/desktop'}#!/server/${config['pms_identifier']}/details?key=%2Flibrary%2Fmetadata%2F${data['parent_rating_key']}" target="_blank" title="View in Plex Web">
+                        <a href="${config['pms_web_url']}#!/server/${config['pms_identifier']}/details?key=%2Flibrary%2Fmetadata%2F${data['parent_rating_key']}" target="_blank" title="View in Plex Web">
                         % else:
-                        <a href="${config['pms_web_url'] or 'https://app.plex.tv/desktop'}#!/server/${config['pms_identifier']}/details?key=%2Flibrary%2Fmetadata%2F${data['rating_key']}" target="_blank" title="View in Plex Web">
+                        <a href="${config['pms_web_url']}#!/server/${config['pms_identifier']}/details?key=%2Flibrary%2Fmetadata%2F${data['rating_key']}" target="_blank" title="View in Plex Web">
                         % endif
                             % if data['media_type'] == 'episode':
                             <div class="summary-poster-face-episode" style="background-image: url(pms_image_proxy?img=${data['thumb']}&width=500&height=280&fallback=art);">
diff --git a/data/interfaces/default/settings.html b/data/interfaces/default/settings.html
index b1c5a0a1..dafae876 100644
--- a/data/interfaces/default/settings.html
+++ b/data/interfaces/default/settings.html
@@ -559,7 +559,7 @@
                             <p class="help-block">Enable to have Tautulli check if remote access to the Plex Media Server goes down.</p>
                         </div>
 
-                        <div class="form-group has-feedback" id="pms-ip-group">
+                        <div class="form-group has-feedback" id="pms_ip_group">
                             <label for="pms_ip">Plex IP or Hostname</label>
                             <div class="row">
                                 <div class="col-md-6">
@@ -569,7 +569,7 @@
                                             <button class="btn btn-form" type="button" id="verify_server_button">Verify Server</button>
                                         </span>
                                     </div>
-                                    <span class="form-control-feedback" id="pms-verify" aria-hidden="true" style="display: none; right: 110px;"></span>
+                                    <span class="form-control-feedback" id="pms_verify" aria-hidden="true" style="display: none; right: 110px;"></span>
                                 </div>
                                 <div id="pms_ip_error" class="alert alert-danger settings-alert" role="alert"></div>
                             </div>
@@ -607,7 +607,12 @@
                             <label for="pms_logs_folder">Plex Web URL</label>
                             <div class="row">
                                 <div class="col-md-6">
-                                    <input type="text" class="form-control" id="pms_web_url" name="pms_web_url" value="${config['pms_web_url']}" size="30" data-parsley-trigger="change" data-parsley-pattern="^https?:\/\/.+\/web\/index\.html$|^https:\/\/app.plex.tv\/desktop$" data-parsley-errors-container="#pms_web_url_error"  data-parsley-error-message="Invalid Plex Web URL." required>
+                                    <div class="input-group">
+                                        <input type="text" class="form-control" id="pms_web_url" name="pms_web_url" value="${config['pms_web_url']}" size="30" data-parsley-trigger="change" data-parsley-pattern="^https?:\/\/\S+$|^https:\/\/app.plex.tv\/desktop$" data-parsley-errors-container="#pms_web_url_error"  data-parsley-error-message="Invalid Plex Web URL.">
+                                        <span class="input-group-btn">
+                                            <button class="btn btn-form" type="button" id="test_pms_web_button">Test URL</button>
+                                        </span>
+                                    </div>
                                 </div>
                                 <div id="pms_web_url_error" class="alert alert-danger settings-alert" role="alert"></div>
                             </div>
@@ -1580,6 +1585,17 @@ $(document).ready(function() {
         }
     }
 
+    function preSaveChecks(_callback) {
+        if ($("#pms_identifier").val() == "") {
+            verifyServer();
+        }
+        verifyPMSWebURL();
+
+        if (_callback) {
+            _callback();
+        }
+    }
+
     // Alert the user that their changes require a restart.
     function postSaveChecks() {
         if (serverChanged || authChanged || httpChanged || directoryChanged) {
@@ -1609,11 +1625,7 @@ $(document).ready(function() {
     }
 
     $('.save-button').click(function() {
-        if ($("#pms_identifier").val() == "") {
-            verifyServer(function () { saveSettings() });
-        } else {
-            saveSettings();
-        }
+        preSaveChecks(function () { saveSettings() });
     });
 
     initConfigCheckbox('#api_enabled');
@@ -1758,43 +1770,45 @@ $(document).ready(function() {
         var pms_identifier = $("#pms_identifier").val();
         var pms_ssl = $("#pms_ssl").is(':checked') ? 1 : 0;
         var pms_is_remote = $("#pms_is_remote").is(':checked') ? 1 : 0;
+
         if (($("#pms_ip").val() !== '') || ($("#pms_port").val() !== '')) {
-            $("#pms-verify").html('<i class="fa fa-refresh fa-spin"></i>');
-            $('#pms-verify').fadeIn('fast');
+            $("#pms_verify").html('<i class="fa fa-refresh fa-spin"></i>').fadeIn('fast');
             $.ajax({
                 url: 'get_server_id',
-                data : { hostname: pms_ip, port: pms_port, identifier: pms_identifier, ssl: pms_ssl, remote: pms_is_remote },
+                data: {
+                    hostname: pms_ip,
+                    port: pms_port,
+                    identifier: pms_identifier,
+                    ssl: pms_ssl,
+                    remote: pms_is_remote
+                },
                 cache: true,
                 async: true,
                 timeout: 10000,
-                error: function(jqXHR, textStatus, errorThrown) {
-                    $("#pms-verify").html('<i class="fa fa-close"></i>');
-                    $('#pms-verify').fadeIn('fast');
-                    $("#pms-ip-group").addClass("has-error");
+                error: function (jqXHR, textStatus, errorThrown) {
+                    $("#pms_verify").html('<i class="fa fa-close"></i>').fadeIn('fast');
+                    $("#pms_ip_group").addClass("has-error");
                 },
                 success: function (json) {
                     var machine_identifier = json;
                     if (machine_identifier) {
                         $("#pms_identifier").val(machine_identifier);
-                        $("#pms-verify").html('<i class="fa fa-check"></i>');
-                        $('#pms-verify').fadeIn('fast');
-                        $("#pms-ip-group").removeClass("has-error");
+                        $("#pms_verify").html('<i class="fa fa-check"></i>').fadeIn('fast');
+                        $("#pms_ip_group").removeClass("has-error");
 
                         if (_callback) {
                             _callback();
                         }
                     } else {
-                        $("#pms-verify").html('<i class="fa fa-close"></i>');
-                        $('#pms-verify').fadeIn('fast');
-                        $("#pms-ip-group").addClass("has-error");
+                        $("#pms_verify").html('<i class="fa fa-close"></i>').fadeIn('fast');
+                        $("#pms_ip_group").addClass("has-error");
                         showMsg('<i class="fa fa-exclamation-circle"></i> Could not verify your server.', false, true, 5000, true)
                     }
                 }
             });
         } else {
-            $("#pms-verify").html('<i class="fa fa-close"></i>');
-            $('#pms-verify').fadeIn('fast');
-            $("#pms-ip-group").addClass("has-error");
+            $("#pms_verify").html('<i class="fa fa-close"></i>').fadeIn('fast');
+            $("#pms_ip_group").addClass("has-error");
             showMsg('<i class="fa fa-exclamation-circle"></i> Could not verify your server.', false, true, 5000, true)
         }
     }
@@ -1804,11 +1818,21 @@ $(document).ready(function() {
         verifyServer();
     });
 
+    function verifyPMSWebURL() {
+        var pms_web_url = $.trim($("#pms_web_url").val());
+        $("#pms_web_url").val(pms_web_url || 'https://app.plex.tv/desktop');
+    }
+
+    $('#test_pms_web_button').on('click', function(){
+        var pms_web_url = $.trim($("#pms_web_url").val());
+        window.open(pms_web_url, '_blank');
+    });
+
     // Plex.tv auth token fetch
     $("#get-pms-auth-token").click(function() {
         $("#pms-token-status").html('<i class="fa fa-refresh fa-spin"></i> Fetching token...');
-        var pms_username = $("#pms_username").val().trim();
-        var pms_password = $("#pms_password").val().trim();
+        var pms_username = $.trim($("#pms_username").val());
+        var pms_password = $.trim($("#pms_password").val());
         if ((pms_username !== '') && (pms_password !== '')) {
             $.ajax({
                 type: 'GET',
diff --git a/plexpy/notification_handler.py b/plexpy/notification_handler.py
index 9042102c..796970f1 100644
--- a/plexpy/notification_handler.py
+++ b/plexpy/notification_handler.py
@@ -504,7 +504,7 @@ def build_media_notify_params(notify_action=None, session=None, timeline=None, m
 
     # Build Plex URL
     metadata['plex_url'] = '{web_url}#!/server/{pms_identifier}/details?key=%2Flibrary%2Fmetadata%2F{rating_key}'.format(
-        web_url=plexpy.CONFIG.PMS_WEB_URL or 'https://app.plex.tv/desktop',
+        web_url=plexpy.CONFIG.PMS_WEB_URL,
         pms_identifier=plexpy.CONFIG.PMS_IDENTIFIER,
         rating_key=rating_key)