From 600bca7e8b7c1f55e3f1d9714c4b7bb70d99778e Mon Sep 17 00:00:00 2001
From: JonnyWong16 <Jonny.Wong.16@gmail.com>
Date: Sat, 7 May 2016 11:20:46 -0700
Subject: [PATCH] Only check browser notifications if enabled

---
 data/interfaces/default/base.html             |  3 ++
 .../default/js/ajaxNotifications.js           | 42 +++++++++++++++++++
 data/interfaces/default/js/script.js          | 41 +-----------------
 plexpy/notifiers.py                           | 11 ++++-
 4 files changed, 56 insertions(+), 41 deletions(-)
 create mode 100644 data/interfaces/default/js/ajaxNotifications.js

diff --git a/data/interfaces/default/base.html b/data/interfaces/default/base.html
index 9ca3af07..9b1c027d 100644
--- a/data/interfaces/default/base.html
+++ b/data/interfaces/default/base.html
@@ -296,6 +296,9 @@ ${next.headerIncludes()}
 <script src="${http_root}js/bootstrap-hover-dropdown.min.js"></script>
 <script src="${http_root}js/pnotify.custom.min.js"></script>
 <script src="${http_root}js/script.js"></script>
+% if plexpy.CONFIG.BROWSER_ENABLED:
+<script src="${http_root}js/ajaxNotifications.js"></script>
+% endif
 <script>
     $('#updateDismiss').click(function() {
         $('#updatebar').slideUp('slow');
diff --git a/data/interfaces/default/js/ajaxNotifications.js b/data/interfaces/default/js/ajaxNotifications.js
new file mode 100644
index 00000000..29e817a4
--- /dev/null
+++ b/data/interfaces/default/js/ajaxNotifications.js
@@ -0,0 +1,42 @@
+// Taken from https://github.com/SickRage/SickRage
+
+PNotify.prototype.options.addclass = "stack-bottomright";
+PNotify.prototype.options.buttons.closer_hover = false;
+PNotify.prototype.options.desktop = { desktop: true, icon: 'images/favicon.png' }
+PNotify.prototype.options.history = false;
+PNotify.prototype.options.shadow = false;
+PNotify.prototype.options.stack = { dir1: 'up', dir2: 'left', firstpos1: 25, firstpos2: 25 };
+PNotify.prototype.options.styling = 'fontawesome';
+PNotify.prototype.options.type = 'notice';
+PNotify.prototype.options.width = '340px';
+
+function displayPNotify(title, message) {
+    var notification = new PNotify({
+        title: title,
+        text: message
+    });
+}
+
+function check_notifications() {
+    $.getJSON('get_browser_notifications', function (data) {
+        if (data) {
+            $.each(data, function (i, notification) {
+                if (notification.delay == 0) {
+                    PNotify.prototype.options.hide = false;
+                } else {
+                    PNotify.prototype.options.hide = true;
+                    PNotify.prototype.options.delay = notification.delay * 1000;
+                }
+                displayPNotify(notification.subject_text, notification.body_text);
+            });
+        }
+    });
+    setTimeout(function () {
+        "use strict";
+        check_notifications();
+    }, 3000);
+}
+
+$(document).ready(function () {
+    check_notifications();
+});
\ No newline at end of file
diff --git a/data/interfaces/default/js/script.js b/data/interfaces/default/js/script.js
index 0de2f35a..c163b855 100644
--- a/data/interfaces/default/js/script.js
+++ b/data/interfaces/default/js/script.js
@@ -407,43 +407,4 @@ window.onerror = function (message, file, line) {
 
     $.post("log_js_errors", e, function (data) {
     });
-};
-
-PNotify.prototype.options.addclass = "stack-bottomright";
-PNotify.prototype.options.buttons.closer_hover = false;
-PNotify.prototype.options.desktop = { desktop: true, icon: 'images/favicon.png' }
-PNotify.prototype.options.history = false;
-PNotify.prototype.options.shadow = false;
-PNotify.prototype.options.stack = { dir1: 'up', dir2: 'left', firstpos1: 25, firstpos2: 25 };
-PNotify.prototype.options.styling = 'fontawesome';
-PNotify.prototype.options.type = 'notice';
-PNotify.prototype.options.width = '340px';
-
-function displayPNotify(title, message) {
-    var notification = new PNotify({
-        title: title,
-        text: message
-    });
-}
-
-function check_notifications() {
-    $.getJSON('get_browser_notifications', function (data) {
-        $.each(data, function (i, notification) {
-            if (notification.delay == 0) {
-                PNotify.prototype.options.hide = false;
-            } else {
-                PNotify.prototype.options.hide = true;
-                PNotify.prototype.options.delay = notification.delay * 1000;
-            }
-            displayPNotify(notification.subject_text, notification.body_text);
-        });
-    });
-    setTimeout(function () {
-        "use strict";
-        check_notifications();
-    }, 3000);
-}
-
-$(document).ready(function () {
-    check_notifications();
-});
\ No newline at end of file
+};
\ No newline at end of file
diff --git a/plexpy/notifiers.py b/plexpy/notifiers.py
index 402e6cd3..efb9bf07 100644
--- a/plexpy/notifiers.py
+++ b/plexpy/notifiers.py
@@ -2438,6 +2438,9 @@ class Browser(object):
         return True
 
     def get_notifications(self):
+        if not self.enabled:
+            return
+
         monitor_db = database.MonitorDatabase()
         result = monitor_db.select('SELECT subject_text, body_text FROM notify_log '
                                    'WHERE agent_id = 17 AND timestamp >= ? ',
@@ -2457,7 +2460,13 @@ class Browser(object):
         self.notify('PlexPy', 'Test Notification')
 
     def return_config_options(self):
-        config_option = [{'label': 'Allow Notifications',
+        config_option = [{'label': 'Enable Browser Notifications',
+                          'value': self.enabled,
+                          'name': 'browser_enabled',
+                          'description': 'Enable to display desktop notifications from your browser.',
+                          'input_type': 'checkbox'
+                          },
+                         {'label': 'Allow Notifications',
                           'value': 'Allow Notifications',
                           'name': 'allow_browser',
                           'description': 'Click to allow browser notifications. You must click this button for each browser.',