From 38613f24fe66be629c16813d2a2f131b7238f231 Mon Sep 17 00:00:00 2001
From: JonnyWong16 <JonnyWong16@users.noreply.github.com>
Date: Sat, 24 Mar 2018 23:09:30 -0700
Subject: [PATCH] Scroll to setting position

---
 .../interfaces/default/newsletter_config.html |  6 ++--
 data/interfaces/default/notifier_config.html  |  2 +-
 data/interfaces/default/settings.html         | 17 +++++++---
 plexpy/notifiers.py                           | 32 +++++++++++++------
 4 files changed, 39 insertions(+), 18 deletions(-)

diff --git a/data/interfaces/default/newsletter_config.html b/data/interfaces/default/newsletter_config.html
index 48471eaa..77334f99 100644
--- a/data/interfaces/default/newsletter_config.html
+++ b/data/interfaces/default/newsletter_config.html
@@ -239,9 +239,9 @@
                                                 </select>
                                             </div>
                                         </div>
-                                        <p class="help-block">Select an existing notification agent where the subject and body text will be sent.<br>
-                                            Note: Self-hosted newsletters must be enabled under <a data-tab-destination="tabs-newsletters" data-dismiss="modal">Newsletters</a> to include a link to the newsletter.
-
+                                        <p class="help-block">
+                                            Select an existing notification agent where the subject and body text will be sent.<br>
+                                            Note: Self-hosted newsletters must be enabled under <a data-tab-destination="tabs-newsletters" data-dismiss="modal" data-target="#newsletter_self_hosted">Newsletters</a> to include a link to the newsletter.
                                         </p>
                                     </div>
                                 </div>
diff --git a/data/interfaces/default/notifier_config.html b/data/interfaces/default/notifier_config.html
index 45a23499..6215bcf1 100644
--- a/data/interfaces/default/notifier_config.html
+++ b/data/interfaces/default/notifier_config.html
@@ -433,7 +433,7 @@
             '<div class="form-group">' +
             '<label>Warning</label>' +
             '<p class="help-block" style="color: #eb8600;">Facebook requires HTTPS for authorization. ' +
-            'Please enable HTTPS for Tautulli under <a data-tab-destination="tabs-web_interface" data-dismiss="modal">Web Interface</a>.</p>' +
+            'Please enable HTTPS for Tautulli under <a data-tab-destination="tabs-web_interface" data-dismiss="modal" data-target="#enable_https">Web Interface</a>.</p>' +
             '</div>'
         );
         $('#facebook_redirect_uri').val('HTTPS not enabled');
diff --git a/data/interfaces/default/settings.html b/data/interfaces/default/settings.html
index 70858c3c..79a7a4be 100644
--- a/data/interfaces/default/settings.html
+++ b/data/interfaces/default/settings.html
@@ -946,7 +946,7 @@
                         </div>
                         <div id="self_host_newsletter_options" style="overlfow: hidden; display: ${'block' if config['newsletter_self_hosted'] == 'checked' else 'none'}">
                             <p class="help-block" id="self_host_newsletter_message">Note: The <span class="inline-pre">${http_root}newsletter</span> endpoint on your domain must be publically accessible from the internet.</p>
-                            <p class="help-block settings-warning base-url-warning">Warning: Tautulli public domain not set under <a data-tab-destination="tabs-web_interface">Web Interface</a>.</p>
+                            <p class="help-block settings-warning base-url-warning">Warning: Tautulli public domain not set under <a data-tab-destination="tabs-web_interface" data-target="#http_base_url">Web Interface</a>.</p>
                         </div>
 
                         <div class="padded-header">
@@ -981,7 +981,7 @@
                         </div>
                         <div id="self_host_image_options" style="overlfow: hidden; display: ${'none' if config['notify_upload_posters'] != 2 else 'block'}">
                             <p class="help-block" id="self_host_image_message">Note: The <span class="inline-pre">${http_root}image</span> endpoint on your domain must be publically accessible from the internet.</p>
-                            <p class="help-block settings-warning base-url-warning">Warning: Tautulli public domain not set under <a data-tab-destination="tabs-web_interface">Web Interface</a>.</p>
+                            <p class="help-block settings-warning base-url-warning">Warning: Tautulli public domain not set under <a data-tab-destination="tabs-web_interface" data-target="#http_base_url">Web Interface</a>.</p>
                         </div>
                         <div class="checkbox">
                             <label>
@@ -1030,7 +1030,7 @@
                             Add a new newsletter agent, or configure an existing newsletter agent by clicking the settings icon on the right.
                         </p>
                         <p class="help-block settings-warning" id="newsletter_upload_warning">
-                            Note: Either <a data-tab-destination="tabs-notifications">Image Hosting</a> on Imgur or <a data-tab-destination="tabs-notifications">Self-Hosted Newsletters</a> must be enabled.</span>
+                            Note: Either <a data-tab-destination="tabs-notifications" data-target="#notify_upload_posters">Image Hosting</a> on Imgur or <a data-tab-destination="tabs-notifications" data-target="#newsletter_self_hosted">Self-Hosted Newsletters</a> must be enabled.</span>
                         </p>
                         <br/>
                         <div id="plexpy-newsletters-table">
@@ -1150,7 +1150,7 @@
                         <p class="form-group">
                             <label>Registered Devices</label>
                             <p class="help-block">Register a new device using a QR code, or configure an existing device by clicking the settings icon on the right.</p>
-                            <p id="app_api_msg" style="color: #eb8600;">The API must be enabled under <a data-tab-destination="tabs-web_interface">Web Interface</a> to use the app.</p>
+                            <p id="app_api_msg" style="color: #eb8600;">The API must be enabled under <a data-tab-destination="tabs-web_interface" data-target="#api_enabled">Web Interface</a> to use the app.</p>
                             <div class="row">
                                 <div id="plexpy-mobile-devices-table" class="col-md-12">
                                     <div class='text-muted'><i class="fa fa-refresh fa-spin"></i> Loading registered devices...</div>
@@ -2558,6 +2558,15 @@ $(document).ready(function() {
     $('body').on('click', 'a[data-tab-destination]', function () {
         var tab = $(this).data('tab-destination');
         $("a[href=#" + tab + "]").click();
+        var scroll_destination = $(this).data('target');
+        if (scroll_destination) {
+            if ($(scroll_destination).closest('.advanced-setting').length && !$('#menu_link_show_advanced_settings').hasClass('active')) {
+                $('#menu_link_show_advanced_settings').click()
+            }
+            var body_container = $('.body-container')
+            var scroll_pos = scroll_destination ? body_container.scrollTop() + $(scroll_destination).offset().top - 100 : 0;
+            body_container.animate({scrollTop: scroll_pos});
+        }
     });
 });
 </script>
diff --git a/plexpy/notifiers.py b/plexpy/notifiers.py
index 422508d4..6d1ca7a4 100644
--- a/plexpy/notifiers.py
+++ b/plexpy/notifiers.py
@@ -960,8 +960,8 @@ class ANDROIDAPP(Notifier):
             config_option.append({
                 'label': 'Device',
                 'description': 'No devices registered. '
-                               '<a data-tab-destination="tabs-android_app" data-toggle="tab" data-dismiss="modal">'
-                               'Get the Android App</a> and register a device.',
+                               '<a data-tab-destination="tabs-android_app" data-toggle="tab" data-dismiss="modal" '
+                               'data-target="#top">Get the Android App</a> and register a device.',
                 'input_type': 'help'
                 })
         else:
@@ -970,8 +970,8 @@ class ANDROIDAPP(Notifier):
                 'value': self.config['device_id'],
                 'name': 'androidapp_device_id',
                 'description': 'Set your Android app device or '
-                               '<a data-tab-destination="tabs-android_app" data-toggle="tab" data-dismiss="modal">'
-                               'register a new device</a> with Tautulli.',
+                               '<a data-tab-destination="tabs-android_app" data-toggle="tab" data-dismiss="modal" '
+                               'data-target="#top">register a new device</a> with Tautulli.',
                 'input_type': 'select',
                 'select_options': devices
                 })
@@ -1224,7 +1224,9 @@ class DISCORD(Notifier):
                           'value': self.config['incl_card'],
                           'name': 'discord_incl_card',
                           'description': 'Include an info card with a poster and metadata with the notifications.<br>'
-                                         'Note: Image hosting must be enabled under the notifications settings tab.',
+                                         'Note: <a data-tab-destination="tabs-notifications" data-dismiss="modal" '
+                                         'data-target="#notify_upload_posters">Image Hosting</a> '
+                                         'must be enabled under the notifications settings tab.',
                           'input_type': 'checkbox'
                           },
                          {'label': 'Include Plot Summaries',
@@ -1574,7 +1576,9 @@ class FACEBOOK(Notifier):
                           'value': self.config['incl_card'],
                           'name': 'facebook_incl_card',
                           'description': 'Include an info card with a poster and metadata with the notifications.<br>'
-                                         'Note: Image hosting must be enabled under the notifications settings tab.',
+                                         'Note: <a data-tab-destination="tabs-notifications" data-dismiss="modal" '
+                                         'data-target="#notify_upload_posters">Image Hosting</a> '
+                                         'must be enabled under the notifications settings tab.',
                           'input_type': 'checkbox'
                           },
                          {'label': 'Movie Link Source',
@@ -1895,7 +1899,9 @@ class HIPCHAT(Notifier):
                           'value': self.config['incl_card'],
                           'name': 'hipchat_incl_card',
                           'description': 'Include an info card with a poster and metadata with the notifications.<br>'
-                                         'Note: Image hosting must be enabled under the notifications settings tab.<br>'
+                                         'Note: <a data-tab-destination="tabs-notifications" data-dismiss="modal" '
+                                         'data-target="#notify_upload_posters">Image Hosting</a> '
+                                         'must be enabled under the notifications settings tab.<br>'
                                          'Note: This will change the notification type to HTML and emoticons will no longer work.',
                           'input_type': 'checkbox'
                           },
@@ -2114,7 +2120,9 @@ class JOIN(Notifier):
                           'value': self.config['incl_poster'],
                           'name': 'join_incl_poster',
                           'description': 'Include a poster with the notifications.<br>'
-                                         'Note: Image hosting must be enabled under the notifications settings tab.',
+                                         'Note: <a data-tab-destination="tabs-notifications" data-dismiss="modal" '
+                                         'data-target="#notify_upload_posters">Image Hosting</a> '
+                                         'must be enabled under the notifications settings tab.',
                           'input_type': 'checkbox'
                           },
                          {'label': 'Movie Link Source',
@@ -3223,7 +3231,9 @@ class SLACK(Notifier):
                           'value': self.config['incl_card'],
                           'name': 'slack_incl_card',
                           'description': 'Include an info card with a poster and metadata with the notifications.<br>'
-                                         'Note: Image hosting must be enabled under the notifications settings tab.',
+                                         'Note: <a data-tab-destination="tabs-notifications" data-dismiss="modal" '
+                                         'data-target="#notify_upload_posters">Image Hosting</a> '
+                                         'must be enabled under the notifications settings tab.',
                           'input_type': 'checkbox'
                           },
                          {'label': 'Include Plot Summaries',
@@ -3455,7 +3465,9 @@ class TWITTER(Notifier):
                           'value': self.config['incl_poster'],
                           'name': 'twitter_incl_poster',
                           'description': 'Include a poster with the notifications.<br>'
-                                         'Note: Image hosting must be enabled under the notifications settings tab.',
+                                         'Note: <a data-tab-destination="tabs-notifications" data-dismiss="modal" '
+                                         'data-target="#notify_upload_posters">Image Hosting</a> '
+                                         'must be enabled under the notifications settings tab.',
                           'input_type': 'checkbox'
                           }
                          ]