From ddf15247e341e14cac97bba24d0301d526498958 Mon Sep 17 00:00:00 2001 From: Labrys of Knossos Date: Sat, 19 Jan 2019 11:53:29 -0500 Subject: [PATCH] Use context manager instead of assignment --- core/__init__.py | 31 +++++++++++++++---------------- 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/core/__init__.py b/core/__init__.py index c5cfd7a1..730068a4 100644 --- a/core/__init__.py +++ b/core/__init__.py @@ -530,28 +530,27 @@ def configure_plex(): def configure_niceness(): global NICENESS - devnull = open(os.devnull, 'w') - try: - subprocess.Popen(['nice'], stdout=devnull, stderr=devnull).communicate() - NICENESS.extend(['nice', '-n{0}'.format(int(CFG['Posix']['niceness']))]) - except Exception: - pass - try: - subprocess.Popen(['ionice'], stdout=devnull, stderr=devnull).communicate() + with open(os.devnull, 'w') as devnull: try: - NICENESS.extend(['ionice', '-c{0}'.format(int(CFG['Posix']['ionice_class']))]) + subprocess.Popen(['nice'], stdout=devnull, stderr=devnull).communicate() + NICENESS.extend(['nice', '-n{0}'.format(int(CFG['Posix']['niceness']))]) except Exception: pass try: - if 'ionice' in NICENESS: - NICENESS.extend(['-n{0}'.format(int(CFG['Posix']['ionice_classdata']))]) - else: - NICENESS.extend(['ionice', '-n{0}'.format(int(CFG['Posix']['ionice_classdata']))]) + subprocess.Popen(['ionice'], stdout=devnull, stderr=devnull).communicate() + try: + NICENESS.extend(['ionice', '-c{0}'.format(int(CFG['Posix']['ionice_class']))]) + except Exception: + pass + try: + if 'ionice' in NICENESS: + NICENESS.extend(['-n{0}'.format(int(CFG['Posix']['ionice_classdata']))]) + else: + NICENESS.extend(['ionice', '-n{0}'.format(int(CFG['Posix']['ionice_classdata']))]) + except Exception: + pass except Exception: pass - except Exception: - pass - devnull.close() def initialize(section=None):