From 0788a754cbd9d66c3be95e0e74edd06dff9d93cc Mon Sep 17 00:00:00 2001 From: Labrys of Knossos Date: Sun, 7 Apr 2019 12:15:07 -0400 Subject: [PATCH 1/3] Fix code quality checks to run all desired tests Fixes #1602 --- tox.ini | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/tox.ini b/tox.ini index c614d8d3..cf22519c 100644 --- a/tox.ini +++ b/tox.ini @@ -33,12 +33,6 @@ commands = max-line-length = 79 verbose = 2 statistics = True -select = -; -- flake8-bugbear -- -; B902 Invalid first argument used for instance method. -; B903 Data class should either be immutable or use __slots__ to save memory. - B902, B903 - ignore = ; -- flake8 -- ; E501 line too long @@ -78,7 +72,15 @@ deps = flake8-quotes skip_install = true commands = +; ** PRIMARY TESTS ** +; Run flake8 tests (with plugins) using default test selections flake8 core tests setup.py +; ** SELECTIVE TESTS ** +; Run flake8 tests (with plugins) for specific optional codes defined below +; -- flake8-bugbear -- +; B902 Invalid first argument used for instance method. +; B903 Data class should be immutable or use __slots__ to save memory. + flake8 core tests setup.py --select=B902,B903 [coverage:run] omit = From e7179dde1c8115233edadb36dc61776ea793d79a Mon Sep 17 00:00:00 2001 From: Labrys of Knossos Date: Sun, 7 Apr 2019 12:38:43 -0400 Subject: [PATCH 2/3] Temporarily disable some flake8 ignores for testing --- tox.ini | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tox.ini b/tox.ini index cf22519c..089c95f8 100644 --- a/tox.ini +++ b/tox.ini @@ -36,7 +36,7 @@ statistics = True ignore = ; -- flake8 -- ; E501 line too long - E501 +; E501 ; -- flake8-docstrings -- ; D100 Missing docstring in public module @@ -57,7 +57,7 @@ ignore = per-file-ignores = ; F401 imported but unused ; E402 module level import not at top of file - core/__init__.py: E402, F401 +; core/__init__.py: E402, F401 core/utils/__init__.py: F401 core/plugins/downloaders/configuration.py: F401 core/plugins/downloaders/utils.py: F401 From 28ff74d0c8e8ce585e1452b58e84f745e5737fe4 Mon Sep 17 00:00:00 2001 From: Labrys of Knossos Date: Sun, 7 Apr 2019 12:42:18 -0400 Subject: [PATCH 3/3] Revert "Temporarily disable some flake8 ignores for testing" This reverts commit e7179dde1c8115233edadb36dc61776ea793d79a. --- tox.ini | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tox.ini b/tox.ini index 089c95f8..cf22519c 100644 --- a/tox.ini +++ b/tox.ini @@ -36,7 +36,7 @@ statistics = True ignore = ; -- flake8 -- ; E501 line too long -; E501 + E501 ; -- flake8-docstrings -- ; D100 Missing docstring in public module @@ -57,7 +57,7 @@ ignore = per-file-ignores = ; F401 imported but unused ; E402 module level import not at top of file -; core/__init__.py: E402, F401 + core/__init__.py: E402, F401 core/utils/__init__.py: F401 core/plugins/downloaders/configuration.py: F401 core/plugins/downloaders/utils.py: F401