* Merged PR 10748585: Recall | Connect UserActivity to support restoring from snapshots
## What
Thanks to @<Brendan Elliott ⌨> for his PoC !10573092
This PR is going to use `UserActivity` APIs to connect the app to Recall so that we can take a snapshot when asked and then retore our states from the snapshot later.
## How
- Add a new type `SnapshotLaunchArguments` to identify a protocol launch requested by Recall.
- Add an extension `LaunchExtensions` as helper to retrieve key information from fundamental types.
- Refactor `App::OnActivated()` and `MainPage::OnNavigatedTo()` to handle different protocols properly.
- Create or parse `UserActivity` in `MainPage` in the way like what the PoC is doing.
- Improve the coding style a bit for `MainPage`.
## Note
The serialization work and restoring from JSON is going to be done in a separate PR.
## Testing
Manually tested.
Some typical test cases:
- Launch the app from *Start menu*
- Launch the app from *Task bar*
- Launch the app from *Command line*
- Launch with the protocol for Recall
- Launch with the protocol that is injected with evil data.
Related work items: #50854714
* Merged PR 10741448: [Recall] Snapshot saving and restoring
####What
According to PM [Spec](https://microsoft.sharepoint-df.com/:w:/t/PAXEssentialExperiences421/EcpP5tGRtFdIsRrP84ueRfUBjb6tfayxWtF9ujvJuNx6Dg?e=AeRzVf), saving and restoring Calculator snapshot when required.
The current snapshot supports to:
- Restore the calculator mode.
- Restore the current calculation (display value and expression).
- Restore the history of calculations (either in Standard mode or Scientific mode) shown at the time the snapshot was taken.
- Restore the current calculation error state, if applicable.
####How
- Added `SnapshotHelper` to help save and restore snapshots.
- Besides the existing snapshot information from view models, added an extra field `SnapshotVersion` in `ApplicationSnapshot` for backward compatibility.
#### Note
Unit tests will be added in a separate PR.
Related work items: #50701758
* Merged PR 10772614: Recall | Update the LaunchURI design
## What
Since `System.Uri` already has the `Segment` property which contains the parsed path blocks, Query in Uri looks too heavy and intrusive in implementation to retrieve the activity id.
## Changes
Changed the launch URI from something like `ms-calculator:///snapshot?activityId=<a guid>` to `ms-calculator:snapshots/<a guid>`
Related work items: #50854714
* Merged PR 10778666: Recall | Show error dialog if launching from snapshot has failed
## What
Per Figma design, we can show an error dialog with messages for the failures happens during snapshot launch.
## Notes
- Fixed a crash about taking a snapshot when Calculator hasn't initialized a standard calculator.
- Simplified the restore path.
## Screenshot
Related work items: #50858262
* Merged PR 10790341: [Recall] Update calculator engine with snapshot for further calculations
####What
When restoring from snapshot, we need to set calculator engine properly to make further calculations correct.
####How
Update calculator engine by a serial of corresponding commands from snapshot.
To get the commands for the display area when saving snapshot,
1. If the expression is not from history and the primary display is the result of the expression, `DisplayCommands` of `StandardCalculatorSnapshot` will be empty, and we will use the commands from `ExpressionDisplay` for restoring in the future.
2. If the expression is not from history and the primary display is not the result of the expression, `DisplayCommands` of `StandardCalculatorSnapshot` will be the commands from the history collector in addition to the operand command in the primary display, and it will be used for restoring in the future.
3. If the expression and primary display are from history, `DisplayCommands` will be incomplete with the operand command in the primary display missing as by current design of history, and the commands from `ExpressionDisplay` will be used for restoring in the future.
Related work items: #51002745
* Merged PR 10802927: Recall | Add threat model
## What
The support for Recall introduced a URI activation process allowing the Recall app to launch Calculator with desired snapshot metadata. This led to a potential security problem, and we need to address it by providing justifications.
Threat model is a well-known practice among Inbox Apps. After offline discussion, we decide to add diagrams for this Recall feature to prepare for the security review.
## Diagram preview
Related work items: #51165486
* Merged PR 10794979: Add Recall Telemetry
**Snapshot**
EventName: `RecallSnapshot`
Payload example:` { "CalcMode": "Standard"}`
**_Fires when a snapshot (UserActivityRequested) is triggered_**
**Restore**
EventName: `RecallRestore`
Payload example:`{ "CalcMode": "Standard"}`
**_Fires when launching by snapshot (recall restore)**
**Error**
EventName: `Exception`
Payload example: `{ "CalcMode": "Standard", "FunctionName" : "MainPage::ShowSnapshotLaunchErrorAsync", "Message": "SnapshotRestoreError" }`
**_Fires when launching by snapshot failed_**
Related work items: #51114542
---------
Co-authored-by: Tian Liao ☕ <tilia@microsoft.com>
Co-authored-by: Jian Zhang <zjian@microsoft.com>
* Fix the result in wrong number base while leaving and switching back to Programmer
* Rename ResetDisplay() to ResetRadix()
* Update related unit test
* Fixed the decimal number with point in programmer memory
* Hello C# - Going to an official feature branch (#1544)
* change CalcViewModel into a WindowsRuntimeComponent project (#5)
* change CalcViewModel into a WindowsRuntimeComponent project
* remove the old UI codebase (#6)
* initially migrated C# codebase by tian (#7)
* initial migrated C# codebase by tian
* format the codebase
* resolve comments
* undo: modifications on UI test project
* Remove the blocks that have more than 1 empty line.
* Register DP using keyword 'nameof'
* C# Migration: Initially migrated C# codebase by Han (#8)
* C# Migration: Initially migrated C# codebase by Han
* Resolved comments and misssing asset
* Added three files to Calculator project
* Added TODO comment and updated Object
* NavCategory: temporary resolution of the hang issue (#9)
* Updated CalcViewModel and missing files (#10)
* Updated CalcViewModel and WinMeta
* Added Calculator.rc
* Resolved comment for InitializeLocalizationSettings
* add: views/unitconverter.xaml (#11)
* add: views/unitconverter.xaml
* format the code
* remove the extra empty line
* add an empty line
* check null before invoking event handlers (#12)
* fix problems of the migration of OBSERVABLE_PROPERTY_RW (#13)
* fixes crash in MathRichEditBox.ctor() (#14)
* fixes crash in MathRichEditBox.ctor()
* typo
* Update azure-pipelines.ci.yaml for Azure Pipelines
* Added a link copy of CalcViewModel to temporarily pass Unit Tests (#16)
* Updated CalcViewModelCopyForUT configuration (#17)
* changes output path of the UI project to align with other projects (#15)
* fixes EETypeLoadException issue: export class DelegateCommand (#18)
* fixes EETypeLoadException issue: export class DelegateCommand
* weak-reference in C++/CX
* WeakRef in C# codebase
* UTF-8-BOM
* spaces in macro
* resolve some comments from the offline review
* format
* rename file
* fixes the memory list issue (#20)
* fixes a wrongly migrated property
* UTF-8-BOM
* fixes up the crash of type casting (#21)
* Update localized strings 2021-01-04 (#1458) (#23)
(cherry picked from commit cdcb95656d)
Co-authored-by: Matt Cooley <macool@microsoft.com>
* Fixup tests (#1429) (#24)
- Removed unneeded "ToString" calls
- Fixed typos
- Renamed "fEButtonState" to "FEButtonState"
(cherry picked from commit 66ad328d00)
Co-authored-by: N <71219152+PokeCodec@users.noreply.github.com>
* Update graph internal engine verseion (#1466) (#25)
(cherry picked from commit 0048dcb500)
Co-authored-by: Quentin Al-Timimi <27322516+quentin987@users.noreply.github.com>
* Turn off DFS file shares in internal build system (#1470) (#26)
(cherry picked from commit 885fa23a89)
Co-authored-by: Matt Cooley <macool@microsoft.com>
* Improve clarity of math expressions in history for Standard Calculator (feature #138) (#1453) (#27)
* Implemented feature & added unit tests
* Fixed more unit/ui tests
* Refactored tests
* Update HistoryTests.cpp
* Update HistoryTests.cpp
* Update HistoryTests.cpp
* Update HistoryTests.cpp
* Update HistoryTests.cpp
* Update HistoryTests.cpp
* Update HistoryTests.cpp
* Update HistoryTests.cpp
(cherry picked from commit 565e3e2714)
Co-authored-by: Wei (Waley) Zhang <waley.zhang@microsoft.com>
* Adds unit-test cases for NarratorAnnouncement after fixing issue #1386 (#1469) (#28)
* fix bug: No confirmation is announced by the narrator after activating 'Remove equation' button #1386
* Unit Test: Add NarratorAnnouncementUnitTests
Co-authored-by: tain <tankle_@hotmail.com>
(cherry picked from commit 9d8e2ad18c)
Co-authored-by: Tian L <60599517+MSFT-Tilia@users.noreply.github.com>
* Move localization pipeline sync schedule to the YAML file (#1478) (#30)
(cherry picked from commit 007eccd940)
Co-authored-by: Matt Cooley <macool@microsoft.com>
* remove the strong reference carried from delegate (#32)
* Remove the finalizer of ControlSizeTrigger (#31)
* Normalize the namespace of CalcViewModel (#33)
* ViewMode: arrange namespaces
* UI build pass
* run release
* UT build pass
* pass build
* resolve comment: make the diff results cleaner
* resolve comment: make the diff results cleaner (2)
* resolve comment: make the diff results cleaner (3)
* resolve comment: move impl into a namespace
* update: spaces
* update: CalculatorButtonUser.h
* UTF-8 to UTF-8-BOM
* remove ViewState.h/.cpp from CalcViewModel path
* revert changes for NavCategory.cpp
* remove extra space
* remove UCM
* remove BOM
* Fixed a graphing calculator "permissions" bug caused by PR #1426 (#1471) (#34)
- The PR #1426 can cause a crash when no users are returned via `User::FindAllAsync(UserType::LocalUser)` when subsequently trying to access the first user. The existing code also does not guarantee that the returned user is the currently active user.
- This fix retrieves the user that opened the app and passes this user into a function to check if this user has the proper permissions to access the graphing mode. This makes sense since the active user is indistinguishable (at least from the app's perspective) to the user who opened the app. This user's permissions are then propagated downwards to properly set up the navigation menu of the app.
- Implementation detail worth pointing out: `s_categoryManifest` is what is used to populate the navigation menu of the app, but this variable is static by design, so a separate function was written to override the appropriate `isEnabled` value in `s_categoryManifest`. This function is called by `onLaunched`.
- Manual testing
Co-authored-by: Wei (Waley) Zhang <waley.zhang@microsoft.com>
* fixes up a bug (#35)
* fix csproj (#37)
Co-authored-by: hanzhang54 <zhangh@microsoft.com>
Co-authored-by: Matt Cooley <macool@microsoft.com>
Co-authored-by: N <71219152+PokeCodec@users.noreply.github.com>
Co-authored-by: Quentin Al-Timimi <27322516+quentin987@users.noreply.github.com>
Co-authored-by: Wei (Waley) Zhang <waley.zhang@microsoft.com>
Co-authored-by: Tian L <60599517+MSFT-Tilia@users.noreply.github.com>
* **BYPASS_SECRET_SCANNING** (#1546)
* Fixes a bug about the UI of expression tokens (#1547)
* fix
* [FeatureBranch] Fixes x86/ARM/ARM64 builds for the CI-Pipeline (#1550)
* **BYPASS_SECRET_SCANNING**
* fix
* fixes x86/ARM/ARM64 builds for CI-Pipeline
* Add headers missing for compilation with GCC (#1468) (#1551)
Things that required such update included:
* `wstringstream`
* `setprecision`
* `SCODE_CODE`, `E_BOUNDS`
* Various SAL macros
Co-authored-by: Michał Janiszewski <janisozaur@users.noreply.github.com>
* Update nuget.config file (#1486) (#1552)
Co-authored-by: Matt Cooley <macool@microsoft.com>
* Fixes up some simple miscellaneous TODO items (#1556)
* #DEBUG is a known C# preprocessor directive
* So far, we haven't observed the problem described in the comment from C# async
* fixes misc TODO items
* resolve some warnings (#1564)
* Add internal CI pipeline (#1553) (#1565)
* Add CI-internal pipeline
* No ARM64, to match release
Co-authored-by: Matt Cooley <macool@microsoft.com>
* Temporarily disable PGO NuGet package (#1510) (#1566)
Co-authored-by: Matt Cooley <macool@microsoft.com>
* [C# Calc]Removes WinMeta.cs (#1567)
* remove WinMeta.cs
* undo a trivial change
* UTF-8 BOM
* [C# Calc] Reverts some changes for Currency constants (#1570)
* Update2108release - experimental (#1572)
* adjusts Calculator.csproj (#1571)
* fixes BinSkim problems (#1573)
* fixes an issue around line style (#1575)
* fixes the missed NULLs (#1576) (#1578)
* Fix the Missing Part in Unit Converter Constructor (#1579)
* fixes: calculator doesn't remember its previous mode (#1580)
* Fixes: GraphingNumber doesn't work correctly (#1585)
* fixes: GraphingNumber doesn't work correctly
* Avoid crashing
* fixes binding (#1586)
* resolve TODO items (#1589)
* Improving keyboard support in VariableValueSlider (#1559) (#1595)
Co-authored-by: Dave Grochocki <grochocki@users.noreply.github.com>
* [C# Calc] Fixes: Keep the value away from getting rounded in Graphing Mode (#1596)
* keep the value away from getting rounded
* set the display precision to 6 to align with C++ impl
* fixes the button-light-up time (#1597)
* fixes up merging flaws
* Update2108release
* fixes (#1599)
* keep master for ci pipeline
* remove the Resources filter from CalcViewModel project
* removes `that` since `this` can be captured automatically
* AppxBundlePlatforms
* StampAssemblyInfo
* removes PreferredToolArchitecture
* Change the arg AppVersion into Version
* Change the arg AppVersion into Version
* from Calculator.rc to AssemblyInfo.cs
* Adds assembly-info
Co-authored-by: hanzhang54 <zhangh@microsoft.com>
Co-authored-by: Matt Cooley <macool@microsoft.com>
Co-authored-by: N <71219152+PokeCodec@users.noreply.github.com>
Co-authored-by: Quentin Al-Timimi <27322516+quentin987@users.noreply.github.com>
Co-authored-by: Wei (Waley) Zhang <waley.zhang@microsoft.com>
Co-authored-by: Tian L <60599517+MSFT-Tilia@users.noreply.github.com>
Co-authored-by: Michał Janiszewski <janisozaur@users.noreply.github.com>
Co-authored-by: Dave Grochocki <grochocki@users.noreply.github.com>
The programmer radix buttons were being disabled when the bit flip panel was selected, causing keyboard events to be ignored.
They should actually only be hidden in bit flip mode.
- Corrected programmer radix buttons to continue being enabled just hidden when the programmer calculator is in bit flip mode.
- Renamed AreProgrammerRadixOperatorsEnabled property to the more appropriate AreProgrammerRadixOperatorsVisible.
* move KeyboardShortcutManager, ValidationConverter and ViewState to Calculator
* remove dead code listed in #753
* remove Microsoft.UI.Xaml nuget package from CalcViewModel
* Fixing typo in StandardCalculatorViewModel::UpdatecommandsInRecordingMode
Removing unnecessary copy of vector in StandardCalculatorViewModel::UpdateCommandsInRecordingMode
Using range-for in StandardCalculatorViewModel::UpdateCommandsInRecordingMode
* Using static_cast instead of safe_cast for unsigned char to Command
- Using default wstring constructor instead of taking empty string literal
- Updated to for range-for where appropriate
- Used std::find for IsOp* code that was doing it by hand
- Used std::count to calculate LengthWithoutPadding
- Used existing wstring constructor to pad a string
* Replacing CalculatorVector usage with std::vector
Assumptions made here are that memory allocations
are not recoverable. If it can be proved that an index
will be in range, then the indexing operation is used.
If not (without manual checks) the std::vector::at function
is used to throw an exception in case of a programmer bug.
* Changes based on PR feedback
Using auto& in CalculatorCollector::UpdateHistoryExpression
so the token.first value is properly updated.
Using range for loop to GenerateExpressions.
Setting isEditable directly to the result of boolean expression.
Using token.second directly instead of creating a
separate tokenCommandIndex variable.
* Fixing issue with generating expressions strings.
A space should not be added before the first item.
Verify if the StandardCalculatorViewModel::DisplayValue isn't an error message before removing group separators (including space character).
How changes were validated:
Tested in english and french
Tested with "Cannot divide by zero" and "Result is undefined"
Fixes#420
Description of the changes:
Adjusted some of the values in .clang-format
Add clang-format-all.ps1
Fix path to .clang-format in Calculator.sln
How changes were validated:
Manual.
Fixes#202
This PR fixes code style for the project files.
The Problem
Different files in the project use different code style. That is not consistent and leads to harder maintenance of the project.
Description of the changes:
Have investigated and determined the most used code style across the given codebase
Have configured IDE and applied code style to all project files.
Have crafted clang-formatter config.
see https://clang.llvm.org/docs/ClangFormat.htmlhttps://clang.llvm.org/docs/ClangFormatStyleOptions.html
Some cases were fixed manually
How changes were validated:
manual/ad-hoc testing, automated testing
All tests pass as before because these are only code style changes.
Additional
Please review, and let me know if I have any mistake in the code style. In case of any mistake, I will change the configuration and re-apply it to the project.
Fixes#402 and #414
Divide by 4 the CPU usage of OverflowTextBlock when buttons are pressed very quickly.
Description of the changes:
Xaml-side:
OverflowTextBlock has some performance issues:
double scrollviewer: the listview was in a scrollviewer, while the control already containing one -> it breaks the virtualization of the listview and impacts on UI performance.
The listview used a StackPanel, this panel doesn't support virtualization of ListViewItems contrary to ItemsStackPanel
No ListView-specific features were used, an ItemsControl is more efficient and lighter.
refactor how we manage the visibility of the left/right buttons in OverflowTextBlock, the new version is more reactive and will not display the right arrow when not necessary (see GIF below).
remove the ItemContainerSelector ExpressionItemContainerStyle, not really used by OverflowTextBlock
remove UI glitches generated by ChangeView when users type fast (control partially hidden and scrolling issues, see the GIF below).
only modify the accessibility view when it's necessary
ViewModel-side:
stop fully refreshing ExpressionTokens in StandardCalculatorViewModel when a new command were sent, instead, use a IObservableVector to only send new tokens to the UI (in average only 1 or 2 UI items are refreshed while the full expression was refreshed before)
How changes were validated:
Manually
Fixed comments that were inconsistent with the style guidelines described in C++ core guidelines and the modern C++/WinRT language projections and removed trailing whitespace.
Inserted a space after the beginning of the comment so the text wasn't touching the // on all occurrences.
Removed all occurrences of trailing whitespace
