github/msft-calculator
1
0
Fork 0
mirror of https://github.com/Microsoft/calculator.git synced 2025-07-06 05:01:07 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

- Avoid referencing project headers from precompiled headers.

Browse source 
Before this change, the pchs for CalcViewModel and Calculator project referenced project headers.  If those project headers (or any of their dependencies) were to change, then the pch would be recompiled, slowing local build times.

  By removing references to project headers, the pch will be compiled once and is resilient to changes in the project.  Now that project headers are explicit about their dependencies, when there is a change to a project header only the translation units referencing the modified header will need to be rebuilt.

- Manually tested by ensuring Calculator project builds locally.

@Microsoft/calculator-team
This commit is contained in:
Daniel Belcher 2019-02-13 17:30:03 -08:00
parent 56fe16349d
commit f210290ddc
51 changed files with 173 additions and 120 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/CalcViewModel/DataLoaders/CurrencyDataLoader.cpp
View file

@ -1,13 +1,14 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.
#include "pch.h"
#include "CurrencyDataLoader.h"
#include "UnitConverterDataConstants.h"
#include "Common\AppResourceProvider.h"
#include "Common\LocalizationStringUtil.h"
#include "Common\LocalizationService.h"
#include "Common\LocalizationSettings.h"
#include "Common\TraceLogger.h"
#include "UnitConverterDataConstants.h"
using namespace CalculatorApp;
using namespace CalculatorApp::Common;