From ebfce5a8cd368ba5eb7740b9c70e98f57b382f06 Mon Sep 17 00:00:00 2001 From: Josh Koon <45607479+joshkoon@users.noreply.github.com> Date: Tue, 29 Jan 2019 14:28:03 -0800 Subject: [PATCH] Remove empty COpndCommand destructor. Cleanup constructor declaration. --- src/CalcManager/ExpressionCommand.cpp | 15 +++++++-------- src/CalcManager/ExpressionCommand.h | 4 ++-- 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/src/CalcManager/ExpressionCommand.cpp b/src/CalcManager/ExpressionCommand.cpp index 07c4cf7c..e671182e 100644 --- a/src/CalcManager/ExpressionCommand.cpp +++ b/src/CalcManager/ExpressionCommand.cpp @@ -95,11 +95,13 @@ void CBinaryCommand::Accept(_In_ ISerializeCommandVisitor &commandVisitor) commandVisitor.Visit(*this); } -COpndCommand::COpndCommand(_In_ shared_ptr> const &commands, - bool fNegative, - bool fDecimal, - bool fSciFmt) : - m_commands(commands), m_fNegative(fNegative), m_fDecimal(fDecimal), m_fSciFmt(fSciFmt), m_fInitialized(false), m_value{} +COpndCommand::COpndCommand(shared_ptr> const &commands, bool fNegative, bool fDecimal, bool fSciFmt) : + m_commands(commands), + m_fNegative(fNegative), + m_fDecimal(fDecimal), + m_fSciFmt(fSciFmt), + m_fInitialized(false), + m_value{} {} void COpndCommand::Initialize(Rational const& rat) @@ -299,9 +301,6 @@ wstring COpndCommand::GetString(uint32_t radix, int32_t precision, wchar_t decim return result; } -COpndCommand::~COpndCommand() -{} - void COpndCommand::Accept(_In_ ISerializeCommandVisitor &commandVisitor) { commandVisitor.Visit(*this); diff --git a/src/CalcManager/ExpressionCommand.h b/src/CalcManager/ExpressionCommand.h index 10bed355..0953ab26 100644 --- a/src/CalcManager/ExpressionCommand.h +++ b/src/CalcManager/ExpressionCommand.h @@ -49,11 +49,11 @@ private: class COpndCommand : public IOpndCommand { public: - COpndCommand(_In_ std::shared_ptr> const &commands, + COpndCommand( + std::shared_ptr> const &commands, bool fNegative, bool fDecimal, bool fSciFmt); - ~COpndCommand(); void Initialize(CalcEngine::Rational const& rat); const std::shared_ptr> & GetCommands() const;