github/msft-calculator
1
0
Fork 0
mirror of https://github.com/Microsoft/calculator.git synced 2025-08-22 22:23:29 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Followed ISO CPP Guideline NR 1

Browse source
This commit is contained in:
Nicholas Baron 2019-05-05 14:53:50 -07:00
commit e47028b891
1 changed files with 13 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

32
src/CalcManager/CalculatorVector.h
View file

@ -1,4 +1,4 @@
// Copyright (c) Microsoft Corporation. All rights reserved. // Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. // Licensed under the MIT License.
#pragma once #pragma once
@ -9,16 +9,15 @@ class CalculatorVector
public: public:
HRESULT GetAt(_In_opt_ unsigned int index, _Out_ TType *item) HRESULT GetAt(_In_opt_ unsigned int index, _Out_ TType *item)
{ {
HRESULT hr = S_OK;
try try
{ {
*item = m_vector.at(index); *item = m_vector.at(index);
} }
catch (const std::out_of_range& /*ex*/) catch (const std::out_of_range& /*ex*/)
{ {
hr = E_BOUNDS; return E_BOUNDS;
} }
return hr; return S_OK;
} }
HRESULT GetSize(_Out_ unsigned int *size) HRESULT GetSize(_Out_ unsigned int *size)
@ -29,35 +28,32 @@ public:
HRESULT SetAt(_In_ unsigned int index, _In_opt_ TType item) HRESULT SetAt(_In_ unsigned int index, _In_opt_ TType item)
{ {
HRESULT hr = S_OK;
try try
{ {
m_vector[index] = item; m_vector[index] = item;
} }
catch (const std::out_of_range& /*ex*/) catch (const std::out_of_range& /*ex*/)
{ {
hr = E_BOUNDS; return E_BOUNDS;
} }
return hr; return S_OK;
} }
HRESULT RemoveAt(_In_ unsigned int index) HRESULT RemoveAt(_In_ unsigned int index)
{ {
HRESULT hr = S_OK;
if (index < m_vector.size()) if (index < m_vector.size())
{ {
m_vector.erase(m_vector.begin() + index); m_vector.erase(m_vector.begin() + index);
} }
else else
{ {
hr = E_BOUNDS; return E_BOUNDS;
} }
return hr; return S_OK;
} }
HRESULT InsertAt(_In_ unsigned int index, _In_ TType item) HRESULT InsertAt(_In_ unsigned int index, _In_ TType item)
{ {
HRESULT hr = S_OK;
try try
{ {
auto iter = m_vector.begin() + index; auto iter = m_vector.begin() + index;
@ -65,14 +61,13 @@ public:
} }
catch (const std::bad_alloc& /*ex*/) catch (const std::bad_alloc& /*ex*/)
{ {
hr = E_OUTOFMEMORY; return E_OUTOFMEMORY;
} }
return hr; return S_OK;
} }
HRESULT Truncate(_In_ unsigned int index) HRESULT Truncate(_In_ unsigned int index)
{ {
HRESULT hr = S_OK;
if (index < m_vector.size()) if (index < m_vector.size())
{ {
auto startIter = m_vector.begin() + index; auto startIter = m_vector.begin() + index;
@ -80,23 +75,22 @@ public:
} }
else else
{ {
hr = E_BOUNDS; return E_BOUNDS;
} }
return hr; return S_OK;
} }
HRESULT Append(_In_opt_ TType item) HRESULT Append(_In_opt_ TType item)
{ {
HRESULT hr = S_OK;
try try
{ {
m_vector.push_back(item); m_vector.push_back(item);
} }
catch (const std::bad_alloc& /*ex*/) catch (const std::bad_alloc& /*ex*/)
{ {
hr = E_OUTOFMEMORY; return E_OUTOFMEMORY;
} }
return hr; return S_OK;
} }
HRESULT RemoveAtEnd() HRESULT RemoveAtEnd()