From c546c13d0b2ef1476ac17190ee91650a5f21b552 Mon Sep 17 00:00:00 2001 From: Rudy Huyn Date: Sun, 31 Mar 2019 16:59:30 -0700 Subject: [PATCH] Add comments --- src/CalcManager/CEngine/scioper.cpp | 3 ++- src/CalcManager/Ratpack/itrans.cpp | 12 +++--------- src/CalcManager/Ratpack/logic.cpp | 2 +- 3 files changed, 6 insertions(+), 11 deletions(-) diff --git a/src/CalcManager/CEngine/scioper.cpp b/src/CalcManager/CEngine/scioper.cpp index 22dabdba..80cfe3b2 100644 --- a/src/CalcManager/CEngine/scioper.cpp +++ b/src/CalcManager/CEngine/scioper.cpp @@ -114,12 +114,13 @@ CalcEngine::Rational CCalcEngine::DoOperation(int operation, CalcEngine::Rationa { if (m_fIntegerMode) { - // Programmer mode + // Programmer mode, use remrat (remainder after division) iFinalSign = iNumeratorSign; result %= temp; } else { + //other modes, use modrat (modulus after division) iFinalSign = iDenominatorSign; result = Mod(result, temp); } diff --git a/src/CalcManager/Ratpack/itrans.cpp b/src/CalcManager/Ratpack/itrans.cpp index fa80b760..0d2a297e 100644 --- a/src/CalcManager/Ratpack/itrans.cpp +++ b/src/CalcManager/Ratpack/itrans.cpp @@ -92,11 +92,9 @@ void asinanglerat( _Inout_ PRAT *pa, ANGLE_TYPE angletype, uint32_t radix, int32 void asinrat( PRAT *px, uint32_t radix, int32_t precision) { - int32_t sgn; PRAT pret= nullptr; PRAT phack= nullptr; - - sgn = SIGN(*px); + int32_t sgn = SIGN(*px); (*px)->pp->sign = 1; (*px)->pq->sign = 1; @@ -204,9 +202,7 @@ void _acosrat( PRAT *px, int32_t precision) void acosrat( PRAT *px, uint32_t radix, int32_t precision) { - int32_t sgn; - - sgn = SIGN(*px); + int32_t sgn = SIGN(*px); (*px)->pp->sign = 1; (*px)->pq->sign = 1; @@ -291,10 +287,8 @@ void _atanrat( PRAT *px, int32_t precision) void atanrat( PRAT *px, uint32_t radix, int32_t precision) { - int32_t sgn; PRAT tmpx= nullptr; - - sgn = SIGN(*px); + int32_t sgn = SIGN(*px); (*px)->pp->sign = 1; (*px)->pq->sign = 1; diff --git a/src/CalcManager/Ratpack/logic.cpp b/src/CalcManager/Ratpack/logic.cpp index 223769ee..6444898e 100644 --- a/src/CalcManager/Ratpack/logic.cpp +++ b/src/CalcManager/Ratpack/logic.cpp @@ -236,7 +236,7 @@ void remrat(PRAT *pa, PRAT b) void modrat(PRAT *pa, PRAT b) { - //contrary to remrat, modrat(a, 0) must return a + //contrary to remrat(X, 0) returning 0, modrat(X, 0) must return X if (zerrat(b)) { return;