github/msft-calculator
1
0
Fork 0
mirror of https://github.com/Microsoft/calculator.git synced 2025-07-29 19:18:24 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Simplify OnAppPropertyChanged (#1914)

Browse source 
Use a switch statement instead of else-if
This commit is contained in:
Rose 2022-09-28 20:07:07 -04:00 • committed by GitHub
parent 35f4d7e75a
commit be5c839bcf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 48 additions and 48 deletions
Download patch file Download diff file Expand all files Collapse all files

96
src/Calculator/Views/MainPage.xaml.cs
View file

@ -206,58 +206,58 @@ namespace CalculatorApp
KeyboardShortcutManager.DisableShortcuts(false); KeyboardShortcutManager.DisableShortcuts(false);
if (newValue == ViewMode.Standard) switch (newValue)
{ {
EnsureCalculator(); case ViewMode.Standard:
Model.CalculatorViewModel.HistoryVM.AreHistoryShortcutsEnabled = true; EnsureCalculator();
m_calculator.AnimateCalculator(NavCategory.IsConverterViewMode(previousMode)); Model.CalculatorViewModel.HistoryVM.AreHistoryShortcutsEnabled = true;
Model.CalculatorViewModel.HistoryVM.ReloadHistory(newValue);
}
else if (newValue == ViewMode.Scientific)
{
EnsureCalculator();
Model.CalculatorViewModel.HistoryVM.AreHistoryShortcutsEnabled = true;
if (Model.PreviousMode != ViewMode.Scientific)
{
m_calculator.AnimateCalculator(NavCategory.IsConverterViewMode(previousMode)); m_calculator.AnimateCalculator(NavCategory.IsConverterViewMode(previousMode));
} Model.CalculatorViewModel.HistoryVM.ReloadHistory(newValue);
break;
Model.CalculatorViewModel.HistoryVM.ReloadHistory(newValue); case ViewMode.Scientific:
} EnsureCalculator();
else if (newValue == ViewMode.Programmer) Model.CalculatorViewModel.HistoryVM.AreHistoryShortcutsEnabled = true;
{ if (Model.PreviousMode != ViewMode.Scientific)
Model.CalculatorViewModel.HistoryVM.AreHistoryShortcutsEnabled = false; {
EnsureCalculator(); m_calculator.AnimateCalculator(NavCategory.IsConverterViewMode(previousMode));
if (Model.PreviousMode != ViewMode.Programmer) }
{ Model.CalculatorViewModel.HistoryVM.ReloadHistory(newValue);
m_calculator.AnimateCalculator(NavCategory.IsConverterViewMode(previousMode)); break;
} case ViewMode.Programmer:
}
else if (NavCategory.IsDateCalculatorViewMode(newValue))
{
if (Model.CalculatorViewModel != null)
{
Model.CalculatorViewModel.HistoryVM.AreHistoryShortcutsEnabled = false; Model.CalculatorViewModel.HistoryVM.AreHistoryShortcutsEnabled = false;
} EnsureCalculator();
EnsureDateCalculator(); if (Model.PreviousMode != ViewMode.Programmer)
} {
else if (newValue == ViewMode.Graphing) m_calculator.AnimateCalculator(NavCategory.IsConverterViewMode(previousMode));
{ }
EnsureGraphingCalculator(); break;
KeyboardShortcutManager.DisableShortcuts(true); case ViewMode.Graphing:
} EnsureGraphingCalculator();
else if (NavCategory.IsConverterViewMode(newValue)) KeyboardShortcutManager.DisableShortcuts(true);
{ break;
if (Model.CalculatorViewModel != null) default:
{ if (NavCategory.IsDateCalculatorViewMode(newValue))
Model.CalculatorViewModel.HistoryVM.AreHistoryShortcutsEnabled = false; {
} if (Model.CalculatorViewModel != null)
{
Model.CalculatorViewModel.HistoryVM.AreHistoryShortcutsEnabled = false;
}
EnsureDateCalculator();
}
else if (NavCategory.IsConverterViewMode(newValue))
{
if (Model.CalculatorViewModel != null)
{
Model.CalculatorViewModel.HistoryVM.AreHistoryShortcutsEnabled = false;
}
EnsureConverter(); EnsureConverter();
if (!NavCategory.IsConverterViewMode(previousMode)) if (!NavCategory.IsConverterViewMode(previousMode))
{ {
m_converter.AnimateConverter(); m_converter.AnimateConverter();
} }
}
break;
} }
ShowHideControls(newValue); ShowHideControls(newValue);