From b5668b934d70dfdc476c31f052daeaf039bdd0ce Mon Sep 17 00:00:00 2001 From: Alexander Riccio Date: Mon, 1 Apr 2019 21:35:30 -0400 Subject: [PATCH] Made changes from review. --- src/CalcManager/Ratpack/basex.cpp | 2 +- src/CalcManager/Ratpack/conv.cpp | 6 +++--- src/CalcManager/Ratpack/num.cpp | 4 ++-- src/CalcManager/Ratpack/ratpak.h | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/CalcManager/Ratpack/basex.cpp b/src/CalcManager/Ratpack/basex.cpp index 41b32c31..dedf7bf5 100644 --- a/src/CalcManager/Ratpack/basex.cpp +++ b/src/CalcManager/Ratpack/basex.cpp @@ -174,7 +174,7 @@ void _mulnumx( PNUMBER *pa, PNUMBER b ) // //----------------------------------------------------------------------------- -void numpowi32x( _Inout_ PNUMBER *proot, _In_ int32_t power ) +void numpowi32x( _Inout_ PNUMBER *proot, int32_t power ) { PNUMBER lret = i32tonum( 1, BASEX ); diff --git a/src/CalcManager/Ratpack/conv.cpp b/src/CalcManager/Ratpack/conv.cpp index 71243dd6..260e5efe 100644 --- a/src/CalcManager/Ratpack/conv.cpp +++ b/src/CalcManager/Ratpack/conv.cpp @@ -373,7 +373,7 @@ PNUMBER nRadixxtonum( _In_ PNUMBER a, uint32_t radix, int32_t precision) // //----------------------------------------------------------------------------- -PNUMBER numtonRadixx(PNUMBER a, uint32_t radix) +PNUMBER numtonRadixx(_In_ PNUMBER a, uint32_t radix) { PNUMBER pnumret = i32tonum(0, BASEX); // pnumret is the number in internal form. PNUMBER num_radix = i32tonum(radix, BASEX); @@ -789,7 +789,7 @@ PNUMBER StringToNumber(wstring_view numberString, uint32_t radix, int32_t precis // //----------------------------------------------------------------------------- -PRAT i32torat( _In_ int32_t ini32 ) +PRAT i32torat( int32_t ini32 ) { PRAT pratret= nullptr; @@ -813,7 +813,7 @@ PRAT i32torat( _In_ int32_t ini32 ) // //----------------------------------------------------------------------------- -PRAT Ui32torat( _In_ uint32_t inui32 ) +PRAT Ui32torat( uint32_t inui32 ) { PRAT pratret= nullptr; diff --git a/src/CalcManager/Ratpack/num.cpp b/src/CalcManager/Ratpack/num.cpp index ed81b068..cf5587aa 100644 --- a/src/CalcManager/Ratpack/num.cpp +++ b/src/CalcManager/Ratpack/num.cpp @@ -192,7 +192,7 @@ void _addnum( _Inout_ PNUMBER *pa, _In_ PNUMBER b, uint32_t radix) // //---------------------------------------------------------------------------- -void _mulnum( _Inout_ PNUMBER *pa, _In_ _Const_ PNUMBER b, uint32_t radix); +void _mulnum( _Inout_ PNUMBER *pa, _In_ PNUMBER b, uint32_t radix); void __inline mulnum( _Inout_ PNUMBER *pa, _In_ PNUMBER b, uint32_t radix) @@ -216,7 +216,7 @@ void __inline mulnum( _Inout_ PNUMBER *pa, _In_ PNUMBER b, uint32_t radix) } } -void _mulnum( _Inout_ PNUMBER *pa, _In_ _Const_ PNUMBER b, uint32_t radix) +void _mulnum( _Inout_ PNUMBER *pa, _In_ PNUMBER b, uint32_t radix) { PNUMBER c= nullptr; // c will contain the result. diff --git a/src/CalcManager/Ratpack/ratpak.h b/src/CalcManager/Ratpack/ratpak.h index 282bb54a..0edd279d 100644 --- a/src/CalcManager/Ratpack/ratpak.h +++ b/src/CalcManager/Ratpack/ratpak.h @@ -336,7 +336,7 @@ extern PNUMBER i32factnum(int32_t ini32, uint32_t radix); extern PNUMBER i32prodnum(int32_t start, int32_t stop, uint32_t radix); extern PNUMBER i32tonum(int32_t ini32, uint32_t radix); extern PNUMBER Ui32tonum(uint32_t ini32, uint32_t radix); -extern PNUMBER numtonRadixx(PNUMBER a, uint32_t radix); +extern PNUMBER numtonRadixx(_In_ PNUMBER a, uint32_t radix); // creates a empty/undefined rational representation (p/q) extern PRAT _createrat( void );