github/msft-calculator
1
0
Fork 0
mirror of https://github.com/Microsoft/calculator.git synced 2025-08-23 06:25:19 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #70 from nventive/dev/djo/standard-xload

Browse source 
[Perf] Set x:Load=false for StandardOperators
This commit is contained in:
David Oliver 2019-05-27 14:42:05 -04:00 • committed by GitHub
commit a1747f758e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 19 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/Calculator.Shared/Views/Calculator.xaml.cs
View file

@ -301,6 +301,11 @@ namespace CalculatorApp
void OnIsStandardPropertyChanged(bool oldValue, bool newValue)
{
if (newValue)
{
EnsureStandard();
}
UpdateViewState();
UpdatePanelViewState();
}
@ -430,6 +435,11 @@ namespace CalculatorApp
}
}
void EnsureStandard()
{
OpsPanel.EnsureStandardOps();
}
void EnsureScientific()
{
OpsPanel.EnsureScientificOps();

2
src/Calculator.Shared/Views/OperatorsPanel.xaml
View file

@ -11,7 +11,7 @@
<Grid>
<!--Bind visibility as a workaround for nventive/Uno#925-->
<local:CalculatorStandardOperators x:Name="StandardOperators"
x:Load="{x:Bind Model.IsStandard, Mode=OneWay}"
x:Load="False"
IsEnabled="{x:Bind Model.IsStandard, Mode=OneWay}"
Visibility="{x:Bind Model.IsStandard, Mode=OneWay}"
TabIndex="17" />

8
src/Calculator.Shared/Views/OperatorsPanel.xaml.cs
View file

@ -88,6 +88,14 @@ namespace CalculatorApp
}
}
internal void EnsureStandardOps()
{
if (StandardOperators == null)
{
this.FindName("StandardOperators");
}
}
internal void EnsureScientificOps()
{
if (ScientificOperators == null)