From 8fa9a691cc2490299753e753eff65c060d737559 Mon Sep 17 00:00:00 2001 From: Jared Fuchs Date: Wed, 6 Mar 2019 15:24:21 -0500 Subject: [PATCH 1/2] Fix comment on IsEven Looks like the comment on IsEven should read this way instead of "The assumption here is its numerator is 1 and we are testing the numerator is even or not" --- src/CalcManager/Ratpack/exp.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/CalcManager/Ratpack/exp.cpp b/src/CalcManager/Ratpack/exp.cpp index ec87204a..97d02c6b 100644 --- a/src/CalcManager/Ratpack/exp.cpp +++ b/src/CalcManager/Ratpack/exp.cpp @@ -235,7 +235,7 @@ void log10rat( PRAT *px, int32_t precision) } // -// return if the given x is even number. The assumption here is its numerator is 1 and we are testing the numerator is +// return if the given x is even number. The assumption here is its denominator is 1 and we are testing the numerator is // even or not bool IsEven(PRAT x, uint32_t radix, int32_t precision) { From 6a1c2e4bbfd81a9018c8b3e39d2d4afef5caf9f2 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Wed, 6 Mar 2019 21:47:27 -0500 Subject: [PATCH 2/2] Fix smart quotes (#131) --- docs/ManualTests.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/ManualTests.md b/docs/ManualTests.md index deb8111a..6fbc6716 100644 --- a/docs/ManualTests.md +++ b/docs/ManualTests.md @@ -11,7 +11,7 @@ These manual tests are run before every release of the Calculator app. Steps: 1. From the Standard Calculator page, input “3”, “+”, “3”, “Enter” on the keyboard Expected: “6” shows up in the display -2. Input “4”, “-“, “2”, “=” using the in-app buttons +2. Input “4”, “-”, “2”, “=” using the in-app buttons *Expected: “2” shows up in the display* **Test 2** @@ -31,7 +31,7 @@ Steps: **Test 2** Steps: -1. Input “5”, “n!“, “=” using the in-app buttons +1. Input “5”, “n!”, “=” using the in-app buttons *Expected: “120” shows up in the display* ### Math in Programmer Calculator