github/msft-calculator
1
0
Fork 0
mirror of https://github.com/Microsoft/calculator.git synced 2025-08-22 22:23:29 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix the Missing Part in Unit Converter Constructor (#1579)

Browse source
This commit is contained in:
hanzhang54 2021-06-11 12:45:25 +08:00 • committed by GitHub
commit 9017f074d3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 26 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

28
src/Calculator/Views/UnitConverter.xaml.cs
View file

@ -40,7 +40,32 @@ namespace CalculatorApp
{ {
public UnitConverter() public UnitConverter()
{ {
this.InitializeComponent(); m_meteredConnectionOverride = false;
m_layoutDirection = LocalizationService.GetInstance().GetFlowDirection();
m_FlowDirectionHorizontalAlignment = m_layoutDirection == FlowDirection.RightToLeft ? HorizontalAlignment.Right : HorizontalAlignment.Left;
InitializeComponent();
// adding ESC key shortcut binding to clear button
ClearEntryButtonPos0.SetValue(KeyboardShortcutManager.VirtualKeyProperty, MyVirtualKey.Escape);
// Is currency symbol preference set to right side
bool preferRight = LocalizationSettings.GetInstance().GetCurrencySymbolPrecedence() == 0;
VisualStateManager.GoToState(this, preferRight ? "CurrencySymbolRightState" : "CurrencySymbolLeftState", false);
var resLoader = AppResourceProvider.GetInstance();
m_chargesMayApplyText = resLoader.GetResourceString("DataChargesMayApply");
m_failedToRefreshText = resLoader.GetResourceString("FailedToRefresh");
InitializeOfflineStatusTextBlock();
if (Resources.TryGetValue("CalculationResultContextMenu", out var value))
{
m_resultsFlyout = (MenuFlyout)value;
}
CopyMenuItem.Text = resLoader.GetResourceString("copyMenuItem");
PasteMenuItem.Text = resLoader.GetResourceString("pasteMenuItem");
} }
public Windows.UI.Xaml.HorizontalAlignment FlowDirectionHorizontalAlignment public Windows.UI.Xaml.HorizontalAlignment FlowDirectionHorizontalAlignment
@ -185,7 +210,6 @@ namespace CalculatorApp
private void OnDataContextChanged(FrameworkElement sender, DataContextChangedEventArgs args) private void OnDataContextChanged(FrameworkElement sender, DataContextChangedEventArgs args)
{ {
// CSHARP_MIGRATION: TODO: double check the original code with below migrated code
Model.PropertyChanged -= OnPropertyChanged; Model.PropertyChanged -= OnPropertyChanged;
Model.PropertyChanged += OnPropertyChanged; Model.PropertyChanged += OnPropertyChanged;